Data::getUrl() - Code Metrics - Inspection of "Updated .scrutinizer.yml." - rattfieldnz/shodan - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — master (c3101c)

by Rob

created 2019-08-18 04:42 UTC

Data::getUrl() A

↳ Parent: Data

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	1
c	1
b	0
f	0
dl	0
loc	3
rs	10
cc	1
nc	1
nop	0

1			<?php
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Class found in ".php" file; use ".inc" extension instead Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report This file is missing a doc comment. Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report The PHP open tag does not have a corresponding PHP close tag Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Filename "Data.php" doesn't match the expected filename "data.php" Loading history...
2
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Missing file doc comment Loading history...
3			namespace RattfieldNz\Shodan\Libraries\Data;
4
5			use RattfieldNz\Shodan\Libraries\Config\Config;
6
7			/**
8			* Class Data.
9			*
10			* @category PHP
			0 ignored issues – show Coding Style Documentation introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report @category tag is not allowed in class comment Loading history...
11			*
12			* @author Rob Attfield <[email protected]>
			0 ignored issues – show Coding Style Documentation introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report @author tag is not allowed in class comment Loading history... introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 1 space but found 2 Loading history...
13			* @license https://github.com/rattfieldnz/shodan/blob/master/LICENSE MIT
			0 ignored issues – show Coding Style Documentation introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report @license tag is not allowed in class comment Loading history...
14			*/
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Missing @package tag in class comment Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
15			class Data
16			{
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Opening brace should be on the same line as the declaration for class Data Loading history... introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Opening brace should be on the same line as the declaration Loading history...
17			private $_ip;
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 2 spaces, found 4 Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Expected 1 blank line(s) before first member var; 0 found Loading history... Coding Style Documentation introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Missing member variable doc comment Loading history... introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Class property $_ip should use lowerCamel naming without underscores Loading history...
18			private $_url;
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 2 spaces, found 4 Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Expected 1 blank line(s) before member var; 0 found Loading history... Coding Style Documentation introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Missing member variable doc comment Loading history... introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Class property $_url should use lowerCamel naming without underscores Loading history...
19
20			public function __construct(string $url)
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 2 spaces, found 4 Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Missing doc comment for function __construct() Loading history... introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
21			{
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Opening brace should be on the same line as the declaration Loading history...
22			$this->_url = $url;
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 4 spaces, found 8 Loading history...
23			$this->_ip = $this->getIp($this->_url);
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 4 spaces, found 8 Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
24			}
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 2 spaces, found 4 Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Expected 1 blank line before closing function brace; 0 found Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Expected //end __construct() Loading history...
25
26			/**
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 2 spaces, found 4 Loading history...
27			* Get Shodan API URL with key.
28			*
29			* @return string
			0 ignored issues – show introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Description for the @return value is missing Loading history...
30			*/
31			public function shodanApiUrl()
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 2 spaces, found 4 Loading history...
32			{
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Opening brace should be on the same line as the declaration Loading history...
33			return 'https://api.shodan.io/shodan/host/'.$this->_ip.'?key='.
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 4 spaces, found 8 Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Concat operator must be surrounded by a single space Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Expected at least 1 space before "."; 0 found Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Expected at least 1 space after "."; 0 found Loading history...
34			Config::shodanApiKey();
35			}
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 2 spaces, found 4 Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Expected 1 blank line before closing function brace; 0 found Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Expected //end shodanApiUrl() Loading history...
36
37			/**
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 2 spaces, found 4 Loading history...
38			* Get IPv4 address from a URL.
39			*
40			* @param string $url
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
41			*
42			* @return string\|null
			0 ignored issues – show introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Description for the @return value is missing Loading history...
43			*/
44			public function getIp(string $url): string
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 2 spaces, found 4 Loading history...
45			{
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Opening brace should be on the same line as the declaration Loading history...
46			$domain = parse_url($url)['host'];
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 4 spaces, found 8 Loading history...
47			$ip = gethostbyname($domain);
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 4 spaces, found 8 Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
48
49			return filter_var($ip, FILTER_VALIDATE_IP) ? $ip : null;
			0 ignored issues – show Bug Best Practice introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report The expression `return filter_var($ip, R...LIDATE_IP) ? $ip : null` could return the type `null` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 4 spaces, found 8 Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Inline IF statements are not allowed Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report `TRUE`, `FALSE` and `NULL` should be uppercase as per the configured coding-style; instead of `null` please use `NULL`. Loading history...
50			}
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 2 spaces, found 4 Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Expected 1 blank line before closing function brace; 0 found Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Expected //end getIp() Loading history...
51
52			/**
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 2 spaces, found 4 Loading history...
53			* Returns URL set when initialising Data object.
54			*
55			* @return string
			0 ignored issues – show introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Description for the @return value is missing Loading history...
56			*/
57			public function getUrl()
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 2 spaces, found 4 Loading history...
58			{
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Opening brace should be on the same line as the declaration Loading history...
59			return $this->_url;
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 4 spaces, found 8 Loading history...
60			}
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 2 spaces, found 4 Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Expected 1 blank line after function; 0 found Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Expected 1 blank line before closing function brace; 0 found Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Expected //end getUrl() Loading history...
61			}
			0 ignored issues – show Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report Expected //end class Loading history... Coding Style introduced 2019-08-18 04:45 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
62

rattfieldnz / shodan

GitHub Access Token became invalid

Branch — master (c3101c)

Data::getUrl() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like