Issues in StripeConnect.php (master) - Issues in master - rap2hpoutre/laravel-stripe-connect - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/StripeConnect.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


namespace Rap2hpoutre\LaravelStripeConnect;

use Stripe\Account as StripeAccount;
use Stripe\Customer;
use Stripe\Stripe as StripeBase;


/**
 * Class StripeConnect
 * @package Rap2hpoutre\LaravelStripeConnect
 */
class StripeConnect
{

    /**
     *
     */
    private static function prepare()
    {
        StripeBase::setApiKey(config('services.stripe.secret'));
    }

    /**
     * @param $user
     * @return Stripe
     */
    private static function getStripeModel($user)
    {
        $stripe = Stripe::where('user_id', $user->id)->first();
        if (!$stripe) {
            $stripe = new Stripe();
            $stripe->user_id = $user->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $stripe->save();
        }
        return $stripe;
    }

    /**
     * @param $to
     * @param array $params
     * @return Stripe
     */
    public static function createAccount($to, $params = [])
    {
        $params = array_merge([
            "type" => "custom",
            "email" => $to->email,
        ], $params);
        return self::create($to, 'account_id', function () use ($params) {
            return StripeAccount::create($params);
        });
    }

    /**
     * @param $token
     * @param $from
     * @param array $params
     * @return Stripe
     */
    public static function createCustomer($token, $from, $params = [])
    {
        $params = array_merge([
            "email" => $from->email,
            'source' => $token,
        ], $params);
        return self::create($from, 'customer_id', function () use ($params) {
            return Customer::create($params);
        });
    }

    /**
     * @param $token
     * @param $from
     * @param array $params
     * @return Stripe
     */
    public function createOrUpdateCustomer($token, $from, $params = [])
    {
        self::prepare();
        $user = self::getStripeModel($from);
        if (!$user) {
            return self::createCustomer($token, $from, $params);
        }
        $customer = \Stripe\Customer::retrieve($token->customer_id);
        $customer->source = $token;

        $customer->save();
        return $user;
    }

    /**
     * @param $user
     * @param $id_key
     * @param $callback
     * @return Stripe
     */
    private static function create($user, $id_key, $callback) {
        self::prepare();
        $user = self::getStripeModel($user);
        if (!$user->$id_key) {
            $user->$id_key = call_user_func($callback)->id;
            $user->save();
        }
        return $user;
    }

    /**
     * @param null $token
     * @return Transaction
     */
    public static function transaction($token = null)
    {
        return new Transaction($token);
    }
}

1			<?php
2
3
4			namespace Rap2hpoutre\LaravelStripeConnect;
5
6			use Stripe\Account as StripeAccount;
7			use Stripe\Customer;
8			use Stripe\Stripe as StripeBase;
9
10
11			/**
12			* Class StripeConnect
13			* @package Rap2hpoutre\LaravelStripeConnect
14			*/
15			class StripeConnect
16			{
17
18			/**
19			*
20			*/
21			private static function prepare()
22			{
23			StripeBase::setApiKey(config('services.stripe.secret'));
24			}
25
26			/**
27			* @param $user
28			* @return Stripe
29			*/
30			private static function getStripeModel($user)
31			{
32			$stripe = Stripe::where('user_id', $user->id)->first();
33			if (!$stripe) {
34			$stripe = new Stripe();
35			$stripe->user_id = $user->id;
			0 ignored issues – show Documentation introduced 2018-04-19 13:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `user_id` does not exist on `object<Rap2hpoutre\LaravelStripeConnect\Stripe>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
36			$stripe->save();
37			}
38			return $stripe;
39			}
40
41			/**
42			* @param $to
43			* @param array $params
44			* @return Stripe
45			*/
46			public static function createAccount($to, $params = [])
47			{
48			$params = array_merge([
49			"type" => "custom",
50			"email" => $to->email,
51			], $params);
52			return self::create($to, 'account_id', function () use ($params) {
53			return StripeAccount::create($params);
54			});
55			}
56
57			/**
58			* @param $token
59			* @param $from
60			* @param array $params
61			* @return Stripe
62			*/
63			public static function createCustomer($token, $from, $params = [])
64			{
65			$params = array_merge([
66			"email" => $from->email,
67			'source' => $token,
68			], $params);
69			return self::create($from, 'customer_id', function () use ($params) {
70			return Customer::create($params);
71			});
72			}
73
74			/**
75			* @param $token
76			* @param $from
77			* @param array $params
78			* @return Stripe
79			*/
80			public function createOrUpdateCustomer($token, $from, $params = [])
81			{
82			self::prepare();
83			$user = self::getStripeModel($from);
84			if (!$user) {
85			return self::createCustomer($token, $from, $params);
86			}
87			$customer = \Stripe\Customer::retrieve($token->customer_id);
88			$customer->source = $token;
			0 ignored issues – show Bug introduced 2018-01-24 16:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `source` does not seem to exist. Did you mean `default_source`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
89			$customer->save();
90			return $user;
91			}
92
93			/**
94			* @param $user
95			* @param $id_key
96			* @param $callback
97			* @return Stripe
98			*/
99			private static function create($user, $id_key, $callback) {
100			self::prepare();
101			$user = self::getStripeModel($user);
102			if (!$user->$id_key) {
103			$user->$id_key = call_user_func($callback)->id;
104			$user->save();
105			}
106			return $user;
107			}
108
109			/**
110			* @param null $token
111			* @return Transaction
112			*/
113			public static function transaction($token = null)
114			{
115			return new Transaction($token);
116			}
117			}

rap2hpoutre / laravel-stripe-connect

Issues (4)

Security Analysis no request data

src/StripeConnect.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like