BillingBoss\Interpreter\PercentageBillInterpreter

Complexity

Total Complexity

6

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	interpret()	0	23	4
A	isValid()	0	4	1
A	__construct()	0	4	1

<?php

namespace BillingBoss\Interpreter;

use BillingBoss\Expr;
use BillingBoss\BillContext;
use BillingBoss\AbstractBillInterpreter;
use BillingBoss\RangeHelper;

final class PercentageBillInterpreter extends AbstractBillInterpreter
{
    private const EXPRESSION = Expr::PERCENT .
                               Expr::COMMA .
                               Expr::RANGE;
    private $ranges = [];

    public function __construct()
    {
        // parent::__construct('/^\s*(-?\d*\.?\d+)\s*%$/');
        parent::__construct(sprintf('/^(%1$s)(%2$s%1$s)*$/', self::EXPRESSION, Expr::PIPE));
    }

    public function isValid(BillContext $context): bool
    {
        list($result, $this->ranges) = RangeHelper::validate($context->getStructure());
        return $result === RangeHelper::VALIDATION_OK;
    }

    public function interpret(BillContext $context): float
    {
        if (!$this->isValid($context)) {
            return 0.0;
        }
        $bill = 0.0;

        $parts = preg_split(sprintf('/%s/', Expr::PIPE), $context->getStructure());
        for ($i = 0; $i < count($parts); $i++) {

It seems like $parts can also be of type false; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $range = $this->ranges[$i];
            $matches = [];

            \preg_match(sprintf('/^%s$/', self::EXPRESSION), $parts[$i], $matches);

            $amount = $context->getAmount();

            if (RangeHelper::isInRange($range, $amount)) {
                $bill = ($matches[1] * $amount)/ 100.00;
                break;
            }
        }

        return $bill;
    }
}