RDV\Bundle\MigrationBundle\Tests\Unit\Migration\MigrationExecutorWithNameGeneratorTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	136
Duplicated Lines	37.5 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	10	1
B	testExecuteUp()	0	36	1
B	testExecuteUpWithDryRun()	0	26	1
B	testWrongTableNameQuery()	25	25	1
B	testWrongColumnNameQuery()	26	26	1

<?php

namespace RDV\Bundle\MigrationBundle\Tests\Unit\Migration;

use RDV\Bundle\MigrationBundle\Migration\MigrationState;
use RDV\Bundle\MigrationBundle\Tests\Unit\Fixture\TestPackage\Test1Bundle\Migrations\Schema\v1_0\Test1BundleMigration10;
use RDV\Bundle\MigrationBundle\Tests\Unit\Fixture\TestPackage\Test1Bundle\Migrations\Schema\v1_1\Test1BundleMigration11;

use RDV\Bundle\MigrationBundle\Migration\MigrationExecutorWithNameGenerator;
use RDV\Bundle\MigrationBundle\Tools\DbIdentifierNameGenerator;
use RDV\Bundle\MigrationBundle\Tests\Unit\Fixture\TestPackage\WrongTableNameMigration;
use RDV\Bundle\MigrationBundle\Tests\Unit\Fixture\TestPackage\WrongColumnNameMigration;

class MigrationExecutorWithNameGeneratorTest extends AbstractTestMigrationExecutor
{
    /** @var MigrationExecutorWithNameGenerator */
    protected $executor;

    /** @var DbIdentifierNameGenerator */
    protected $nameGenerator;

    protected function setUp()
    {
        parent::setUp();

        $this->nameGenerator = new DbIdentifierNameGenerator();

        $this->executor = new MigrationExecutorWithNameGenerator($this->queryExecutor);
        $this->executor->setLogger($this->logger);
        $this->executor->setNameGenerator($this->nameGenerator);
    }

    public function testExecuteUp()
    {
        $migration10 = new Test1BundleMigration10();
        $migration11 = new Test1BundleMigration11();
        $migrations = [
            new MigrationState($migration10),
            new MigrationState($migration11)
        ];

        $this->connection->expects($this->at(2))
            ->method('executeQuery')
            ->with('CREATE TABLE TEST (id INT AUTO_INCREMENT NOT NULL)');
        $this->connection->expects($this->at(3))
            ->method('executeQuery')
            ->with(
                'CREATE TABLE test1table (id INT NOT NULL) DEFAULT CHARACTER SET utf8 '
                . 'COLLATE utf8_unicode_ci ENGINE = InnoDB'
            );
        $this->connection->expects($this->at(4))
            ->method('executeQuery')
            ->with('ALTER TABLE TEST ADD COLUMN test_column INT NOT NULL');

        $this->executor->executeUp($migrations);
        $messages = $this->logger->getMessages();
        $this->assertEquals(
            [
                '> ' . get_class($migration10),
                'CREATE TABLE TEST (id INT AUTO_INCREMENT NOT NULL)',
                '> ' . get_class($migration11),
                'CREATE TABLE test1table (id INT NOT NULL) DEFAULT CHARACTER SET utf8 '
                . 'COLLATE utf8_unicode_ci ENGINE = InnoDB',
                'ALTER TABLE TEST ADD COLUMN test_column INT NOT NULL',
            ],
            $messages
        );
    }

    public function testExecuteUpWithDryRun()
    {
        $migration10 = new Test1BundleMigration10();
        $migration11 = new Test1BundleMigration11();
        $migrations = [
            new MigrationState($migration10),
            new MigrationState($migration11)
        ];

        $this->connection->expects($this->never())
            ->method('executeQuery');

        $this->executor->executeUp($migrations, true);
        $messages = $this->logger->getMessages();
        $this->assertEquals(
            [
                '> ' . get_class($migration10),
                'CREATE TABLE TEST (id INT AUTO_INCREMENT NOT NULL)',
                '> ' . get_class($migration11),
                'CREATE TABLE test1table (id INT NOT NULL) DEFAULT CHARACTER SET utf8 '
                . 'COLLATE utf8_unicode_ci ENGINE = InnoDB',
                'ALTER TABLE TEST ADD COLUMN test_column INT NOT NULL',
            ],
            $messages
        );
    }

    public function testWrongTableNameQuery()

This method seems to be duplicated in your project.

    {
        $migration = new WrongTableNameMigration();
        $migrations = [
            new MigrationState($migration)
        ];
        $this->setExpectedException(
            '\RuntimeException',
            'Failed migrations: RDV\Bundle\MigrationBundle\Tests\Unit\Fixture\TestPackage\WrongTableNameMigration.'
        );
        $this->executor->executeUp($migrations);
        $this->assertEquals(
            '> RDV\Bundle\MigrationBundle\Tests\Unit\Fixture\TestPackage\WrongTableNameMigration',
            $this->logger->getMessages()[0]
        );
        $this->assertEquals(
            sprintf(
                '  ERROR: Max table name length is %s. Please correct "%s" table in "%s" migration',
                $this->nameGenerator->getMaxIdentifierSize(),
                'extra_long_table_name_bigger_than_30_chars',
                get_class($migration)
            ),
            $this->logger->getMessages()[1]
        );
    }

    public function testWrongColumnNameQuery()

This method seems to be duplicated in your project.

    {
        $migration = new WrongColumnNameMigration();
        $migrations = [
            new MigrationState($migration)
        ];
        $this->setExpectedException(
            '\RuntimeException',
            'Failed migrations: RDV\Bundle\MigrationBundle\Tests\Unit\Fixture\TestPackage\WrongColumnNameMigration.'
        );
        $this->executor->executeUp($migrations);
        $this->assertEquals(
            '> RDV\Bundle\MigrationBundle\Tests\Unit\Fixture\TestPackage\WrongColumnNameMigration',
            $this->logger->getMessages()[0]
        );
        $this->assertEquals(
            sprintf(
                '  ERROR: Max column name length is %s. Please correct "%s:%s" column in "%s" migration',
                $this->nameGenerator->getMaxIdentifierSize(),
                'wrong_table',
                'extra_long_column_bigger_30_chars',
                get_class($migration)
            ),
            $this->logger->getMessages()[1]
        );
    }
}