RDV\Bundle\MigrationBundle\Migration\Extension\RenameExtension

Complexity

Total Complexity

10

Size/Duplication

Total Lines	180
Duplicated Lines	22.22 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes	1
Bugs	1	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	setDatabasePlatform()	0	4	1
A	setNameGenerator()	0	4	1
A	renameTable()	0	12	1
A	renameColumn()	0	13	1
A	addIndex()	20	20	2
A	addUniqueIndex()	20	20	2
B	addForeignKeyConstraint()	0	32	2

<?php

namespace RDV\Bundle\MigrationBundle\Migration\Extension;

use Doctrine\DBAL\Platforms\AbstractPlatform;
use Doctrine\DBAL\Schema\ForeignKeyConstraint;
use Doctrine\DBAL\Schema\Index;
use Doctrine\DBAL\Schema\Schema;
use Doctrine\DBAL\Schema\Table;
use Doctrine\DBAL\Schema\TableDiff;
use RDV\Bundle\MigrationBundle\Migration\QueryBag;
use RDV\Bundle\MigrationBundle\Migration\Schema\Column;
use RDV\Bundle\MigrationBundle\Migration\SqlMigrationQuery;
use RDV\Bundle\MigrationBundle\Tools\DbIdentifierNameGenerator;

class RenameExtension implements DatabasePlatformAwareInterface, NameGeneratorAwareInterface
{
    /**
     * @var AbstractPlatform
     */
    protected $platform;

    /**
     * @var DbIdentifierNameGenerator
     */
    protected $nameGenerator;

    /**
     * {@inheritdoc}
     */
    public function setDatabasePlatform(AbstractPlatform $platform)
    {
        $this->platform = $platform;
    }

    /**
     * {@inheritdoc}
     */
    public function setNameGenerator(DbIdentifierNameGenerator $nameGenerator)
    {
        $this->nameGenerator = $nameGenerator;
    }

    /**
     * Renames a table
     *
     * @param Schema   $schema
     * @param QueryBag $queries
     * @param string   $oldTableName
     * @param string   $newTableName
     */
    public function renameTable(Schema $schema, QueryBag $queries, $oldTableName, $newTableName)
    {
        $table         = $schema->getTable($oldTableName);
        $diff          = new TableDiff($table->getName());
        $diff->newName = $newTableName;

        $renameQuery = new SqlMigrationQuery(
            $this->platform->getAlterTableSQL($diff)
        );

        $queries->addQuery($renameQuery);
    }

    /**
     * Renames a column
     *
     * @param Schema   $schema
     * @param QueryBag $queries
     * @param Table    $table
     * @param string   $oldColumnName
     * @param string   $newColumnName
     */
    public function renameColumn(Schema $schema, QueryBag $queries, Table $table, $oldColumnName, $newColumnName)

The parameter $schema is not used and could be removed.

    {
        $column = new Column(['column' => $table->getColumn($oldColumnName)]);
        $column->changeName($newColumnName);
        $diff                 = new TableDiff($table->getName());
        $diff->renamedColumns = [$oldColumnName => $column];

It seems like array($oldColumnName => $column) of type array<string,object<RDV\Bundle\MigrationBundle\Migration\Schema\Column>> is incompatible with the declared type array<integer,object<Doctrine\DBAL\Schema\Column>> of property $renamedColumns.

        $renameQuery = new SqlMigrationQuery(
            $this->platform->getAlterTableSQL($diff)
        );

        $queries->addQuery($renameQuery);
    }

    /**
     * Create an index without check of table and columns existence.
     * This method can be helpful when you need to create an index for renamed table or column
     *
     * @param Schema      $schema
     * @param QueryBag    $queries
     * @param string      $tableName
     * @param string[]    $columnNames
     * @param string|null $indexName
     */
    public function addIndex(

This method seems to be duplicated in your project.

        Schema $schema,

The parameter $schema is not used and could be removed.

        QueryBag $queries,
        $tableName,
        array $columnNames,
        $indexName = null
    ) {
        if (!$indexName) {

The expression $indexName of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            $indexName = $this->nameGenerator->generateIndexName($tableName, $columnNames);
        }
        $index              = new Index($indexName, $columnNames);
        $diff               = new TableDiff($tableName);
        $diff->addedIndexes = [$indexName => $index];

It seems like array($indexName => $index) of type array<string,object<Doctrine\DBAL\Schema\Index>> is incompatible with the declared type array<integer,object<Doctrine\DBAL\Schema\Index>> of property $addedIndexes.

        $renameQuery = new SqlMigrationQuery(
            $this->platform->getAlterTableSQL($diff)
        );

        $queries->addQuery($renameQuery);
    }

    /**
     * Create an unique index without check of table and columns existence.
     * This method can be helpful when you need to create an index for renamed table or column
     *
     * @param Schema      $schema
     * @param QueryBag    $queries
     * @param string      $tableName
     * @param string[]    $columnNames
     * @param string|null $indexName
     */
    public function addUniqueIndex(

This method seems to be duplicated in your project.

        Schema $schema,

The parameter $schema is not used and could be removed.

        QueryBag $queries,
        $tableName,
        array $columnNames,
        $indexName = null
    ) {
        if (!$indexName) {

The expression $indexName of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            $indexName = $this->nameGenerator->generateIndexName($tableName, $columnNames, true);
        }
        $index              = new Index($indexName, $columnNames, true);
        $diff               = new TableDiff($tableName);
        $diff->addedIndexes = [$indexName => $index];

It seems like array($indexName => $index) of type array<string,object<Doctrine\DBAL\Schema\Index>> is incompatible with the declared type array<integer,object<Doctrine\DBAL\Schema\Index>> of property $addedIndexes.

        $renameQuery = new SqlMigrationQuery(
            $this->platform->getAlterTableSQL($diff)
        );

        $queries->addQuery($renameQuery);
    }

    /**
     * Create a foreign key constraint without check of table and columns existence.
     * This method can be helpful when you need to create a constraint for renamed table or column
     *
     * @param Schema      $schema
     * @param QueryBag    $queries
     * @param string      $tableName
     * @param string      $foreignTable
     * @param string[]    $localColumnNames
     * @param string[]    $foreignColumnNames
     * @param array       $options
     * @param string|null $constraintName
     */
    public function addForeignKeyConstraint(
        Schema $schema,

The parameter $schema is not used and could be removed.

        QueryBag $queries,
        $tableName,
        $foreignTable,
        array $localColumnNames,
        array $foreignColumnNames,
        array $options = [],
        $constraintName = null
    ) {
        if (!$constraintName) {

The expression $constraintName of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            $constraintName = $this->nameGenerator->generateForeignKeyConstraintName(
                $tableName,
                $localColumnNames
            );
        }
        $constraint = new ForeignKeyConstraint(
            $localColumnNames,
            $foreignTable,
            $foreignColumnNames,
            $constraintName,
            $options
        );
        $diff = new TableDiff($tableName);
        $diff->addedForeignKeys = [$constraintName => $constraint];

It seems like array($constraintName => $constraint) of type array<string,object<Doctrine\DBAL\Schema\ForeignKeyConstraint>> is incompatible with the declared type array<integer,object<Doctrine\DBAL\Schema\ForeignKeyConstraint>> of property $addedForeignKeys.

        $renameQuery = new SqlMigrationQuery(
            $this->platform->getAlterTableSQL($diff)
        );

        $queries->addQuery($renameQuery);
    }
}