Issues in RelationProvider.php (master) - Issues in master - rambler-digital-solutions/hydrogen - Measure and Improve Code Quality continuously with Scrutinizer

Issues (124)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Query/RelationProvider.php (2 issues)

Labels

Bug 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This file is part of Hydrogen package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace RDS\Hydrogen\Query;

use RDS\Hydrogen\Criteria\Join;
use RDS\Hydrogen\Query;

/**
 * Trait RelationProvider
 * @mixin Query
 */
trait RelationProvider
{
    /**
     * @internal This method is currently unavailable. Use the "join" instead
     *
     * @param string|array ...$relations
     * @return Query|$this|self
     */
    public function with(...$relations): self
    {
        return $this->leftJoin(...$relations);

        // return $this->addRelation(function(string $field, \Closure $inner = null) {
        //     return new Relation($this, $field, $inner);
        // }, ...$relations);
    }

    /**
     * @param string|array ...$relations
     * @return Query|$this|self
     */
    public function join(...$relations): self
    {
        return $this->addRelation(function(string $field, \Closure $inner = null) {
            return new Join($this, $field, Join::TYPE_JOIN, $inner);
        }, ...$relations);
    }

    /**
     * @param string|array ...$relations
     * @return Query|$this|self
     */
    public function leftJoin(...$relations): self
    {
        return $this->addRelation(function(string $field, \Closure $inner = null) {
            return new Join($this, $field, Join::TYPE_LEFT_JOIN, $inner);
        }, ...$relations);
    }

    /**
     * @param string|array ...$relations
     * @return Query|$this|self
     */
    public function innerJoin(...$relations): self
    {
        return $this->addRelation(function(string $field, \Closure $inner = null) {
            return new Join($this, $field, Join::TYPE_INNER_JOIN, $inner);
        }, ...$relations);
    }

    /**
     * @param \Closure $onCreate
     * @param string|array ...$relations
     * @return Query|$this|self
     */
    private function addRelation(\Closure $onCreate, ...$relations): self
    {
        foreach ($relations as $relation) {
            if (\is_string($relation)) {
                $this->add($onCreate($relation));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                continue;
            }

            if (\is_array($relation)) {
                foreach ($relation as $rel => $sub) {
                    \assert(\is_string($rel) && $sub instanceof \Closure);

                    $this->add($onCreate($rel, $sub));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                }
                continue;
            }

            $error = 'Relation should be string ("relation_name") '.
                'or array (["relation" => function]), ' .
                'but %s given';

            throw new \InvalidArgumentException(\sprintf($error, \gettype($relation)));
        }

        return $this;
    }
}


1		<?php
2		/**
3		* This file is part of Hydrogen package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8		declare(strict_types=1);
9
10		namespace RDS\Hydrogen\Query;
11
12		use RDS\Hydrogen\Criteria\Join;
13		use RDS\Hydrogen\Query;
14
15		/**
16		* Trait RelationProvider
17		* @mixin Query
18		*/
19		trait RelationProvider
20		{
21		/**
22		* @internal This method is currently unavailable. Use the "join" instead
23		*
24		* @param string\|array ...$relations
25		* @return Query\|$this\|self
26		*/
27		public function with(...$relations): self
28		{
29		return $this->leftJoin(...$relations);
30
31		// return $this->addRelation(function(string $field, \Closure $inner = null) {
32		// return new Relation($this, $field, $inner);
33		// }, ...$relations);
34		}
35
36		/**
37		* @param string\|array ...$relations
38		* @return Query\|$this\|self
39		*/
40		public function join(...$relations): self
41		{
42	1	return $this->addRelation(function(string $field, \Closure $inner = null) {
43	1	return new Join($this, $field, Join::TYPE_JOIN, $inner);
44	1	}, ...$relations);
45		}
46
47		/**
48		* @param string\|array ...$relations
49		* @return Query\|$this\|self
50		*/
51		public function leftJoin(...$relations): self
52		{
53	1	return $this->addRelation(function(string $field, \Closure $inner = null) {
54	1	return new Join($this, $field, Join::TYPE_LEFT_JOIN, $inner);
55	1	}, ...$relations);
56		}
57
58		/**
59		* @param string\|array ...$relations
60		* @return Query\|$this\|self
61		*/
62		public function innerJoin(...$relations): self
63		{
64		return $this->addRelation(function(string $field, \Closure $inner = null) {
65		return new Join($this, $field, Join::TYPE_INNER_JOIN, $inner);
66		}, ...$relations);
67		}
68
69		/**
70		* @param \Closure $onCreate
71		* @param string\|array ...$relations
72		* @return Query\|$this\|self
73		*/
74	2	private function addRelation(\Closure $onCreate, ...$relations): self
75		{
76	2	foreach ($relations as $relation) {
77	2	if (\is_string($relation)) {
78	2	$this->add($onCreate($relation));
		0 ignored issues – show Bug introduced 2018-09-03 13:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
79	2	continue;
80		}
81
82		if (\is_array($relation)) {
83		foreach ($relation as $rel => $sub) {
84		\assert(\is_string($rel) && $sub instanceof \Closure);
85
86		$this->add($onCreate($rel, $sub));
		0 ignored issues – show Bug introduced 2018-09-03 13:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
87		}
88		continue;
89		}
90
91		$error = 'Relation should be string ("relation_name") '.
92		'or array (["relation" => function]), ' .
93		'but %s given';
94
95		throw new \InvalidArgumentException(\sprintf($error, \gettype($relation)));
96		}
97
98	2	return $this;
99		}
100		}
101

rambler-digital-solutions / hydrogen

Issues (124)

Security Analysis no request data

src/Query/RelationProvider.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like