Issues in GroupByProvider.php (master) - Issues in master - rambler-digital-solutions/hydrogen - Measure and Improve Code Quality continuously with Scrutinizer

Issues (124)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Query/GroupByProvider.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This file is part of Hydrogen package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace RDS\Hydrogen\Query;

use RDS\Hydrogen\Criteria\HavingGroup;
use RDS\Hydrogen\Criteria\WhereGroup;
use RDS\Hydrogen\Criteria\GroupBy;
use RDS\Hydrogen\Criteria\Having;
use RDS\Hydrogen\Query;

/**
 * Trait GroupByProvider
 * @mixin Query
 */
trait GroupByProvider
{
    /**
     * @param string[] $fields
     * @return Query|$this|self
     */
    public function groupBy(string ...$fields): self
    {
        foreach ($fields as $field) {
            $this->add(new GroupBy($this, $field));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $this;
    }

    /**
     * @param string|\Closure $field
     * @param $valueOrOperator
     * @param null $value
     * @return Query|$this|self
     */
    public function orHaving($field, $valueOrOperator = null, $value = null): self
    {
        return $this->or->having($field, $valueOrOperator, $value);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @param string|\Closure $field
     * @param $valueOrOperator
     * @param null $value
     * @return Query|$this|self
     */
    public function having($field, $valueOrOperator = null, $value = null): self
    {
        if (\is_string($field)) {
            [$operator, $value] = Having::completeMissingParameters($valueOrOperator, $value);


            return $this->add(new Having($this, $field, $operator, $value, $this->mode()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        if ($field instanceof \Closure) {
            return $this->add(new HavingGroup($this, $field, $this->mode()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        $error = \vsprintf('Selection set should be a type of string or Closure, but %s given', [
            \studly_case(\gettype($field)),
        ]);

        throw new \InvalidArgumentException($error);
    }
}


1		<?php
2		/**
3		* This file is part of Hydrogen package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8		declare(strict_types=1);
9
10		namespace RDS\Hydrogen\Query;
11
12		use RDS\Hydrogen\Criteria\HavingGroup;
13		use RDS\Hydrogen\Criteria\WhereGroup;
14		use RDS\Hydrogen\Criteria\GroupBy;
15		use RDS\Hydrogen\Criteria\Having;
16		use RDS\Hydrogen\Query;
17
18		/**
19		* Trait GroupByProvider
20		* @mixin Query
21		*/
22		trait GroupByProvider
23		{
24		/**
25		* @param string[] $fields
26		* @return Query\|$this\|self
27		*/
28	2	public function groupBy(string ...$fields): self
29		{
30	2	foreach ($fields as $field) {
31	2	$this->add(new GroupBy($this, $field));
		0 ignored issues – show Documentation introduced 2018-09-05 02:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$field` is of type `array<integer,string>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug introduced 2018-09-05 02:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32		}
33
34	2	return $this;
35		}
36
37		/**
38		* @param string\|\Closure $field
39		* @param $valueOrOperator
40		* @param null $value
41		* @return Query\|$this\|self
42		*/
43		public function orHaving($field, $valueOrOperator = null, $value = null): self
44		{
45		return $this->or->having($field, $valueOrOperator, $value);
		0 ignored issues – show Bug introduced 2018-09-02 21:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `or` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
46		}
47
48		/**
49		* @param string\|\Closure $field
50		* @param $valueOrOperator
51		* @param null $value
52		* @return Query\|$this\|self
53		*/
54		public function having($field, $valueOrOperator = null, $value = null): self
55		{
56		if (\is_string($field)) {
57		[$operator, $value] = Having::completeMissingParameters($valueOrOperator, $value);
		0 ignored issues – show Bug introduced 2018-05-24 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$operator` does not exist. Did you mean `$valueOrOperator`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
58
59		return $this->add(new Having($this, $field, $operator, $value, $this->mode()));
		0 ignored issues – show Bug introduced 2018-05-24 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$operator` does not exist. Did you mean `$valueOrOperator`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history... Bug introduced 2018-09-02 21:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `mode()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-09-02 05:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
60		}
61
62		if ($field instanceof \Closure) {
63		return $this->add(new HavingGroup($this, $field, $this->mode()));
		0 ignored issues – show Bug introduced 2018-09-02 21:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `mode()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-09-02 05:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
64		}
65
66		$error = \vsprintf('Selection set should be a type of string or Closure, but %s given', [
67		\studly_case(\gettype($field)),
68		]);
69
70		throw new \InvalidArgumentException($error);
71		}
72		}
73

rambler-digital-solutions / hydrogen

Issues (124)

Security Analysis no request data

src/Query/GroupByProvider.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like