HavingBuilder - Code Metrics - Inspection of "Update readme" - rambler-digital-solutions/hydrogen - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 741bca...e69c57 )

by Kirill

created 2018-09-02 21:55 UTC

HavingBuilder A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	20
Duplicated Lines	60 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	3
dl	12
loc	20
c	0
b	0
f	0
ccs	0
cts	11
cp	0
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	apply()	12	12	2

How to fix Duplicated Code

<?php
/**
 * This file is part of Hydrogen package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace RDS\Hydrogen\Processor\DatabaseProcessor;

use Doctrine\ORM\QueryBuilder;
use RDS\Hydrogen\Criteria\CriterionInterface;
use RDS\Hydrogen\Criteria\Having;

/**
 * Class HavingBuilder
 */
class HavingBuilder extends WhereBuilder
{
    /**
     * @param QueryBuilder $builder
     * @param CriterionInterface|Having $having
     * @return \Generator
     */
    final public function apply($builder, CriterionInterface $having): \Generator

    {
        $expression = $this->getDoctrineExpression($having, $builder->expr(), $having->getField());


        yield from $this->extractResult($expression, function ($expr) use ($having, $builder) {
            if ($having->isAnd()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $builder->andHaving($expr);
            } else {
                $builder->orHaving($expr);
            }
        });
    }
}


1		<?php
2		/**
3		* This file is part of Hydrogen package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8		declare(strict_types=1);
9
10		namespace RDS\Hydrogen\Processor\DatabaseProcessor;
11
12		use Doctrine\ORM\QueryBuilder;
13		use RDS\Hydrogen\Criteria\CriterionInterface;
14		use RDS\Hydrogen\Criteria\Having;
15
16		/**
17		* Class HavingBuilder
18		*/
19		class HavingBuilder extends WhereBuilder
20		{
21		/**
22		* @param QueryBuilder $builder
23		* @param CriterionInterface\|Having $having
24		* @return \Generator
25		*/
26	View Code Duplication	final public function apply($builder, CriterionInterface $having): \Generator
		0 ignored issues – show Duplication introduced 2018-09-02 21:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		{
28		$expression = $this->getDoctrineExpression($having, $builder->expr(), $having->getField());
		0 ignored issues – show Compatibility introduced 2018-09-02 21:57 UTC by Report Bug Copy Issue Report `$having` of type `object<RDS\Hydrogen\Criteria\CriterionInterface>` is not a sub-type of `object<RDS\Hydrogen\Criteria\Where>`. It seems like you assume a concrete implementation of the interface `RDS\Hydrogen\Criteria\CriterionInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
29
30		yield from $this->extractResult($expression, function ($expr) use ($having, $builder) {
31		if ($having->isAnd()) {
		0 ignored issues – show Bug introduced 2018-09-02 21:57 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `RDS\Hydrogen\Criteria\CriterionInterface` as the method `isAnd()` does only exist in the following implementations of said interface: `RDS\Hydrogen\Criteria\Group`, `RDS\Hydrogen\Criteria\Having`, `RDS\Hydrogen\Criteria\Where`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
32		$builder->andHaving($expr);
33		} else {
34		$builder->orHaving($expr);
35		}
36		});
37		}
38		}
39

rambler-digital-solutions / hydrogen

Push — master ( 741bca...e69c57 )

HavingBuilder A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like