GroupBuilder::apply() - Code Metrics - Inspection of "Revert back .github issue template and remove lock..." - rambler-digital-solutions/hydrogen - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 69b436...e84470 )

by Kirill

created 2018-09-02 05:45 UTC

GroupBuilder::apply() A

↳ Parent: GroupBuilder

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	4.0058

Importance

Changes

Metric	Value
dl	0
loc	21
ccs	13
cts	14
cp	0.9286
rs	9.584
c	0
b	0
f	0
cc	4
nc	4
nop	2
crap	4.0058

<?php
/**
 * This file is part of Hydrogen package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace RDS\Hydrogen\Processor\DatabaseProcessor;

use Doctrine\ORM\QueryBuilder;
use RDS\Hydrogen\Criteria\CriterionInterface;
use RDS\Hydrogen\Criteria\Group;
use RDS\Hydrogen\Criteria\Where;

/**
 * Class GroupBuilder
 */
class GroupBuilder extends WhereBuilder
{
    /**
     * @param QueryBuilder $builder
     * @param CriterionInterface|Group $group
     * @return \Generator
     */
    public function apply($builder, CriterionInterface $group): \Generator
    {
        $inner = $group->getQuery();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $expr  = $builder->expr()->andX();

        foreach ($inner->getCriteria() as $where) {
            $expression = parent::getDoctrineExpression($where, $builder->expr(), $where->getField());
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

            yield from $this->extractResult($expression, function ($current) use ($expr, $where, $builder) {
                if ($where->isAnd()) {
                    $expr->add($current);
                } else {
                    $builder->orWhere($current);
                }
            });
        }

        $group->isAnd()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ? $builder->andWhere($expr)
            : $builder->orWhere($expr);
    }
}


Push — master ( 69b436...e84470 )

GroupBuilder::apply() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1		<?php
2		/**
3		* This file is part of Hydrogen package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8		declare(strict_types=1);
9
10		namespace RDS\Hydrogen\Processor\DatabaseProcessor;
11
12		use Doctrine\ORM\QueryBuilder;
13		use RDS\Hydrogen\Criteria\CriterionInterface;
14		use RDS\Hydrogen\Criteria\Group;
15		use RDS\Hydrogen\Criteria\Where;
16
17		/**
18		* Class GroupBuilder
19		*/
20		class GroupBuilder extends WhereBuilder
21		{
22		/**
23		* @param QueryBuilder $builder
24		* @param CriterionInterface\|Group $group
25		* @return \Generator
26		*/
27	2	public function apply($builder, CriterionInterface $group): \Generator
28		{
29	2	$inner = $group->getQuery();
		0 ignored issues – show Bug introduced 2018-05-24 14:00 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `RDS\Hydrogen\Criteria\CriterionInterface` as the method `getQuery()` does only exist in the following implementations of said interface: `RDS\Hydrogen\Criteria\Group`, `RDS\Hydrogen\Criteria\Relation`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
30	2	$expr = $builder->expr()->andX();
31
32	2	foreach ($inner->getCriteria() as $where) {
33	2	$expression = parent::getDoctrineExpression($where, $builder->expr(), $where->getField());
		0 ignored issues – show Comprehensibility Bug introduced 2018-05-24 14:00 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getDoctrineExpression()` instead of `apply()`). Are you sure this is correct? If so, you might want to change this to `$this->getDoctrineExpression()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
34
35	2	yield from $this->extractResult($expression, function ($current) use ($expr, $where, $builder) {
36	2	if ($where->isAnd()) {
37	2	$expr->add($current);
38		} else {
39	2	$builder->orWhere($current);
40		}
41	2	});
42		}
43
44	2	$group->isAnd()
		0 ignored issues – show Bug introduced 2018-09-02 05:50 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `RDS\Hydrogen\Criteria\CriterionInterface` as the method `isAnd()` does only exist in the following implementations of said interface: `RDS\Hydrogen\Criteria\Group`, `RDS\Hydrogen\Criteria\Where`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
45		? $builder->andWhere($expr)
46	2	: $builder->orWhere($expr);
47	2	}
48		}
49

rambler-digital-solutions / hydrogen

Push — master ( 69b436...e84470 )

GroupBuilder::apply() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like