GroupByProvider - Code Metrics - Inspection of "Revert back .github issue template and remove lock..." - rambler-digital-solutions/hydrogen - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 69b436...e84470 )

by Kirill

created 2018-09-02 05:45 UTC

GroupByProvider A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	15
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	1
dl	0
loc	15
ccs	4
cts	4
cp	1
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	groupBy()	0	8	2

<?php
/**
 * This file is part of Hydrogen package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace RDS\Hydrogen\Query;

use RDS\Hydrogen\Criteria\GroupBy;
use RDS\Hydrogen\Query;

/**
 * Trait GroupByProvider
 * @mixin Query
 */
trait GroupByProvider
{
    /**
     * @param string[] $fields
     * @return Query|$this|self
     */
    public function groupBy(string ...$fields): self
    {
        foreach ($fields as $field) {
            $this->add(new GroupBy($field));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $this;
    }
}


1		<?php
2		/**
3		* This file is part of Hydrogen package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8		declare(strict_types=1);
9
10		namespace RDS\Hydrogen\Query;
11
12		use RDS\Hydrogen\Criteria\GroupBy;
13		use RDS\Hydrogen\Query;
14
15		/**
16		* Trait GroupByProvider
17		* @mixin Query
18		*/
19		trait GroupByProvider
20		{
21		/**
22		* @param string[] $fields
23		* @return Query\|$this\|self
24		*/
25	2	public function groupBy(string ...$fields): self
26		{
27	2	foreach ($fields as $field) {
28	2	$this->add(new GroupBy($field));
		0 ignored issues – show Documentation introduced 2018-05-24 14:00 UTC by Report Bug Copy Issue Report `$field` is of type `array<integer,string>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug introduced 2018-09-02 05:50 UTC by Report Bug Copy Issue Report It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29		}
30
31	2	return $this;
32		}
33		}
34

rambler-digital-solutions / hydrogen

Push — master ( 69b436...e84470 )

GroupByProvider A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Duplication Side-by-Side

Filter issues like