WhereBetweenProvider::whereNotBetween() - Code Metrics - Inspection of "Completely refactoring" - rambler-digital-solutions/hydrogen - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( b17eba...69b436 )

by Kirill

created 2018-09-02 05:44 UTC

WhereBetweenProvider::whereNotBetween() A

↳ Parent: WhereBetweenProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	3
crap	1

<?php
/**
 * This file is part of Hydrogen package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace RDS\Hydrogen\Query\WhereProvider;

use RDS\Hydrogen\Criteria\Where\Operator;
use RDS\Hydrogen\Criteria\Where;
use RDS\Hydrogen\Query;

/**
 * Trait WhereBetweenProvider
 * @mixin Query\WhereProvider
 */
trait WhereBetweenProvider
{
    /**
     * @param string $field
     * @param mixed $from
     * @param mixed $to
     * @return Query|$this|self
     */
    public function orWhereBetween(string $field, $from, $to): self
    {
        return $this->or()->whereBetween($field, $from, $to);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param string $field
     * @param mixed $from
     * @param mixed $to
     * @return Query|$this|self
     */
    public function whereBetween(string $field, $from, $to): self
    {
        return $this->add(new Where($field, Operator::BTW, [$from, $to], $this->mode()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param string $field
     * @param mixed $from
     * @param mixed $to
     * @return Query|$this|self
     */
    public function orWhereNotBetween(string $field, $from, $to): self
    {
        return $this->or()->whereNotBetween($field, $from, $to);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param string $field
     * @param mixed $from
     * @param mixed $to
     * @return Query|$this|self
     */
    public function whereNotBetween(string $field, $from, $to): self
    {
        return $this->add(new Where($field, Operator::NOT_BTW, [$from, $to], $this->mode()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2		/**
3		* This file is part of Hydrogen package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8		declare(strict_types=1);
9
10		namespace RDS\Hydrogen\Query\WhereProvider;
11
12		use RDS\Hydrogen\Criteria\Where\Operator;
13		use RDS\Hydrogen\Criteria\Where;
14		use RDS\Hydrogen\Query;
15
16		/**
17		* Trait WhereBetweenProvider
18		* @mixin Query\WhereProvider
19		*/
20		trait WhereBetweenProvider
21		{
22		/**
23		* @param string $field
24		* @param mixed $from
25		* @param mixed $to
26		* @return Query\|$this\|self
27		*/
28	1	public function orWhereBetween(string $field, $from, $to): self
29		{
30	1	return $this->or()->whereBetween($field, $from, $to);
		0 ignored issues – show Bug introduced 2018-09-02 05:50 UTC by Report Bug Copy Issue Report It seems like `or()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31		}
32
33		/**
34		* @param string $field
35		* @param mixed $from
36		* @param mixed $to
37		* @return Query\|$this\|self
38		*/
39	2	public function whereBetween(string $field, $from, $to): self
40		{
41	2	return $this->add(new Where($field, Operator::BTW, [$from, $to], $this->mode()));
		0 ignored issues – show Bug introduced 2018-09-02 05:50 UTC by Report Bug Copy Issue Report It seems like `mode()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-09-02 05:50 UTC by Report Bug Copy Issue Report It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
42		}
43
44		/**
45		* @param string $field
46		* @param mixed $from
47		* @param mixed $to
48		* @return Query\|$this\|self
49		*/
50	1	public function orWhereNotBetween(string $field, $from, $to): self
51		{
52	1	return $this->or()->whereNotBetween($field, $from, $to);
		0 ignored issues – show Bug introduced 2018-09-02 05:50 UTC by Report Bug Copy Issue Report It seems like `or()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
53		}
54
55		/**
56		* @param string $field
57		* @param mixed $from
58		* @param mixed $to
59		* @return Query\|$this\|self
60		*/
61	2	public function whereNotBetween(string $field, $from, $to): self
62		{
63	2	return $this->add(new Where($field, Operator::NOT_BTW, [$from, $to], $this->mode()));
		0 ignored issues – show Bug introduced 2018-09-02 05:50 UTC by Report Bug Copy Issue Report It seems like `mode()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-09-02 05:50 UTC by Report Bug Copy Issue Report It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
64		}
65		}
66

rambler-digital-solutions / hydrogen

Push — master ( b17eba...69b436 )

WhereBetweenProvider::whereNotBetween() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like