RepositoryProvider::from() - Code Metrics - Inspection of "Completely refactoring" - rambler-digital-solutions/hydrogen - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( b17eba...69b436 )

by Kirill

created 2018-09-02 05:44 UTC

RepositoryProvider::from() A

↳ Parent: RepositoryProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php
/**
 * This file is part of Hydrogen package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace RDS\Hydrogen\Query;

use Doctrine\Common\Persistence\ObjectRepository;
use RDS\Hydrogen\Hydrogen;
use RDS\Hydrogen\Query;

/**
 * Trait RepositoryProvider
 * @mixin Query
 */
trait RepositoryProvider
{
    /**
     * @var ObjectRepository|Hydrogen
     */
    protected $repository;

    /**
     * @param ObjectRepository|Hydrogen $repository
     * @return Query|$this
     */
    public function from(ObjectRepository $repository): self
    {
        return $this->scope($this->repository = $repository);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @return ObjectRepository|Hydrogen
     * @throws \LogicException
     */
    public function getRepository(): ObjectRepository
    {
        if ($this->repository === null) {
            $error = 'Query should be attached to repository';
            throw new \LogicException($error);
        }

        return $this->repository;
    }
}


1			<?php
2			/**
3			* This file is part of Hydrogen package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace RDS\Hydrogen\Query;
11
12			use Doctrine\Common\Persistence\ObjectRepository;
13			use RDS\Hydrogen\Hydrogen;
14			use RDS\Hydrogen\Query;
15
16			/**
17			* Trait RepositoryProvider
18			* @mixin Query
19			*/
20			trait RepositoryProvider
21			{
22			/**
23			* @var ObjectRepository\|Hydrogen
24			*/
25			protected $repository;
26
27			/**
28			* @param ObjectRepository\|Hydrogen $repository
29			* @return Query\|$this
30			*/
31			public function from(ObjectRepository $repository): self
32			{
33			return $this->scope($this->repository = $repository);
			0 ignored issues – show Bug introduced 2018-09-02 05:50 UTC by Report Bug Copy Issue Report It seems like `scope()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34			}
35
36			/**
37			* @return ObjectRepository\|Hydrogen
38			* @throws \LogicException
39			*/
40			public function getRepository(): ObjectRepository
41			{
42			if ($this->repository === null) {
43			$error = 'Query should be attached to repository';
44			throw new \LogicException($error);
45			}
46
47			return $this->repository;
48			}
49			}
50

rambler-digital-solutions / hydrogen

Push — master ( b17eba...69b436 )

RepositoryProvider::from() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like