Hydrogen::__get() - Code Metrics - Inspection of "Completely refactoring" - rambler-digital-solutions/hydrogen - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( b17eba...69b436 )

by Kirill

created 2018-09-02 05:44 UTC

Hydrogen::__get() A

↳ Parent: Hydrogen

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	0
cts	8
cp	0
rs	9.9666
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	6

<?php
/**
 * This file is part of Hydrogen package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace RDS\Hydrogen;

use Doctrine\ORM\EntityRepository;
use RDS\Hydrogen\Processor\DatabaseProcessor;
use RDS\Hydrogen\Processor\ProcessorInterface;

/**
 * Trait Hydrogen
 * @property-read Query|$this $query
 */
trait Hydrogen
{
    /**
     * @var ProcessorInterface
     */
    private $processor;

    /**
     * @return ProcessorInterface
     */
    public function getProcessor(): ProcessorInterface
    {
        if ($this->processor === null) {
            $this->processor = new DatabaseProcessor($this, $this->getEntityManager());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        return $this->processor;
    }

    /**
     * @return Query|$this
     * @throws \LogicException
     */
    public function query(): Query
    {
        if (! $this instanceof EntityRepository) {
            $error = 'Could not use %s under non-repository class, but %s given';
            throw new \LogicException(\sprintf($error, Hydrogen::class, static::class));
        }

        return Query::new()->from($this);
    }

    /**
     * @param string $name
     * @return null|Query
     * @throws \LogicException
     */
    public function __get(string $name)
    {
        switch ($name) {
            case 'query':
                return $this->query();
        }

        return null;
    }
}


1			<?php
2			/**
3			* This file is part of Hydrogen package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace RDS\Hydrogen;
11
12			use Doctrine\ORM\EntityRepository;
13			use RDS\Hydrogen\Processor\DatabaseProcessor;
14			use RDS\Hydrogen\Processor\ProcessorInterface;
15
16			/**
17			* Trait Hydrogen
18			* @property-read Query\|$this $query
19			*/
20			trait Hydrogen
21			{
22			/**
23			* @var ProcessorInterface
24			*/
25			private $processor;
26
27			/**
28			* @return ProcessorInterface
29			*/
30			public function getProcessor(): ProcessorInterface
31			{
32			if ($this->processor === null) {
33			$this->processor = new DatabaseProcessor($this, $this->getEntityManager());
			0 ignored issues – show Bug introduced 2018-09-02 05:50 UTC by Report Bug Copy Issue Report It seems like `getEntityManager()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34			}
35
36			return $this->processor;
37			}
38
39			/**
40			* @return Query\|$this
41			* @throws \LogicException
42			*/
43			public function query(): Query
44			{
45			if (! $this instanceof EntityRepository) {
46			$error = 'Could not use %s under non-repository class, but %s given';
47			throw new \LogicException(\sprintf($error, Hydrogen::class, static::class));
48			}
49
50			return Query::new()->from($this);
51			}
52
53			/**
54			* @param string $name
55			* @return null\|Query
56			* @throws \LogicException
57			*/
58			public function __get(string $name)
59			{
60			switch ($name) {
61			case 'query':
62			return $this->query();
63			}
64
65			return null;
66			}
67			}
68

rambler-digital-solutions / hydrogen

Push — master ( b17eba...69b436 )

Hydrogen::__get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like