SelectProvider::select() - Code Metrics - Inspection of "Add raw functions support and improve builders" - rambler-digital-solutions/hydrogen - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b7ef6a...58a002 )

by Kirill

created 2018-09-05 02:03 UTC

SelectProvider::select() B

↳ Parent: SelectProvider

Complexity

Conditions	7
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	11.8162

Importance

Changes

Metric	Value
dl	0
loc	23
ccs	7
cts	13
cp	0.5385
rs	8.6186
c	0
b	0
f	0
cc	7
nc	4
nop	1
crap	11.8162

<?php
/**
 * This file is part of Hydrogen package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace RDS\Hydrogen\Query;

use RDS\Hydrogen\Criteria\Selection;
use RDS\Hydrogen\Query;

/**
 * Trait SelectProvider
 * @mixin Query
 */
trait SelectProvider
{
    /**
     * @param array|string ...$fields
     * @return Query|$this|self
     */
    public function select(...$fields): self
    {
        foreach ($fields as $field) {
            if (! \is_array($field) && ! \is_string($field)) {
                $error = 'Selection should be array (["field" => "alias"]) or string ("field") but %s given';
                throw new \InvalidArgumentException(\sprintf($error, \gettype($field)));
            }

            if (\is_string($field)) {
                $this->add(new Selection($this, $field));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                continue;
            }

            foreach ($field as $name => $alias) {
                if (\is_int($name)) {
                    [$name, $alias] = [$alias, null];
                }

                $this->add(new Selection($this, $name, $alias));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        }
        return $this;
    }

    /**
     * @param string|null $alias
     * @return Query
     */
    public function withEntity(string $alias = null): Query
    {
        return $this->select([':' . $this->getAlias() => $alias]);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2		/**
3		* This file is part of Hydrogen package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8		declare(strict_types=1);
9
10		namespace RDS\Hydrogen\Query;
11
12		use RDS\Hydrogen\Criteria\Selection;
13		use RDS\Hydrogen\Query;
14
15		/**
16		* Trait SelectProvider
17		* @mixin Query
18		*/
19		trait SelectProvider
20		{
21		/**
22		* @param array\|string ...$fields
23		* @return Query\|$this\|self
24		*/
25	30	public function select(...$fields): self
26		{
27	30	foreach ($fields as $field) {
28	30	if (! \is_array($field) && ! \is_string($field)) {
29		$error = 'Selection should be array (["field" => "alias"]) or string ("field") but %s given';
30		throw new \InvalidArgumentException(\sprintf($error, \gettype($field)));
31		}
32
33	30	if (\is_string($field)) {
34	30	$this->add(new Selection($this, $field));
		0 ignored issues – show Bug introduced 2018-09-05 02:06 UTC by Report Bug Copy Issue Report It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
35	30	continue;
36		}
37
38		foreach ($field as $name => $alias) {
39		if (\is_int($name)) {
40		[$name, $alias] = [$alias, null];
41		}
42
43		$this->add(new Selection($this, $name, $alias));
		0 ignored issues – show Bug introduced 2018-09-02 05:50 UTC by Report Bug Copy Issue Report It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
44		}
45		}
46	30	return $this;
47		}
48
49		/**
50		* @param string\|null $alias
51		* @return Query
52		*/
53		public function withEntity(string $alias = null): Query
54		{
55		return $this->select([':' . $this->getAlias() => $alias]);
		0 ignored issues – show Bug introduced 2018-09-05 02:06 UTC by Report Bug Copy Issue Report It seems like `getAlias()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
56		}
57		}
58

rambler-digital-solutions / hydrogen

Push — master ( b7ef6a...58a002 )

SelectProvider::select() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like