DeleteTrait::testDestroy() - Code Metrics - Inspection of "separado em Traits os metodos de CRUDService e CR..." - raivieira/base-api-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02af7a...be6bf8 )

by Rai

created 2017-01-27 11:01 UTC

DeleteTrait::testDestroy() A

↳ Parent: DeleteTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	11
nc	1
nop	0
dl	0
loc	17
rs	9.4285
c	0
b	0
f	0

<?php

namespace Bludata\Lumen\Traits\Tests\Http\Controllers;

trait DeleteTrait
{
	public function testDestroy()
    {
        $entity = $this->getServiceTest()->getRepositoryTest()->getFlushedMockObject();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $response = $this->curlHelper
class MyClass { }

$x = new MyClass();
$x->foo = true;
                         ->setPosFixUrl('/'.$entity->getId())
                         ->delete()
                         ->send()
                         ->getResponse();

        $this->assertEquals(200, $response['code']);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $data = json_decode($response['data'], true);

        $this->assertEquals($entity->getId(), $data['id']);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertEquals(true, strtotime($data['deletedAt']));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace Bludata\Lumen\Traits\Tests\Http\Controllers;
4
5			trait DeleteTrait
6			{
7			public function testDestroy()
8			{
9			$entity = $this->getServiceTest()->getRepositoryTest()->getFlushedMockObject();
			0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `getServiceTest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Coding Style introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 80 characters; contains 87 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
10
11			$response = $this->curlHelper
			0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report The property `curlHelper` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
12			->setPosFixUrl('/'.$entity->getId())
13			->delete()
14			->send()
15			->getResponse();
16
17			$this->assertEquals(200, $response['code']);
			0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `assertEquals()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
18
19			$data = json_decode($response['data'], true);
20
21			$this->assertEquals($entity->getId(), $data['id']);
			0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `assertEquals()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22			$this->assertEquals(true, strtotime($data['deletedAt']));
			0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `assertEquals()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23			}
24			}
25

raivieira / base-api-php

Push — master ( 02af7a...be6bf8 )

DeleteTrait::testDestroy() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like