UpdateTrait - Code Metrics - Inspection of "separado em Traits os metodos de CRUDService e CR..." - raivieira/base-api-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02af7a...be6bf8 )

by Rai

created 2017-01-27 11:01 UTC

UpdateTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	28
Duplicated Lines	25 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	7
loc	28
rs	10
c	0
b	0
f	0
wmc	3
lcom	0
cbo	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	testUpdate()	7	25	3

How to fix Duplicated Code

<?php

namespace Bludata\Lumen\Traits\Tests\Services;

trait UpdateTrait
{
	public function testUpdate()
    {
        $flushedMockArray = $this->getRepositoryTest()->getFlushedMockArray();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $mockArray = $this->getRepositoryTest()->getMockArray();
$a = "a";
$ab = "ab";
$abc = "abc";

        foreach ($this->getService()->getMainRepository()->createEntity()->getOnlyUpdate() as $key) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            if (is_bool($flushedMockArray[$key])) {
                $flushedMockArray[$key] = !$flushedMockArray[$key];
            } else {
                $flushedMockArray[$key] = $mockArray[$key];
            }
        }

        $entity = $this->getService()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                       ->update($flushedMockArray['id'], $flushedMockArray)
                       ->flush();

        $repository = $this->getService()->getMainRepository();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $find = $repository->find($entity->getId());

        $this->assertInstanceOf($repository->getEntityName(), $entity);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertInstanceOf('\DateTime', $entity->getUpdatedAt());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertEquals($entity->getId(), $find->getId());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace Bludata\Lumen\Traits\Tests\Services;
4
5		trait UpdateTrait
6		{
7		public function testUpdate()
8		{
9		$flushedMockArray = $this->getRepositoryTest()->getFlushedMockArray();
		0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `getRepositoryTest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
10		$mockArray = $this->getRepositoryTest()->getMockArray();
		0 ignored issues – show Coding Style introduced 2016-09-06 13:58 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `getRepositoryTest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
11
12	View Code Duplication	foreach ($this->getService()->getMainRepository()->createEntity()->getOnlyUpdate() as $key) {
		0 ignored issues – show Duplication introduced 2016-09-06 13:00 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2016-09-06 13:58 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 80 characters; contains 101 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history... Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `getService()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
13		if (is_bool($flushedMockArray[$key])) {
14		$flushedMockArray[$key] = !$flushedMockArray[$key];
15		} else {
16		$flushedMockArray[$key] = $mockArray[$key];
17		}
18		}
19
20		$entity = $this->getService()
		0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `getService()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21		->update($flushedMockArray['id'], $flushedMockArray)
22		->flush();
23
24		$repository = $this->getService()->getMainRepository();
		0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `getService()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25
26		$find = $repository->find($entity->getId());
27
28		$this->assertInstanceOf($repository->getEntityName(), $entity);
		0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `assertInstanceOf()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29		$this->assertInstanceOf('\DateTime', $entity->getUpdatedAt());
		0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `assertInstanceOf()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30		$this->assertEquals($entity->getId(), $find->getId());
		0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `assertEquals()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31		}
32		}
33

raivieira / base-api-php

Push — master ( 02af7a...be6bf8 )

UpdateTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like