DeleteTrait - Code Metrics - Inspection of "separado em Traits os metodos de CRUDService e CR..." - raivieira/base-api-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02af7a...be6bf8 )

by Rai

created 2017-01-27 11:01 UTC

DeleteTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	18
rs	10
c	0
b	0
f	0
wmc	1
lcom	0
cbo	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	testRemove()	0	12	1

<?php

namespace Bludata\Lumen\Traits\Tests\Services;

trait DeleteTrait
{
	/**
     * @expectedException Symfony\Component\HttpKernel\Exception\NotFoundHttpException

     */
    public function testRemove()
    {
        $entity = $this->getService()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                       ->store($this->getRepositoryTest()->getMockArray())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                       ->flush();

        $this->getService()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
             ->remove($entity->getId())
             ->flush();

        $find = $this->getService()->getMainRepository()->find($entity->getId());
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}


1			<?php
2
3			namespace Bludata\Lumen\Traits\Tests\Services;
4
5			trait DeleteTrait
6			{
7			/**
8			* @expectedException Symfony\Component\HttpKernel\Exception\NotFoundHttpException
			0 ignored issues – show Coding Style introduced 2016-09-06 13:58 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 80 characters; contains 86 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
9			*/
10			public function testRemove()
11			{
12			$entity = $this->getService()
			0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `getService()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
13			->store($this->getRepositoryTest()->getMockArray())
			0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `getRepositoryTest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
14			->flush();
15
16			$this->getService()
			0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `getService()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17			->remove($entity->getId())
18			->flush();
19
20			$find = $this->getService()->getMainRepository()->find($entity->getId());
			0 ignored issues – show Unused Code introduced 2016-09-06 13:00 UTC by Report Bug Copy Issue Report `$find` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history... Coding Style introduced 2016-09-06 13:58 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 80 characters; contains 81 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history... Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `getService()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21			}
22			}
23

raivieira / base-api-php

Push — master ( 02af7a...be6bf8 )

DeleteTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like