CreateTrait - Code Metrics - Inspection of "separado em Traits os metodos de CRUDService e CR..." - raivieira/base-api-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02af7a...be6bf8 )

by Rai

created 2017-01-27 11:01 UTC

CreateTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	18
Duplicated Lines	83.33 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
dl	15
loc	18
rs	10
c	0
b	0
f	0
wmc	1
lcom	1
cbo	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	testStore()	15	15	1

How to fix Duplicated Code

<?php

namespace Bludata\Lumen\Traits\Tests\Http\Controllers;

trait CreateTrait
{
	public function testStore()

    {
        $response = $this->curlHelper
class MyClass { }

$x = new MyClass();
$x->foo = true;
                         ->post(
                            $this->getServiceTest()->getRepositoryTest()->getMockArray()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                         )
                         ->send()
                         ->getResponse();

        $this->assertEquals(200, $response['code']);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $data = json_decode($response['data'], true);

        $this->assertGreaterThan(0, $data['id']);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace Bludata\Lumen\Traits\Tests\Http\Controllers;
4
5		trait CreateTrait
6		{
7	View Code Duplication	public function testStore()
		0 ignored issues – show Duplication introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
8		{
9		$response = $this->curlHelper
		0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report The property `curlHelper` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
10		->post(
11		$this->getServiceTest()->getRepositoryTest()->getMockArray()
		0 ignored issues – show Coding Style introduced 2016-09-06 13:58 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 80 characters; contains 88 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history... Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `getServiceTest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
12		)
13		->send()
14		->getResponse();
15
16		$this->assertEquals(200, $response['code']);
		0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `assertEquals()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17
18		$data = json_decode($response['data'], true);
19
20		$this->assertGreaterThan(0, $data['id']);
		0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `assertGreaterThan()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21		}
22		}
23

raivieira / base-api-php

Push — master ( 02af7a...be6bf8 )

CreateTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like