UpdateTrait - Code Metrics - Inspection of "separado em Traits os metodos de CRUDService e CR..." - raivieira/base-api-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02af7a...be6bf8 )

by Rai

created 2017-01-27 11:01 UTC

UpdateTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	22
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
dl	22
loc	22
rs	10
c	0
b	0
f	0
wmc	1
lcom	1
cbo	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	update()	17	17	1

How to fix Duplicated Code

<?php

namespace Bludata\Lumen\Traits\Http\Controllers;

use Illuminate\Http\Request;

trait UpdateTrait

{
    protected $optionsToArrayUpdate;

	public function update(Request $request, $id)

    {
        $entity = $this->mainService
class MyClass { }

$x = new MyClass();
$x->foo = true;
                       ->update(
                            $id,
                            $this->filterRequest(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                                $request->json()->all(),
                                $this->mainService
                                     ->getMainRepository()
                                     ->createEntity()
                                     ->getOnlyUpdate()
                            )
                       )
                       ->flush();

        return response()->json($entity->toArray($this->optionsToArrayUpdate));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1		<?php
2
3		namespace Bludata\Lumen\Traits\Http\Controllers;
4
5		use Illuminate\Http\Request;
6
7	View Code Duplication	trait UpdateTrait
		0 ignored issues – show Duplication introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
8		{
9		protected $optionsToArrayUpdate;
10
11		public function update(Request $request, $id)
		0 ignored issues – show Documentation introduced 2016-09-06 13:58 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
12		{
13		$entity = $this->mainService
		0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report The property `mainService` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
14		->update(
15		$id,
16		$this->filterRequest(
		0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `filterRequest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17		$request->json()->all(),
18		$this->mainService
19		->getMainRepository()
20		->createEntity()
21		->getOnlyUpdate()
22		)
23		)
24		->flush();
25
26		return response()->json($entity->toArray($this->optionsToArrayUpdate));
		0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Laravel\Lumen\Http\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
27		}
28		}
29

raivieira / base-api-php

Push — master ( 02af7a...be6bf8 )

UpdateTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like