DeleteTrait::testRemove() - Code Metrics - raivieira/base-api-php - Measure and Improve Code Quality continuously with Scrutinizer

DeleteTrait::testRemove() A
last analyzed 2017-02-13 13:33 UTC

↳ Parent: DeleteTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	7
nc	1
nop	0
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0

<?php

namespace Bludata\Lumen\Traits\Tests\Services;

trait DeleteTrait
{
    /**
     * @expectedException Symfony\Component\HttpKernel\Exception\NotFoundHttpException

     */
    public function testRemove()
    {
        $entity = $this->getRepositoryTest()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                       ->getFlushedMockObject();

        $this->getService()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
             ->remove($entity->getId())
             ->flush();

        $find = $this->getService()->getMainRepository()->find($entity->getId());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace Bludata\Lumen\Traits\Tests\Services;
4
5			trait DeleteTrait
6			{
7			/**
8			* @expectedException Symfony\Component\HttpKernel\Exception\NotFoundHttpException
			0 ignored issues – show Coding Style introduced 2016-09-06 13:58 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 80 characters; contains 86 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
9			*/
10			public function testRemove()
11			{
12			$entity = $this->getRepositoryTest()
			0 ignored issues – show Bug introduced 2017-02-13 13:32 UTC by Report Bug Copy Issue Report It seems like `getRepositoryTest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
13			->getFlushedMockObject();
14
15			$this->getService()
			0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `getService()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
16			->remove($entity->getId())
17			->flush();
18
19			$find = $this->getService()->getMainRepository()->find($entity->getId());
			0 ignored issues – show Bug introduced 2017-01-27 11:13 UTC by Report Bug Copy Issue Report It seems like `getService()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Unused Code introduced 2016-09-06 13:00 UTC by Report Bug Copy Issue Report `$find` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history... Coding Style introduced 2016-09-06 13:58 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 80 characters; contains 81 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
20			}
21			}
22

raivieira / base-api-php

DeleteTrait::testRemove() A last analyzed 2017-02-13 13:33 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DeleteTrait::testRemove() A
last analyzed 2017-02-13 13:33 UTC