Generator::generate() - Code Metrics - Inspection of "Add ir validation" - railt/sdl - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( a0eed4...bb00ac )

by Kirill

created 2018-09-11 23:49 UTC

Generator::generate() A

↳ Parent: Generator

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	2
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\SDL\Backend;

use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerAwareTrait;
use Railt\Io\Readable;
use Railt\Reflection\Document;
use Railt\Reflection\Contracts\Reflection;

/**
 * Class Generator
 */
class Generator implements LoggerAwareInterface
{
    use LoggerAwareTrait;

    /**
     * @var Reflection
     */
    private $reflection;

    /**
     * Generator constructor.
     * @param Reflection $reflection
     */
    public function __construct(Reflection $reflection)
    {
        $this->reflection = $reflection;
    }

    /**
     * @param Readable $file
     * @param iterable $ir
     * @return Document
     */
    public function generate(Readable $file, iterable $ir): Document
    {
        foreach ($ir as $documents) {
            ///
        }

        $document = new Document($this->reflection, $file);


        return $document;
    }
}


1			<?php
2			/**
3			* This file is part of Railt package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Railt\SDL\Backend;
11
12			use Psr\Log\LoggerAwareInterface;
13			use Psr\Log\LoggerAwareTrait;
14			use Railt\Io\Readable;
15			use Railt\Reflection\Document;
16			use Railt\Reflection\Contracts\Reflection;
17
18			/**
19			* Class Generator
20			*/
21			class Generator implements LoggerAwareInterface
22			{
23			use LoggerAwareTrait;
24
25			/**
26			* @var Reflection
27			*/
28			private $reflection;
29
30			/**
31			* Generator constructor.
32			* @param Reflection $reflection
33			*/
34			public function __construct(Reflection $reflection)
35			{
36			$this->reflection = $reflection;
37			}
38
39			/**
40			* @param Readable $file
41			* @param iterable $ir
42			* @return Document
43			*/
44			public function generate(Readable $file, iterable $ir): Document
45			{
46			foreach ($ir as $documents) {
47			///
48			}
49
50			$document = new Document($this->reflection, $file);
			0 ignored issues – show Compatibility introduced 2018-08-01 16:41 UTC by Report Bug Copy Issue Report `$this->reflection` of type `object<Railt\Reflection\Contracts\Reflection>` is not a sub-type of `object<Railt\Reflection\Reflection>`. It seems like you assume a concrete implementation of the interface `Railt\Reflection\Contracts\Reflection` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
51
52			return $document;
53			}
54			}
55

railt / sdl

Push — master ( a0eed4...bb00ac )

Generator::generate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like