Context::create() - Code Metrics - Inspection of "Basic frontend logic impl" - railt/sdl - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 2d53c5...8b1ae1 )

by Kirill

created 2018-08-24 00:21 UTC

Context::create() A

↳ Parent: Context

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	6
rs	10
c	0
b	0
f	0

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\SDL\Frontend;

use Railt\SDL\Frontend\IR\JoinableOpcode;

/**
 * Class Context
 */
class Context
{
    /**
     * @var JoinableOpcode[]
     */
    private $stack;

    /**
     * @var bool
     */
    private $await = false;

    /**
     * Context constructor.
     */
    public function __construct()
    {
        $this->stack = new \SplStack();

    }

    /**
     * @return null|JoinableOpcode
     */
    public function current(): ?JoinableOpcode
    {
        return $this->stack->count() ? $this->stack->top() : null;

    }

    /**
     * @param \Closure $then
     * @return \Generator
     */
    public function transaction(\Closure $then): \Generator
    {
        $current = $this->current();

        $result = $then($current);

        if ($current !== $this->current()) {
            $this->close();
        }

        return $result;
    }

    /**
     * @return null|JoinableOpcode
     */
    public function create(): ?JoinableOpcode
    {
        $this->await = true;

        return $this->current();
    }

    /**
     * @return null|JoinableOpcode
     */
    public function close(): ?JoinableOpcode
    {
        $this->await = false;

        return $this->stack->pop();

    }

    /**
     * @param JoinableOpcode $opcode
     * @return JoinableOpcode
     */
    public function match(JoinableOpcode $opcode): JoinableOpcode
    {
        if ($this->await) {
            $this->stack->push($opcode);

            $this->await = false;
        }

        return $opcode;
    }
}


1			<?php
2			/**
3			* This file is part of Railt package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Railt\SDL\Frontend;
11
12			use Railt\SDL\Frontend\IR\JoinableOpcode;
13
14			/**
15			* Class Context
16			*/
17			class Context
18			{
19			/**
20			* @var JoinableOpcode[]
21			*/
22			private $stack;
23
24			/**
25			* @var bool
26			*/
27			private $await = false;
28
29			/**
30			* Context constructor.
31			*/
32			public function __construct()
33			{
34			$this->stack = new \SplStack();
			0 ignored issues – show Documentation Bug introduced 2018-08-24 00:23 UTC by Report Bug Copy Issue Report It seems like `new \SplStack()` of type `object<SplStack>` is incompatible with the declared type `array<integer,object<Rai...end\IR\JoinableOpcode>>` of property `$stack`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
35			}
36
37			/**
38			* @return null\|JoinableOpcode
39			*/
40			public function current(): ?JoinableOpcode
41			{
42			return $this->stack->count() ? $this->stack->top() : null;
			0 ignored issues – show Bug introduced 2018-08-24 00:23 UTC by Report Bug Copy Issue Report The method `count` cannot be called on `$this->stack` (of type `array<integer,object<Rai...end\IR\JoinableOpcode>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history... Bug introduced 2018-08-24 00:23 UTC by Report Bug Copy Issue Report The method `top` cannot be called on `$this->stack` (of type `array<integer,object<Rai...end\IR\JoinableOpcode>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
43			}
44
45			/**
46			* @param \Closure $then
47			* @return \Generator
48			*/
49			public function transaction(\Closure $then): \Generator
50			{
51			$current = $this->current();
52
53			$result = $then($current);
54
55			if ($current !== $this->current()) {
56			$this->close();
57			}
58
59			return $result;
60			}
61
62			/**
63			* @return null\|JoinableOpcode
64			*/
65			public function create(): ?JoinableOpcode
66			{
67			$this->await = true;
68
69			return $this->current();
70			}
71
72			/**
73			* @return null\|JoinableOpcode
74			*/
75			public function close(): ?JoinableOpcode
76			{
77			$this->await = false;
78
79			return $this->stack->pop();
			0 ignored issues – show Bug introduced 2018-08-24 00:23 UTC by Report Bug Copy Issue Report The method `pop` cannot be called on `$this->stack` (of type `array<integer,object<Rai...end\IR\JoinableOpcode>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
80			}
81
82			/**
83			* @param JoinableOpcode $opcode
84			* @return JoinableOpcode
85			*/
86			public function match(JoinableOpcode $opcode): JoinableOpcode
87			{
88			if ($this->await) {
89			$this->stack->push($opcode);
			0 ignored issues – show Bug introduced 2018-08-24 00:23 UTC by Report Bug Copy Issue Report The method `push` cannot be called on `$this->stack` (of type `array<integer,object<Rai...end\IR\JoinableOpcode>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
90			$this->await = false;
91			}
92
93			return $opcode;
94			}
95			}
96

railt / sdl

Push — master ( 2d53c5...8b1ae1 )

Context::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like