Railt\SDL\Frontend\Ast\Definition\Provider\ProvidesTypeHint

Complexity

Total Complexity

5

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getTypeHint()	0	4	1
A	getHintModifiers()	0	8	2
A	getHintTypeName()	0	10	2

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\SDL\Frontend\Ast\Definition\Provider;

use Railt\SDL\Frontend\Ast\Definition\Common\TypeHintNode;

/**
 * Trait ProvidesTypeHint
 */
trait ProvidesTypeHint
{
    /**
     * @return null|TypeHintNode
     */
    private function getTypeHint(): ?TypeHintNode
    {
        return $this->first('TypeHint', 1);

It seems like first() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @return int
     */
    public function getHintModifiers(): int
    {
        if ($hint = $this->getTypeHint()) {
            return $hint->getModifiers();
        }

        return 0;
    }

    /**
     * @return null|string
     */
    public function getHintTypeName(): ?string
    {
        if ($hint = $this->getTypeHint()) {
            return $hint->first('TypeName', 6)

It seems like you code against a concrete implementation and not the interface Railt\Parser\Ast\NodeInterface as the method getChild() does only exist in the following implementations of said interface: Railt\Compiler\Grammar\Delegate\IncludeDelegate, Railt\Compiler\Grammar\Delegate\RuleDelegate, Railt\Compiler\Grammar\Delegate\TokenDelegate, Railt\Parser\Ast\Rule, Railt\SDL\Frontend\Ast\Definition\ArgumentDefinitionNode, Railt\SDL\Frontend\Ast\Definition\Common\TypeHintNode, Railt\SDL\Frontend\Ast\Definition\DirectiveDefinitionNode, Railt\SDL\Frontend\Ast\Definition\EnumDefinitionNode, Railt\SDL\Frontend\Ast\Definition\EnumValueDefinitionNode, Railt\SDL\Frontend\Ast\Definition\FieldDefinitionNode, Railt\SDL\Frontend\Ast\Definition\InputDefinitionNode, Railt\SDL\Frontend\Ast\Definition\InputFieldDefinitionNode, Railt\SDL\Frontend\Ast\Definition\InterfaceDefinitionNode, Railt\SDL\Frontend\Ast\Definition\ObjectDefinitionNode, Railt\SDL\Frontend\Ast\Definition\ScalarDefinitionNode, Railt\SDL\Frontend\Ast\Definition\SchemaDefinitionNode, Railt\SDL\Frontend\Ast\Definition\SchemaFieldDefinitionNode, Railt\SDL\Frontend\Ast\Definition\TypeDefinitionNode, Railt\SDL\Frontend\Ast\Definition\UnionDefinitionNode, Railt\SDL\Frontend\Ast\Invocation\BooleanValue, Railt\SDL\Frontend\Ast\Invocation\ConstantValue, Railt\SDL\Frontend\Ast\Invocation\DescriptionValue, Railt\SDL\Frontend\Ast\Invocation\ListValue, Railt\SDL\Frontend\Ast\Invocation\NullValue, Railt\SDL\Frontend\Ast\Invocation\NumberValue, Railt\SDL\Frontend\Ast\Invocation\StringValue, Railt\SDL\Frontend\Ast\Invocation\Value.

                ->getChild(0)
                ->getValue();
        }

        return null;
    }
}