Railt\SDL\Reflection\Validation\Base\BaseValidator

Complexity

Total Complexity

6

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	2

Test Coverage

Coverage

68.75%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getGroupName()	0	4	1
A	getValidator()	0	4	1
A	getCallStack()	0	4	1
A	throw()	0	10	2

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\SDL\Reflection\Validation\Base;

use Railt\SDL\Exceptions\SchemaException;
use Railt\SDL\Reflection\Validation\Validator;
use Railt\SDL\Runtime\CallStack;
use Railt\SDL\Runtime\CallStackInterface;
use Railt\SDL\Support;

/**
 * Class BaseValidator
 */
abstract class BaseValidator implements ValidatorInterface
{
    use Support;

    /**
     * @var Validator
     */
    protected $validator;

    /**
     * @var CallStack
     */
    private $stack;

    /**
     * @var string
     */
    private $name;

    /**
     * BaseValidator constructor.
     * @param Validator $factory
     * @param CallStackInterface $stack
     * @param null|string $name
     */
    public function __construct(Validator $factory, CallStackInterface $stack, ?string $name)
    {
        $this->validator = $factory;
        $this->stack     = $stack;

$stack is of type object<Railt\SDL\Runtime\CallStackInterface>, but the property $stack was declared to be of type object<Railt\SDL\Runtime\CallStack>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->name      = $name ?? static::class;
    }

    /**
     * @return string
     */
    public function getGroupName(): string
    {
        return $this->name;
    }

    /**
     * @param string $group
     * @return ValidatorInterface
     * @throws \OutOfBoundsException
     */
    public function getValidator(string $group): ValidatorInterface
    {
        return $this->validator->group($group);
    }

    /**
     * @return CallStack|CallStackInterface
     */
    public function getCallStack(): CallStackInterface
    {
        return $this->stack;
    }

    /**
     * @param string $exception
     * @param string $message
     * @param array ...$args
     * @return void
     */
    public function throw(string $exception, string $message, ...$args): void
    {
        $message = \sprintf($message, ...$args);

        if (\is_subclass_of($exception, SchemaException::class)) {

Due to PHP Bug #53727, is_subclass_of might return inconsistent results on some PHP versions if \Railt\SDL\Exceptions\SchemaException::class can be an interface. If so, you could instead use ReflectionClass::implementsInterface.

            throw new $exception($message, $this->stack);
        }

        throw new $exception($message);
    }
}