Renderer::scalar() - Code Metrics - Inspection of "Improve opcode emitting logic and add deferred inv..." - railt/sdl - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( e081e8...a6938b )

by Kirill

created 2018-08-28 00:15 UTC

Renderer::scalar() A

↳ Parent: Renderer

Complexity

Conditions	5
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
nc	5
nop	1
dl	0
loc	17
rs	9.3888
c	0
b	0
f	0

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\SDL;

use Railt\Io\Readable;
use Railt\Parser\Ast\NodeInterface;
use Railt\SDL\Frontend\IR\OpcodeInterface;
use Railt\SDL\Frontend\IR\Value\ValueInterface;

/**
 * Class Renderer
 */
class Renderer
{
    /**
     * @param mixed $value
     * @return string
     */
    public static function render($value): string
    {
        switch (true) {
            case $value instanceof NodeInterface:
                return self::node($value);

            case $value instanceof OpcodeInterface:
                return self::opcode($value);

            case $value instanceof ValueInterface:
                return self::value($value);

            case $value instanceof Readable:
                return self::file($value);

            case \is_scalar($value):
                return self::scalar($value);

            case \is_iterable($value):
                return self::iterable($value);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            case \is_object($value):
                return self::object($value);
        }

        return \gettype($value);
    }

    /**
     * @param NodeInterface $ast
     * @return string
     */
    private static function node(NodeInterface $ast): string
    {
        return '<' . $ast->getName() . '>';
    }

    /**
     * @param OpcodeInterface $opcode
     * @return string
     */
    private static function opcode(OpcodeInterface $opcode): string
    {
        return '#' . $opcode->getId() . ' ' . $opcode->getName();
    }

    /**
     * @param ValueInterface $value
     * @return string
     */
    private static function value(ValueInterface $value): string
    {
        return (string)$value;
    }

    /**
     * @param mixed $value
     * @return string
     */
    private static function scalar($value): string
    {
        switch (true) {
            case $value === null:
                return 'null';

            case \is_bool($value):
                return $value ? 'true' : 'false';

            case \is_string($value):
                $minified = \preg_replace('/\s+/', ' ', (string)$value);
                return '"' . \addcslashes($minified, '"') . '"';

            default:
                return (string)$value;
        }
    }

    /**
     * @param iterable $values
     * @return string
     */
    private static function iterable(iterable $values): string
    {
        $arguments = [];

        foreach ($values as $value) {
            $arguments[] = self::render($value);
        }

        $name = \is_array($values) ? 'array' : \get_class($values);

        return \sprintf('%s(%s)', $name, \implode(', ', $arguments));
    }

    /**
     * @param mixed $value
     * @return string
     */
    private static function object($value): string
    {
        return \get_class($value) . '#' . \spl_object_hash($value);
    }

    /**
     * @param Readable $readable
     * @return string
     */
    private static function file(Readable $readable): string
    {
        return '(file)' . $readable->getPathname();
    }
}


1			<?php
2			/**
3			* This file is part of Railt package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Railt\SDL;
11
12			use Railt\Io\Readable;
13			use Railt\Parser\Ast\NodeInterface;
14			use Railt\SDL\Frontend\IR\OpcodeInterface;
15			use Railt\SDL\Frontend\IR\Value\ValueInterface;
16
17			/**
18			* Class Renderer
19			*/
20			class Renderer
21			{
22			/**
23			* @param mixed $value
24			* @return string
25			*/
26			public static function render($value): string
27			{
28			switch (true) {
29			case $value instanceof NodeInterface:
30			return self::node($value);
31
32			case $value instanceof OpcodeInterface:
33			return self::opcode($value);
34
35			case $value instanceof ValueInterface:
36			return self::value($value);
37
38			case $value instanceof Readable:
39			return self::file($value);
40
41			case \is_scalar($value):
42			return self::scalar($value);
43
44			case \is_iterable($value):
45			return self::iterable($value);
			0 ignored issues – show Documentation introduced 2018-08-28 00:18 UTC by Report Bug Copy Issue Report `$value` is of type `object\|array\|null`, but the function expects a `object<Railt\SDL\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
46
47			case \is_object($value):
48			return self::object($value);
49			}
50
51			return \gettype($value);
52			}
53
54			/**
55			* @param NodeInterface $ast
56			* @return string
57			*/
58			private static function node(NodeInterface $ast): string
59			{
60			return '<' . $ast->getName() . '>';
61			}
62
63			/**
64			* @param OpcodeInterface $opcode
65			* @return string
66			*/
67			private static function opcode(OpcodeInterface $opcode): string
68			{
69			return '#' . $opcode->getId() . ' ' . $opcode->getName();
70			}
71
72			/**
73			* @param ValueInterface $value
74			* @return string
75			*/
76			private static function value(ValueInterface $value): string
77			{
78			return (string)$value;
79			}
80
81			/**
82			* @param mixed $value
83			* @return string
84			*/
85			private static function scalar($value): string
86			{
87			switch (true) {
88			case $value === null:
89			return 'null';
90
91			case \is_bool($value):
92			return $value ? 'true' : 'false';
93
94			case \is_string($value):
95			$minified = \preg_replace('/\s+/', ' ', (string)$value);
96			return '"' . \addcslashes($minified, '"') . '"';
97
98			default:
99			return (string)$value;
100			}
101			}
102
103			/**
104			* @param iterable $values
105			* @return string
106			*/
107			private static function iterable(iterable $values): string
108			{
109			$arguments = [];
110
111			foreach ($values as $value) {
112			$arguments[] = self::render($value);
113			}
114
115			$name = \is_array($values) ? 'array' : \get_class($values);
116
117			return \sprintf('%s(%s)', $name, \implode(', ', $arguments));
118			}
119
120			/**
121			* @param mixed $value
122			* @return string
123			*/
124			private static function object($value): string
125			{
126			return \get_class($value) . '#' . \spl_object_hash($value);
127			}
128
129			/**
130			* @param Readable $readable
131			* @return string
132			*/
133			private static function file(Readable $readable): string
134			{
135			return '(file)' . $readable->getPathname();
136			}
137			}
138

railt / sdl

Push — master ( e081e8...a6938b )

Renderer::scalar() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like