TypeHintNode - Code Metrics - Inspection of "Improve building logic and AST" - railt/sdl - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c1a156...8cadde )

by Kirill

created 2018-08-20 02:33 UTC

TypeHintNode A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	86
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

46.15%

Importance

Changes

Metric	Value
dl	0
loc	86
ccs	12
cts	26
cp	0.4615
rs	10
c	0
b	0
f	0
wmc	12
lcom	1
cbo	3

7 Methods

Rating	Name	Size	Complexity
A	__construct()	16	5
A	analyze()	9	2
A	isList()	4	1
A	isNonNull()	4	1
A	isListOfNonNulls()	4	1
A	getModifiers()	4	1
A	getTypeNameNode()	4	1

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\SDL\Ast\Common;

use Railt\Parser\Ast\NodeInterface;
use Railt\Parser\Ast\Rule;
use Railt\Parser\Ast\RuleInterface;
use Railt\Reflection\Contracts\Definition\Behaviour\ProvidesTypeIndication as Hint;
use Railt\SDL\Ast\ProvidesName;
use Railt\SDL\Ast\Support\TypeNameProvider;

/**
 * Class TypeHintNode
 */
class TypeHintNode extends Rule implements ProvidesName
{
    use TypeNameProvider;

    /**
     * @var int
     */
    private $modifiers = 0;

    /**
     * TypeHintNode constructor.
     * @param string $name
     * @param array $children
     * @param int $offset
     */
    public function __construct(string $name, array $children = [], int $offset = 0)
    {
        parent::__construct($name, $children, $offset);

        foreach ($this->analyze($this->getChild(0)) as $child) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            switch ($child) {
                case 'List':
                    $this->modifiers |= Hint::IS_LIST;
                    break;

                case 'NonNull':
                    $this->modifiers |= $this->isList() ? Hint::IS_LIST_OF_NOT_NULL : Hint::IS_NOT_NULL;
                    break;
            }
        }
    }

    /**
     * @param RuleInterface|NodeInterface $rule
     * @return \Generator
     */
    private function analyze(RuleInterface $rule): \Generator
    {
        $name = $rule->getName();

        if ($name !== 'TypeName') {
            yield $name;
            yield from $this->analyze($rule->getChild(0));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }

    /**
     * @return bool
     */
    public function isList(): bool
    {
        return (bool)($this->modifiers & Hint::IS_LIST);
    }

    /**
     * @return bool
     */
    public function isNonNull(): bool
    {
        return (bool)($this->modifiers & Hint::IS_NOT_NULL);
    }

    /**
     * @return bool
     */
    public function isListOfNonNulls(): bool
    {
        return (bool)($this->modifiers & Hint::IS_LIST_OF_NOT_NULL);
    }

    /**
     * @return int
     */
    public function getModifiers(): int
    {
        return $this->modifiers;
    }

    /**
     * @return null|TypeNameNode|NodeInterface
     */
    protected function getTypeNameNode(): ?TypeNameNode
    {
        return $this->first('TypeName', 3);
    }
}


1		<?php
2		/**
3		* This file is part of Railt package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8		declare(strict_types=1);
9
10		namespace Railt\SDL\Ast\Common;
11
12		use Railt\Parser\Ast\NodeInterface;
13		use Railt\Parser\Ast\Rule;
14		use Railt\Parser\Ast\RuleInterface;
15		use Railt\Reflection\Contracts\Definition\Behaviour\ProvidesTypeIndication as Hint;
16		use Railt\SDL\Ast\ProvidesName;
17		use Railt\SDL\Ast\Support\TypeNameProvider;
18
19		/**
20		* Class TypeHintNode
21		*/
22		class TypeHintNode extends Rule implements ProvidesName
23		{
24		use TypeNameProvider;
25
26		/**
27		* @var int
28		*/
29		private $modifiers = 0;
30
31		/**
32		* TypeHintNode constructor.
33		* @param string $name
34		* @param array $children
35		* @param int $offset
36		*/
37	11	public function __construct(string $name, array $children = [], int $offset = 0)
38		{
39	11	parent::__construct($name, $children, $offset);
40
41	11	foreach ($this->analyze($this->getChild(0)) as $child) {
		0 ignored issues – show Documentation introduced 2018-08-20 02:41 UTC by Report Bug Copy Issue Report `$this->getChild(0)` is of type `null\|object<Railt\Parser\Ast\NodeInterface>`, but the function expects a `object<Railt\Parser\Ast\RuleInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42		switch ($child) {
43		case 'List':
44		$this->modifiers \|= Hint::IS_LIST;
45		break;
46
47		case 'NonNull':
48		$this->modifiers \|= $this->isList() ? Hint::IS_LIST_OF_NOT_NULL : Hint::IS_NOT_NULL;
49		break;
50		}
51		}
52	11	}
53
54		/**
55		* @param RuleInterface\|NodeInterface $rule
56		* @return \Generator
57		*/
58	11	private function analyze(RuleInterface $rule): \Generator
59		{
60	11	$name = $rule->getName();
61
62	11	if ($name !== 'TypeName') {
63		yield $name;
64		yield from $this->analyze($rule->getChild(0));
		0 ignored issues – show Documentation introduced 2018-08-20 02:41 UTC by Report Bug Copy Issue Report `$rule->getChild(0)` is of type `null\|object<Railt\Parser\Ast\NodeInterface>`, but the function expects a `object<Railt\Parser\Ast\RuleInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
65		}
66	11	}
67
68		/**
69		* @return bool
70		*/
71		public function isList(): bool
72		{
73		return (bool)($this->modifiers & Hint::IS_LIST);
74		}
75
76		/**
77		* @return bool
78		*/
79		public function isNonNull(): bool
80		{
81		return (bool)($this->modifiers & Hint::IS_NOT_NULL);
82		}
83
84		/**
85		* @return bool
86		*/
87		public function isListOfNonNulls(): bool
88		{
89		return (bool)($this->modifiers & Hint::IS_LIST_OF_NOT_NULL);
90		}
91
92		/**
93		* @return int
94		*/
95	6	public function getModifiers(): int
96		{
97	6	return $this->modifiers;
98		}
99
100		/**
101		* @return null\|TypeNameNode\|NodeInterface
102		*/
103	6	protected function getTypeNameNode(): ?TypeNameNode
104		{
105	6	return $this->first('TypeName', 3);
106		}
107		}
108

railt / sdl

Push — master ( c1a156...8cadde )

TypeHintNode A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like