InputInvocationNode::getInnerValues() - Code Metrics - Inspection of "Add more opcodes support and implement basic vm" - railt/sdl - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( ecd78b...d05c81 )

by Kirill

created 2018-08-25 04:51 UTC

InputInvocationNode::getInnerValues() A

↳ Parent: InputInvocationNode

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
nc	3
nop	0
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\SDL\Frontend\AST\Invocation;

use Railt\Parser\Ast\Rule;
use Railt\Parser\Ast\RuleInterface;
use Railt\Reflection\Contracts\TypeInterface;
use Railt\Reflection\Type;
use Railt\SDL\Frontend\AST\ProvidesType;
use Railt\SDL\Frontend\IR\Value\InputValue;
use Railt\SDL\Frontend\IR\Value\StringValue;
use Railt\SDL\Frontend\IR\Value\ValueInterface;

/**
 * Class InputInvocationNode
 */
class InputInvocationNode extends Rule implements ProvidesType, AstValueInterface
{
    /**
     * @return TypeInterface
     */
    public function getType(): TypeInterface
    {
        return Type::of(Type::INPUT_OBJECT);
    }

    /**
     * @return ValueInterface
     */
    public function unpack(): ValueInterface
    {
        return new InputValue($this->getInnerValues(), $this->getOffset());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @return iterable|ValueInterface[]
     */
    private function getInnerValues(): iterable
    {
        /** @var RuleInterface $arguments */
        $arguments = $this->first('InputInvocationArguments', 1);

        if ($arguments) {
            /** @var ArgumentInvocationNode $child */
            foreach ($arguments as $child) {
                yield $child->getKey() => $child->getValue();
            }
        }
    }
}


1			<?php
2			/**
3			* This file is part of Railt package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Railt\SDL\Frontend\AST\Invocation;
11
12			use Railt\Parser\Ast\Rule;
13			use Railt\Parser\Ast\RuleInterface;
14			use Railt\Reflection\Contracts\TypeInterface;
15			use Railt\Reflection\Type;
16			use Railt\SDL\Frontend\AST\ProvidesType;
17			use Railt\SDL\Frontend\IR\Value\InputValue;
18			use Railt\SDL\Frontend\IR\Value\StringValue;
19			use Railt\SDL\Frontend\IR\Value\ValueInterface;
20
21			/**
22			* Class InputInvocationNode
23			*/
24			class InputInvocationNode extends Rule implements ProvidesType, AstValueInterface
25			{
26			/**
27			* @return TypeInterface
28			*/
29			public function getType(): TypeInterface
30			{
31			return Type::of(Type::INPUT_OBJECT);
32			}
33
34			/**
35			* @return ValueInterface
36			*/
37			public function unpack(): ValueInterface
38			{
39			return new InputValue($this->getInnerValues(), $this->getOffset());
			0 ignored issues – show Documentation introduced 2018-08-25 04:54 UTC by Report Bug Copy Issue Report `$this->getInnerValues()` is of type `object<Generator>`, but the function expects a `object<Railt\SDL\Frontend\IR\Value\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
40			}
41
42			/**
43			* @return iterable\|ValueInterface[]
44			*/
45			private function getInnerValues(): iterable
46			{
47			/** @var RuleInterface $arguments */
48			$arguments = $this->first('InputInvocationArguments', 1);
49
50			if ($arguments) {
51			/** @var ArgumentInvocationNode $child */
52			foreach ($arguments as $child) {
53			yield $child->getKey() => $child->getValue();
54			}
55			}
56			}
57			}
58

railt / sdl

Push — master ( ecd78b...d05c81 )

InputInvocationNode::getInnerValues() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like