SchemaDefinitionBuilder::deferred() - Code Metrics - Inspection of "Improve builder logic" - railt/sdl - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b2a65d...63a169 )

by Kirill

created 2018-10-11 00:58 UTC

SchemaDefinitionBuilder::deferred() A

↳ Parent: SchemaDefinitionBuilder

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	2
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\SDL\Frontend\Builder\Definition;

use Railt\Parser\Ast\RuleInterface;
use Railt\SDL\Frontend\Builder\BaseBuilder;
use Railt\SDL\Frontend\Context\ContextInterface;
use Railt\SDL\Frontend\Deferred\Deferred;
use Railt\SDL\Frontend\Deferred\DeferredInterface;
use Railt\SDL\Frontend\Deferred\NamedDeferred;
use Railt\SDL\IR\SymbolTable\Value;
use Railt\SDL\IR\SymbolTable\VarSymbolInterface;
use Railt\SDL\IR\Type;
use Railt\SDL\IR\Type\TypeNameInterface;

/**
 * Class SchemaDefinitionBuilder
 */
class SchemaDefinitionBuilder extends BaseBuilder
{
    /**
     * @param RuleInterface $rule
     * @return bool
     */
    public function match(RuleInterface $rule): bool
    {
        return $rule->getName() === 'SchemaDefinition';
    }

    /**
     * @param ContextInterface $ctx
     * @param RuleInterface $rule
     * @return \Generator|mixed
     */
    public function reduce(ContextInterface $ctx, RuleInterface $rule)
    {
        /** @var TypeNameInterface|null $name */
        $name = yield $rule->first('> #TypeName');

        yield $this->deferred($ctx, yield $rule->first('> #TypeName'))
            ->then(function (ContextInterface $context) use ($name, $rule) {
                return $this->then($context, $rule, $name);
            });
    }

    /**
     * @param ContextInterface $ctx
     * @param RuleInterface $rule
     * @param null|TypeNameInterface $name
     */
    private function then(ContextInterface $ctx, RuleInterface $rule, ?TypeNameInterface $name): void

    {
        /** @var VarSymbolInterface $a */
        // $a = yield 'a';

        // dd($a->set(new Value(24, Type::int())));
    }

    /**
     * @param ContextInterface $context
     * @param null|TypeNameInterface $name
     * @return DeferredInterface
     */
    private function deferred(ContextInterface $context, ?TypeNameInterface $name): DeferredInterface
    {
        return $name ? new NamedDeferred($name, $context) : new Deferred($context);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2			/**
3			* This file is part of Railt package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Railt\SDL\Frontend\Builder\Definition;
11
12			use Railt\Parser\Ast\RuleInterface;
13			use Railt\SDL\Frontend\Builder\BaseBuilder;
14			use Railt\SDL\Frontend\Context\ContextInterface;
15			use Railt\SDL\Frontend\Deferred\Deferred;
16			use Railt\SDL\Frontend\Deferred\DeferredInterface;
17			use Railt\SDL\Frontend\Deferred\NamedDeferred;
18			use Railt\SDL\IR\SymbolTable\Value;
19			use Railt\SDL\IR\SymbolTable\VarSymbolInterface;
20			use Railt\SDL\IR\Type;
21			use Railt\SDL\IR\Type\TypeNameInterface;
22
23			/**
24			* Class SchemaDefinitionBuilder
25			*/
26			class SchemaDefinitionBuilder extends BaseBuilder
27			{
28			/**
29			* @param RuleInterface $rule
30			* @return bool
31			*/
32			public function match(RuleInterface $rule): bool
33			{
34			return $rule->getName() === 'SchemaDefinition';
35			}
36
37			/**
38			* @param ContextInterface $ctx
39			* @param RuleInterface $rule
40			* @return \Generator\|mixed
41			*/
42			public function reduce(ContextInterface $ctx, RuleInterface $rule)
43			{
44			/** @var TypeNameInterface\|null $name */
45			$name = yield $rule->first('> #TypeName');
46
47			yield $this->deferred($ctx, yield $rule->first('> #TypeName'))
48			->then(function (ContextInterface $context) use ($name, $rule) {
49			return $this->then($context, $rule, $name);
50			});
51			}
52
53			/**
54			* @param ContextInterface $ctx
55			* @param RuleInterface $rule
56			* @param null\|TypeNameInterface $name
57			*/
58			private function then(ContextInterface $ctx, RuleInterface $rule, ?TypeNameInterface $name): void
			0 ignored issues – show Unused Code introduced 2018-10-03 23:43 UTC by Report Bug Copy Issue Report The parameter `$ctx` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-10-03 23:43 UTC by Report Bug Copy Issue Report The parameter `$rule` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-10-03 23:43 UTC by Report Bug Copy Issue Report The parameter `$name` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
59			{
60			/** @var VarSymbolInterface $a */
61			// $a = yield 'a';
62
63			// dd($a->set(new Value(24, Type::int())));
64			}
65
66			/**
67			* @param ContextInterface $context
68			* @param null\|TypeNameInterface $name
69			* @return DeferredInterface
70			*/
71			private function deferred(ContextInterface $context, ?TypeNameInterface $name): DeferredInterface
72			{
73			return $name ? new NamedDeferred($name, $context) : new Deferred($context);
			0 ignored issues – show Documentation introduced 2018-10-11 01:01 UTC by Report Bug Copy Issue Report `$context` is of type `object<Railt\SDL\Fronten...ntext\ContextInterface>`, but the function expects a `null\|object<Closure>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
74			}
75			}
76

railt / sdl

Push — master ( b2a65d...63a169 )

SchemaDefinitionBuilder::deferred() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like