Jsonable::jsonSerialize() - Code Metrics - Inspection of "Merge branch 'master' of github.com:railt/reflecti..." - railt/reflection - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ca1c7c...1b72cc )

by Kirill

created 2018-08-09 10:28 UTC

Jsonable::jsonSerialize() B

↳ Parent: Jsonable

Complexity

Conditions	7
Paths	16

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

Metric	Value
dl	0
loc	27
ccs	0
cts	13
cp	0
rs	8.5546
c	0
b	0
f	0
cc	7
nc	16
nop	0
crap	56

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\Reflection\Common;

use Railt\Io\Readable;
use Railt\Reflection\Contracts\Definition;
use Railt\Reflection\Contracts\Document;

/**
 * Trait Jsonable
 */
trait Jsonable
{
    /**
     * @return array
     */
    public function jsonSerialize(): array
    {
        $result = [];

        foreach ($this->getObjectFields() as $field => $value) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            foreach ($this->jsonNonRenderableTypes() as $type) {
                if ($value instanceof $type) {
                    continue 2;
                }
            }

            foreach ($this->jsonNonRenderableFields() as $name) {
                if ($field === $name) {
                    continue 2;
                }
            }

            $result[$field] = $value;
        }

        // Additional information about type
        if ($this instanceof Definition) {
            $result['__typename'] = $this::getType()->getName();
        }

        return $result;
    }

    /**
     * @return iterable|string[]
     */
    private function jsonNonRenderableTypes(): iterable
    {
        yield Readable::class;
        yield Document::class;
    }

    /**
     * @return iterable|string[]
     */
    private function jsonNonRenderableFields(): iterable
    {
        // Recursive relation exclusion
        yield 'parent';

        // Dictionary relation exclusion
        yield 'dictionary';

        // File information exclusion
        yield 'offset';
        yield 'line';
        yield 'column';

        // Reverse superfluous inheritance information
        yield 'extendedBy';
    }
}


1			<?php
2			/**
3			* This file is part of Railt package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Railt\Reflection\Common;
11
12			use Railt\Io\Readable;
13			use Railt\Reflection\Contracts\Definition;
14			use Railt\Reflection\Contracts\Document;
15
16			/**
17			* Trait Jsonable
18			*/
19			trait Jsonable
20			{
21			/**
22			* @return array
23			*/
24			public function jsonSerialize(): array
25			{
26			$result = [];
27
28			foreach ($this->getObjectFields() as $field => $value) {
			0 ignored issues – show Bug introduced 2018-08-03 11:48 UTC by Report Bug Copy Issue Report It seems like `getObjectFields()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29			foreach ($this->jsonNonRenderableTypes() as $type) {
30			if ($value instanceof $type) {
31			continue 2;
32			}
33			}
34
35			foreach ($this->jsonNonRenderableFields() as $name) {
36			if ($field === $name) {
37			continue 2;
38			}
39			}
40
41			$result[$field] = $value;
42			}
43
44			// Additional information about type
45			if ($this instanceof Definition) {
46			$result['__typename'] = $this::getType()->getName();
47			}
48
49			return $result;
50			}
51
52			/**
53			* @return iterable\|string[]
54			*/
55			private function jsonNonRenderableTypes(): iterable
56			{
57			yield Readable::class;
58			yield Document::class;
59			}
60
61			/**
62			* @return iterable\|string[]
63			*/
64			private function jsonNonRenderableFields(): iterable
65			{
66			// Recursive relation exclusion
67			yield 'parent';
68
69			// Dictionary relation exclusion
70			yield 'dictionary';
71
72			// File information exclusion
73			yield 'offset';
74			yield 'line';
75			yield 'column';
76
77			// Reverse superfluous inheritance information
78			yield 'extendedBy';
79			}
80			}
81

railt / reflection

Push — master ( ca1c7c...1b72cc )

Jsonable::jsonSerialize() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like