HasInterfaces::getInterfaces() - Code Metrics - Inspection of "Refactor structure" - railt/reflection - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 96b2f8...da2c9c )

by Kirill

created 2018-07-17 00:59 UTC

HasInterfaces::getInterfaces() A

↳ Parent: HasInterfaces

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	0
cts	6
cp	0
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	6

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\Reflection\Definition\Behaviour;

use Railt\Reflection\Contracts\Definition\Behaviour\ProvidesInterfaces;
use Railt\Reflection\Contracts\Definition\InterfaceDefinition;
use Railt\Reflection\Contracts\Definition\TypeDefinition;
use Railt\Reflection\Exception\TypeNotFoundException;

/**
 * Trait HasInterfaces
 * @mixin ProvidesInterfaces
 */
trait HasInterfaces
{
    /**
     * @var array|string[]
     */
    protected $interfaces = [];

    /**
     * @param TypeDefinition $definition
     * @return bool
     */
    protected function instanceOfInterface(TypeDefinition $definition): bool
    {
        foreach ($this->getInterfaces() as $interface) {
            if ($interface->instanceOf($definition)) {
                return true;
            }
        }

        return false;
    }

    /**
     * @return iterable|InterfaceDefinition[]
     */
    public function getInterfaces(): iterable
    {
        foreach ($this->interfaces as $interface) {
            yield $this->fetch($interface);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }

    /**
     * @param string $name
     * @return bool
     */
    public function hasInterface(string $name): bool
    {
        return \in_array($name, $this->interfaces, true);
    }

    /**
     * @param string $name
     * @return InterfaceDefinition
     * @throws TypeNotFoundException
     */
    public function getInterface(string $name): InterfaceDefinition
    {
        if (! \in_array($name, $this->interfaces, true)) {
            $error = \sprintf('%s does not contain an interface named "%s"', $this, $name);
            throw new TypeNotFoundException($error);
        }

        return $this->fetch($name);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param InterfaceDefinition $definition
     */
    public function addInterface(InterfaceDefinition $definition): void
    {
        $this->interfaces[] = $definition->getName();
    }
}



1			<?php
2			/**
3			* This file is part of Railt package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Railt\Reflection\Definition\Behaviour;
11
12			use Railt\Reflection\Contracts\Definition\Behaviour\ProvidesInterfaces;
13			use Railt\Reflection\Contracts\Definition\InterfaceDefinition;
14			use Railt\Reflection\Contracts\Definition\TypeDefinition;
15			use Railt\Reflection\Exception\TypeNotFoundException;
16
17			/**
18			* Trait HasInterfaces
19			* @mixin ProvidesInterfaces
20			*/
21			trait HasInterfaces
22			{
23			/**
24			* @var array\|string[]
25			*/
26			protected $interfaces = [];
27
28			/**
29			* @param TypeDefinition $definition
30			* @return bool
31			*/
32			protected function instanceOfInterface(TypeDefinition $definition): bool
33			{
34			foreach ($this->getInterfaces() as $interface) {
35			if ($interface->instanceOf($definition)) {
36			return true;
37			}
38			}
39
40			return false;
41			}
42
43			/**
44			* @return iterable\|InterfaceDefinition[]
45			*/
46			public function getInterfaces(): iterable
47			{
48			foreach ($this->interfaces as $interface) {
49			yield $this->fetch($interface);
			0 ignored issues – show Bug introduced 2018-07-17 01:05 UTC by Report Bug Copy Issue Report It seems like `fetch()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
50			}
51			}
52
53			/**
54			* @param string $name
55			* @return bool
56			*/
57			public function hasInterface(string $name): bool
58			{
59			return \in_array($name, $this->interfaces, true);
60			}
61
62			/**
63			* @param string $name
64			* @return InterfaceDefinition
65			* @throws TypeNotFoundException
66			*/
67			public function getInterface(string $name): InterfaceDefinition
68			{
69			if (! \in_array($name, $this->interfaces, true)) {
70			$error = \sprintf('%s does not contain an interface named "%s"', $this, $name);
71			throw new TypeNotFoundException($error);
72			}
73
74			return $this->fetch($name);
			0 ignored issues – show Bug introduced 2018-07-17 01:05 UTC by Report Bug Copy Issue Report It seems like `fetch()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
75			}
76
77			/**
78			* @param InterfaceDefinition $definition
79			*/
80			public function addInterface(InterfaceDefinition $definition): void
81			{
82			$this->interfaces[] = $definition->getName();
83			}
84			}
85
86

railt / reflection

Push — master ( 96b2f8...da2c9c )

HasInterfaces::getInterfaces() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like