NativeStateful::reduce() - Code Metrics - Inspection of "Revert back from latest release" - railt/lexer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8d0ca7...0aa70f )

by Kirill

created 2018-06-22 23:01 UTC

NativeStateful::reduce() A

↳ Parent: NativeStateful

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	8
cts	8
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	8
nc	3
nop	2
crap	3

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\Lexer\Driver;

use Railt\Io\Readable;
use Railt\Lexer\Iterator\RegexNamedGroupsIterator;
use Railt\Lexer\Result\Eoi;
use Railt\Lexer\Result\Token;
use Railt\Lexer\Result\Unknown;
use Railt\Lexer\Stateful;
use Railt\Lexer\TokenInterface;

/**
 * Class NativeStateful
 */
class NativeStateful extends Lexer implements Stateful
{
    /**
     * @var string
     */
    protected $pattern;

    /**
     * NativeStateful constructor.
     * @param string $pattern
     * @param array $skipped
     */
    public function __construct(string $pattern, array $skipped = [])
    {
        $this->pattern = $pattern;
        $this->skip    = $skipped;
    }

    /**
     * @param Readable $file
     * @return \Traversable
     * @throws \InvalidArgumentException
     * @throws \RuntimeException
     */
    protected function exec(Readable $file): \Traversable
    {
        $offset = 0;
        $regex  = new RegexNamedGroupsIterator($this->pattern, $file->getContents());

        $iterator = $regex->getIterator();

        while ($iterator->valid()) {
            /** @var TokenInterface $token */
            $token = $iterator->key() === Unknown::T_NAME
                ? $this->unknown($iterator, $offset)
                : $this->token($iterator, $offset);

            $offset += $token->bytes();

            yield $token;
        }

        yield new Eoi($offset);
    }

    /**
     * @param \Traversable|\Generator $iterator
     * @param int $offset
     * @return Unknown
     */
    private function unknown(\Traversable $iterator, int $offset): TokenInterface
    {
        $body = $iterator->current()[0];
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $iterator->next();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $body .= $this->reduce($iterator, Unknown::T_NAME);

        return new Unknown($body, $offset);
    }

    /**
     * @param \Traversable|\Iterator $iterator
     * @param string $key
     * @return string
     */
    protected function reduce(\Traversable $iterator, string $key): string
    {
        $body = '';

        while ($iterator->valid()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            if ($iterator->key() !== $key) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                break;
            }

            $body .= $iterator->current()[0];
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

            $iterator->next();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }

        return $body;
    }

    /**
     * @param \Traversable|\Iterator $iterator
     * @param int $offset
     * @return Token
     */
    private function token(\Traversable $iterator, int $offset): TokenInterface
    {
        [$name, $context] = [$iterator->key(), $iterator->current()];
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $iterator->next();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return new Token($name, $context, $offset);
    }
}


1		<?php
2		/**
3		* This file is part of Railt package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8		declare(strict_types=1);
9
10		namespace Railt\Lexer\Driver;
11
12		use Railt\Io\Readable;
13		use Railt\Lexer\Iterator\RegexNamedGroupsIterator;
14		use Railt\Lexer\Result\Eoi;
15		use Railt\Lexer\Result\Token;
16		use Railt\Lexer\Result\Unknown;
17		use Railt\Lexer\Stateful;
18		use Railt\Lexer\TokenInterface;
19
20		/**
21		* Class NativeStateful
22		*/
23		class NativeStateful extends Lexer implements Stateful
24		{
25		/**
26		* @var string
27		*/
28		protected $pattern;
29
30		/**
31		* NativeStateful constructor.
32		* @param string $pattern
33		* @param array $skipped
34		*/
35	11	public function __construct(string $pattern, array $skipped = [])
36		{
37	11	$this->pattern = $pattern;
38	11	$this->skip = $skipped;
39	11	}
40
41		/**
42		* @param Readable $file
43		* @return \Traversable
44		* @throws \InvalidArgumentException
45		* @throws \RuntimeException
46		*/
47	17	protected function exec(Readable $file): \Traversable
48		{
49	17	$offset = 0;
50	17	$regex = new RegexNamedGroupsIterator($this->pattern, $file->getContents());
51
52	17	$iterator = $regex->getIterator();
53
54	17	while ($iterator->valid()) {
55		/** @var TokenInterface $token */
56	17	$token = $iterator->key() === Unknown::T_NAME
57	9	? $this->unknown($iterator, $offset)
58	17	: $this->token($iterator, $offset);
59
60	17	$offset += $token->bytes();
61
62	17	yield $token;
63		}
64
65	17	yield new Eoi($offset);
66	17	}
67
68		/**
69		* @param \Traversable\|\Generator $iterator
70		* @param int $offset
71		* @return Unknown
72		*/
73	9	private function unknown(\Traversable $iterator, int $offset): TokenInterface
74		{
75	9	$body = $iterator->current()[0];
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `current()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
76	9	$iterator->next();
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `next()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
77
78	9	$body .= $this->reduce($iterator, Unknown::T_NAME);
79
80	9	return new Unknown($body, $offset);
81		}
82
83		/**
84		* @param \Traversable\|\Iterator $iterator
85		* @param string $key
86		* @return string
87		*/
88	9	protected function reduce(\Traversable $iterator, string $key): string
89		{
90	9	$body = '';
91
92	9	while ($iterator->valid()) {
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `valid()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
93	9	if ($iterator->key() !== $key) {
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `key()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
94	9	break;
95		}
96
97	3	$body .= $iterator->current()[0];
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `current()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
98
99	3	$iterator->next();
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `next()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
100		}
101
102	9	return $body;
103		}
104
105		/**
106		* @param \Traversable\|\Iterator $iterator
107		* @param int $offset
108		* @return Token
109		*/
110	17	private function token(\Traversable $iterator, int $offset): TokenInterface
111		{
112	17	[$name, $context] = [$iterator->key(), $iterator->current()];
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report The variable `$name` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report The variable `$context` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `key()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string / public function getDisplayName(); } Loading history... Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `current()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /* @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
113
114	17	$iterator->next();
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `next()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
115
116	17	return new Token($name, $context, $offset);
117		}
118		}
119

railt / lexer

Push — master ( 8d0ca7...0aa70f )

NativeStateful::reduce() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like