NativeStateful::lex() - Code Metrics - Inspection of "Add benchmarks" - railt/lexer - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( d0ad7f...9ed642 )

by Kirill

created 2018-06-22 20:51 UTC

NativeStateful::lex() A

↳ Parent: NativeStateful

Complexity

Conditions	3
Paths	3

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	4
nc	3
nop	1
crap	3

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\Lexer\Driver;

use Railt\Io\Readable;
use Railt\Lexer\Iterator\RegexNamedGroupsIterator;
use Railt\Lexer\Result\Eoi;
use Railt\Lexer\Result\Token;
use Railt\Lexer\Result\Unknown;
use Railt\Lexer\Stateful;
use Railt\Lexer\TokenInterface;

/**
 * Class NativeStateful
 */
class NativeStateful implements Stateful
{
    /**
     * @var string
     */
    protected $pattern;

    /**
     * @var array
     */
    protected $skipped;

    /**
     * NativeStateful constructor.
     * @param string $pattern
     * @param array $skipped
     */
    public function __construct(string $pattern, array $skipped = [])
    {
        $this->pattern = $pattern;
        $this->skipped = $skipped;
    }

    /**
     * @param Readable $input
     * @return \Traversable
     * @throws \InvalidArgumentException
     * @throws \RuntimeException
     */
    public function lex(Readable $input): \Traversable
    {
        foreach ($this->exec($this->pattern, $input->getContents()) as $token) {
            if (! \in_array($token->name(), $this->skipped, true)) {
                yield $token;
            }
        }
    }

    /**
     * @param string $pattern
     * @param string $content
     * @return \Traversable|TokenInterface[]
     * @throws \InvalidArgumentException
     * @throws \RuntimeException
     */
    protected function exec(string $pattern, string $content): \Traversable
    {
        $offset = 0;
        $regex  = new RegexNamedGroupsIterator($pattern, $content);

        $iterator = $regex->getIterator();

        while ($iterator->valid()) {
            /** @var TokenInterface $token */
            $token = $iterator->key() === Unknown::T_NAME
                ? $this->unknown($iterator, $offset)
                : $this->token($iterator, $offset);

            $offset += $token->bytes();

            yield $token;
        }

        yield new Eoi($offset);
    }

    /**
     * @param \Traversable|\Generator $iterator
     * @param int $offset
     * @return Unknown
     */
    private function unknown(\Traversable $iterator, int $offset): TokenInterface
    {
        $body = $iterator->current()[0];
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $iterator->next();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $body .= $this->collapse($iterator, Unknown::T_NAME);

        return new Unknown($body, $offset);
    }

    /**
     * @param \Traversable|\Iterator $iterator
     * @param string $token
     * @return string
     */
    private function collapse(\Traversable $iterator, string $token): string
    {
        $body = '';

        while ($iterator->valid()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            if ($iterator->key() !== $token) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                break;
            }

            $body .= $iterator->current()[0];
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

            $iterator->next();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }

        return $body;
    }

    /**
     * @param \Traversable|\Iterator $iterator
     * @param int $offset
     * @return Token
     */
    private function token(\Traversable $iterator, int $offset): TokenInterface
    {
        [$name, $context] = [$iterator->key(), $iterator->current()];
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $iterator->next();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return new Token($name, $context, $offset);
    }
}


1		<?php
2		/**
3		* This file is part of Railt package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8		declare(strict_types=1);
9
10		namespace Railt\Lexer\Driver;
11
12		use Railt\Io\Readable;
13		use Railt\Lexer\Iterator\RegexNamedGroupsIterator;
14		use Railt\Lexer\Result\Eoi;
15		use Railt\Lexer\Result\Token;
16		use Railt\Lexer\Result\Unknown;
17		use Railt\Lexer\Stateful;
18		use Railt\Lexer\TokenInterface;
19
20		/**
21		* Class NativeStateful
22		*/
23		class NativeStateful implements Stateful
24		{
25		/**
26		* @var string
27		*/
28		protected $pattern;
29
30		/**
31		* @var array
32		*/
33		protected $skipped;
34
35	11	/**
36		* NativeStateful constructor.
37	11	* @param string $pattern
38	11	* @param array $skipped
39	11	*/
40		public function __construct(string $pattern, array $skipped = [])
41		{
42		$this->pattern = $pattern;
43		$this->skipped = $skipped;
44		}
45	17
46		/**
47	17	* @param Readable $input
48	17	* @return \Traversable
49		* @throws \InvalidArgumentException
50	17	* @throws \RuntimeException
51		*/
52	17	public function lex(Readable $input): \Traversable
53		{
54	17	foreach ($this->exec($this->pattern, $input->getContents()) as $token) {
55	9	if (! \in_array($token->name(), $this->skipped, true)) {
56	17	yield $token;
57		}
58	17	}
59		}
60	17
61		/**
62		* @param string $pattern
63	17	* @param string $content
64	17	* @return \Traversable\|TokenInterface[]
65		* @throws \InvalidArgumentException
66		* @throws \RuntimeException
67		*/
68		protected function exec(string $pattern, string $content): \Traversable
69		{
70		$offset = 0;
71	9	$regex = new RegexNamedGroupsIterator($pattern, $content);
72
73	9	$iterator = $regex->getIterator();
74	9
75		while ($iterator->valid()) {
76	9	/** @var TokenInterface $token */
77		$token = $iterator->key() === Unknown::T_NAME
78	9	? $this->unknown($iterator, $offset)
79		: $this->token($iterator, $offset);
80
81		$offset += $token->bytes();
82
83		yield $token;
84		}
85
86	9	yield new Eoi($offset);
87		}
88	9
89		/**
90	9	* @param \Traversable\|\Generator $iterator
91	9	* @param int $offset
92	9	* @return Unknown
93		*/
94		private function unknown(\Traversable $iterator, int $offset): TokenInterface
95	3	{
96		$body = $iterator->current()[0];
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `current()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
97	3	$iterator->next();
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `next()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
98
99		$body .= $this->collapse($iterator, Unknown::T_NAME);
100	9
101		return new Unknown($body, $offset);
102		}
103
104		/**
105		* @param \Traversable\|\Iterator $iterator
106		* @param string $token
107		* @return string
108	17	*/
109		private function collapse(\Traversable $iterator, string $token): string
110	17	{
111		$body = '';
112	17
113		while ($iterator->valid()) {
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `valid()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
114	17	if ($iterator->key() !== $token) {
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `key()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
115		break;
116		}
117
118		$body .= $iterator->current()[0];
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `current()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
119
120		$iterator->next();
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `next()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
121		}
122
123		return $body;
124		}
125
126		/**
127		* @param \Traversable\|\Iterator $iterator
128		* @param int $offset
129		* @return Token
130		*/
131		private function token(\Traversable $iterator, int $offset): TokenInterface
132		{
133		[$name, $context] = [$iterator->key(), $iterator->current()];
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report The variable `$name` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report The variable `$context` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `key()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string / public function getDisplayName(); } Loading history... Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `current()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /* @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
134
135		$iterator->next();
		0 ignored issues – show Bug introduced 2018-06-08 17:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `next()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
136
137		return new Token($name, $context, $offset);
138		}
139		}
140

railt / lexer

Push — master ( d0ad7f...9ed642 )

NativeStateful::lex() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like