Issues in Command.php (master) - Issues in master - railt/console - Measure and Improve Code Quality continuously with Scrutinizer

Issues (26)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Command.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\Console;

use Symfony\Component\Console\Command\Command as Symfony;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class Command
 */
abstract class Command extends Symfony
{
    /**
     * @var string
     */
    protected $signature = '';

    /**
     * @var string
     */
    protected $description = '';

    /**
     * @var InputInterface
     */
    protected $input;

    /**
     * @var OutputInterface
     */
    protected $output;

    /**
     * @throws \Symfony\Component\Console\Exception\InvalidArgumentException
     */
    public function configure(): void
    {
        try {
            $parser = new SignatureParser($this->signature);

            $this->setName($parser->getName());
            $this->setDescription($this->description ?: \get_class($this) . ' command');

            foreach ($parser->getArguments() as $argument) {
                $this->getDefinition()->addArgument($argument);
            }

            foreach ($parser->getOptions() as $option) {
                $this->getDefinition()->addOption($option);
            }
        } catch (\Throwable $e) {
            $this->throw($e);
        }
    }

    /**
     * @param \Throwable $e
     * @param OutputInterface|null $output
     * @throws \Symfony\Component\Console\Exception\InvalidArgumentException
     */
    private function throw(\Throwable $e, OutputInterface $output = null): void
    {
        $this->getApplication()->throw($e, $output ?? $this->output);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @return Application|\Symfony\Component\Console\Application
     */
    public function getApplication(): Application
    {
        return parent::getApplication();
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return int|null|void
     * @throws \Symfony\Component\Console\Exception\InvalidArgumentException
     * @throws \Throwable
     */
    public function execute(InputInterface $input, OutputInterface $output)
    {
        $this->input  = $input;
        $this->output = $output;

        try {
            $this->handle();
        } catch (\Throwable $e) {
            $this->throw($e, $output);
        }
    }

    /**
     * @return mixed
     */
    abstract public function handle();

    /**
     * @param string $message
     */
    protected function write(string $message): void
    {
        $this->output->write($message);
    }

    /**
     * @param string $message
     */
    protected function writeln(string $message): void
    {
        $this->output->writeln($message);
    }

    /**
     * @param string $message
     */
    protected function info(string $message): void
    {
        $this->writeln('<info>' . $message . '</info>');
    }

    /**
     * @param string $message
     */
    protected function error(string $message): void
    {
        $this->writeln('<error>' . $message . '</error>');
    }

    /**
     * @param string $message
     */
    protected function comment(string $message): void
    {
        $this->writeln('<comment>' . $message . '</comment>');
    }

    /**
     * @param string $name
     * @return mixed
     * @throws \Symfony\Component\Console\Exception\InvalidArgumentException
     */
    protected function argument(string $name)
    {
        return $this->input->getArgument($name);
    }

    /**
     * @param string $name
     * @return mixed
     * @throws \Symfony\Component\Console\Exception\InvalidArgumentException
     */
    protected function option(string $name)
    {
        return $this->input->getOption($name);
    }
}


1			<?php
2			/**
3			* This file is part of Railt package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Railt\Console;
11
12			use Symfony\Component\Console\Command\Command as Symfony;
13			use Symfony\Component\Console\Input\InputInterface;
14			use Symfony\Component\Console\Output\OutputInterface;
15
16			/**
17			* Class Command
18			*/
19			abstract class Command extends Symfony
20			{
21			/**
22			* @var string
23			*/
24			protected $signature = '';
25
26			/**
27			* @var string
28			*/
29			protected $description = '';
30
31			/**
32			* @var InputInterface
33			*/
34			protected $input;
35
36			/**
37			* @var OutputInterface
38			*/
39			protected $output;
40
41			/**
42			* @throws \Symfony\Component\Console\Exception\InvalidArgumentException
43			*/
44			public function configure(): void
45			{
46			try {
47			$parser = new SignatureParser($this->signature);
48
49			$this->setName($parser->getName());
50			$this->setDescription($this->description ?: \get_class($this) . ' command');
51
52			foreach ($parser->getArguments() as $argument) {
53			$this->getDefinition()->addArgument($argument);
54			}
55
56			foreach ($parser->getOptions() as $option) {
57			$this->getDefinition()->addOption($option);
58			}
59			} catch (\Throwable $e) {
60			$this->throw($e);
61			}
62			}
63
64			/**
65			* @param \Throwable $e
66			* @param OutputInterface\|null $output
67			* @throws \Symfony\Component\Console\Exception\InvalidArgumentException
68			*/
69			private function throw(\Throwable $e, OutputInterface $output = null): void
70			{
71			$this->getApplication()->throw($e, $output ?? $this->output);
			0 ignored issues – show Documentation introduced 2018-07-22 15:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$output ?? $this->output` is of type `object<Symfony\Component...Output\OutputInterface>`, but the function expects a `null\|object<Symfony\Comp...e\Output\ConsoleOutput>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
72			}
73
74			/**
75			* @return Application\|\Symfony\Component\Console\Application
76			*/
77			public function getApplication(): Application
78			{
79			return parent::getApplication();
80			}
81
82			/**
83			* @param InputInterface $input
84			* @param OutputInterface $output
85			* @return int\|null\|void
86			* @throws \Symfony\Component\Console\Exception\InvalidArgumentException
87			* @throws \Throwable
88			*/
89			public function execute(InputInterface $input, OutputInterface $output)
90			{
91			$this->input = $input;
92			$this->output = $output;
93
94			try {
95			$this->handle();
96			} catch (\Throwable $e) {
97			$this->throw($e, $output);
98			}
99			}
100
101			/**
102			* @return mixed
103			*/
104			abstract public function handle();
105
106			/**
107			* @param string $message
108			*/
109			protected function write(string $message): void
110			{
111			$this->output->write($message);
112			}
113
114			/**
115			* @param string $message
116			*/
117			protected function writeln(string $message): void
118			{
119			$this->output->writeln($message);
120			}
121
122			/**
123			* @param string $message
124			*/
125			protected function info(string $message): void
126			{
127			$this->writeln('<info>' . $message . '</info>');
128			}
129
130			/**
131			* @param string $message
132			*/
133			protected function error(string $message): void
134			{
135			$this->writeln('<error>' . $message . '</error>');
136			}
137
138			/**
139			* @param string $message
140			*/
141			protected function comment(string $message): void
142			{
143			$this->writeln('<comment>' . $message . '</comment>');
144			}
145
146			/**
147			* @param string $name
148			* @return mixed
149			* @throws \Symfony\Component\Console\Exception\InvalidArgumentException
150			*/
151			protected function argument(string $name)
152			{
153			return $this->input->getArgument($name);
154			}
155
156			/**
157			* @param string $name
158			* @return mixed
159			* @throws \Symfony\Component\Console\Exception\InvalidArgumentException
160			*/
161			protected function option(string $name)
162			{
163			return $this->input->getOption($name);
164			}
165			}
166

railt / console

Issues (26)

Security Analysis no request data

src/Command.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like