PragmaResolver::resolve() - Code Metrics - Inspection of "Improve analyzer and grammar structures" - railt/compiler - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 69b695...671bd7 )

by Kirill

created 2018-06-20 22:12 UTC

PragmaResolver::resolve() A

↳ Parent: PragmaResolver

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	0
cts	10
cp	0
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	3
nop	2
crap	12

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\Compiler\Grammar\PP2;

use Railt\Compiler\Reader\BasePragmas;
use Railt\Io\Readable;
use Railt\Lexer\TokenInterface;

/**
 * Class PragmaResolver
 */
class PragmaResolver extends BasePragmas implements ResolverInterface
{
    /**
     * @param Readable $readable
     * @param TokenInterface $token
     * @throws \Railt\Io\Exception\ExternalFileException
     */
    public function resolve(Readable $readable, TokenInterface $token): void
    {
        [$name, $value] = [$token->value(1), $token->value(2)];
function someFunction() {
    $x = 5;
    echo $x;
}

        foreach ($this->getResolvers() as $group => $resolver) {
            if ($resolver->match($name)) {
                $name = $this->verifyPragmaName($readable, $token, $resolver->resolve($name));
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

                $this->set($group, $name, $value);
            }
        }
    }
}


1			<?php
2			/**
3			* This file is part of Railt package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Railt\Compiler\Grammar\PP2;
11
12			use Railt\Compiler\Reader\BasePragmas;
13			use Railt\Io\Readable;
14			use Railt\Lexer\TokenInterface;
15
16			/**
17			* Class PragmaResolver
18			*/
19			class PragmaResolver extends BasePragmas implements ResolverInterface
20			{
21			/**
22			* @param Readable $readable
23			* @param TokenInterface $token
24			* @throws \Railt\Io\Exception\ExternalFileException
25			*/
26			public function resolve(Readable $readable, TokenInterface $token): void
27			{
28			[$name, $value] = [$token->value(1), $token->value(2)];
			0 ignored issues – show Bug introduced 2018-06-19 00:26 UTC by Report Bug Copy Issue Report The variable `$name` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history... Bug introduced 2018-06-19 00:26 UTC by Report Bug Copy Issue Report The variable `$value` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
29
30			foreach ($this->getResolvers() as $group => $resolver) {
31			if ($resolver->match($name)) {
32			$name = $this->verifyPragmaName($readable, $token, $resolver->resolve($name));
			0 ignored issues – show Bug introduced 2018-06-20 22:19 UTC by Report Bug Copy Issue Report The variable `$name` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
33
34			$this->set($group, $name, $value);
35			}
36			}
37			}
38			}
39

railt / compiler

Push — master ( 69b695...671bd7 )

PragmaResolver::resolve() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like