NativeStateful::token() - Code Metrics - Inspection of "Fix unexpected tokens exception" - railt/compiler - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 85fc11...2d6c85 )

by Kirill

created 2018-05-11 14:44 UTC

NativeStateful::token() A

↳ Parent: NativeStateful

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	2
dl	0
loc	8
ccs	4
cts	4
cp	1
crap	1
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\Compiler\Lexer;

use Railt\Compiler\Iterator\RegexNamedGroupsIterator;
use Railt\Compiler\Lexer\Result\Eoi;
use Railt\Compiler\Lexer\Result\Token;
use Railt\Compiler\Lexer\Result\Unknown;
use Railt\Compiler\TokenInterface;
use Railt\Io\Readable;

/**
 * Class NativeStateful
 */
class NativeStateful implements Stateful
{
    /**
     * @var string
     */
    protected $pattern;

    /**
     * @var array
     */
    protected $skipped;

    /**
     * NativeStateful constructor.
     * @param string $pattern
     * @param array $skipped
     */
    public function __construct(string $pattern, array $skipped = [])
    {
        $this->pattern = $pattern;
        $this->skipped = $skipped;
    }

    /**
     * @param Readable $input
     * @return \Traversable
     */
    public function lex(Readable $input): \Traversable
    {
        foreach ($this->exec($this->pattern, $input->getContents()) as $token) {
            if (! \in_array($token->name(), $this->skipped, true)) {
                yield $token;
            }
        }
    }

    /**
     * @param string $pattern
     * @param string $content
     * @return \Traversable|TokenInterface[]
     */
    protected function exec(string $pattern, string $content): \Traversable
    {
        $offset = 0;
        $regex  = new RegexNamedGroupsIterator($pattern, $content);

        $iterator = $regex->getIterator();

        while ($iterator->valid()) {
            /** @var TokenInterface $token */
            $token = $iterator->key() === Token::UNKNOWN_TOKEN
                ? $this->unknown($iterator, $offset)
                : $this->token($iterator, $offset);

            $offset += $token->bytes();

            yield $token;
        }

        yield new Eoi($offset);
    }

    /**
     * @param \Traversable $iterator
     * @param int $offset
     * @return Unknown
     */
    private function unknown(\Traversable $iterator, int $offset): TokenInterface
    {
        $body = $iterator->current()[0];
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $iterator->next();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $body .= $this->collapse($iterator, TokenInterface::UNKNOWN_TOKEN);

        return new Unknown($body, $offset);
    }

    /**
     * @param \Traversable $iterator
     * @return string
     */
    private function collapse(\Traversable $iterator, string $token): string
    {
        $body = '';

        while ($iterator->valid()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            if ($iterator->key() !== $token) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                break;
            }

            $body .= $iterator->current()[0];
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

            $iterator->next();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }

        return $body;
    }

    /**
     * @param \Traversable $iterator
     * @param int $offset
     * @return Token
     */
    private function token(\Traversable $iterator, int $offset)
    {
        [$name, $context] = [$iterator->key(), $iterator->current()];
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $iterator->next();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return new Token($name, $context, $offset);
    }
}


1		<?php
2		/**
3		* This file is part of Railt package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8		declare(strict_types=1);
9
10		namespace Railt\Compiler\Lexer;
11
12		use Railt\Compiler\Iterator\RegexNamedGroupsIterator;
13		use Railt\Compiler\Lexer\Result\Eoi;
14		use Railt\Compiler\Lexer\Result\Token;
15		use Railt\Compiler\Lexer\Result\Unknown;
16		use Railt\Compiler\TokenInterface;
17		use Railt\Io\Readable;
18
19		/**
20		* Class NativeStateful
21		*/
22		class NativeStateful implements Stateful
23		{
24		/**
25		* @var string
26		*/
27		protected $pattern;
28
29		/**
30		* @var array
31		*/
32		protected $skipped;
33
34		/**
35		* NativeStateful constructor.
36		* @param string $pattern
37		* @param array $skipped
38		*/
39	54	public function __construct(string $pattern, array $skipped = [])
40		{
41	54	$this->pattern = $pattern;
42	54	$this->skipped = $skipped;
43	54	}
44
45		/**
46		* @param Readable $input
47		* @return \Traversable
48		*/
49	54	public function lex(Readable $input): \Traversable
50		{
51	54	foreach ($this->exec($this->pattern, $input->getContents()) as $token) {
52	54	if (! \in_array($token->name(), $this->skipped, true)) {
53	54	yield $token;
54		}
55		}
56	54	}
57
58		/**
59		* @param string $pattern
60		* @param string $content
61		* @return \Traversable\|TokenInterface[]
62		*/
63	54	protected function exec(string $pattern, string $content): \Traversable
64		{
65	54	$offset = 0;
66	54	$regex = new RegexNamedGroupsIterator($pattern, $content);
67
68	54	$iterator = $regex->getIterator();
69
70	54	while ($iterator->valid()) {
71		/** @var TokenInterface $token */
72	54	$token = $iterator->key() === Token::UNKNOWN_TOKEN
73		? $this->unknown($iterator, $offset)
74	54	: $this->token($iterator, $offset);
75
76	54	$offset += $token->bytes();
77
78	54	yield $token;
79		}
80
81	54	yield new Eoi($offset);
82	54	}
83
84		/**
85		* @param \Traversable $iterator
86		* @param int $offset
87		* @return Unknown
88		*/
89		private function unknown(\Traversable $iterator, int $offset): TokenInterface
90		{
91		$body = $iterator->current()[0];
		0 ignored issues – show Bug introduced 2018-05-11 14:47 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `current()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `CoreTestIterator`, `DirectoryIterator`, `Doctrine\Common\Collections\AbstractLazyCollection`, `Doctrine\Common\Collections\ArrayCollection`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `Railt\Compiler\Iterator\Buffer`, `Railt\Compiler\Iterator\LookaheadIterator`, `Railt\Compiler\Iterator\PairBuffer`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `Symfony\Component\Finder...or\CustomFilterIterator`, `Symfony\Component\Finder...DateRangeFilterIterator`, `Symfony\Component\Finder...epthRangeFilterIterator`, `Symfony\Component\Finder...DirectoryFilterIterator`, `Symfony\Component\Finder...\FileTypeFilterIterator`, `Symfony\Component\Finder...lecontentFilterIterator`, `Symfony\Component\Finder...\FilenameFilterIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `Symfony\Component\Finder...ator\PathFilterIterator`, `Symfony\Component\Finder...ursiveDirectoryIterator`, `Symfony\Component\Finder...SizeRangeFilterIterator`, `Symfony\Component\Finder...rator\InnerNameIterator`, `Symfony\Component\Finder...rator\InnerSizeIterator`, `Symfony\Component\Finder...rator\InnerTypeIterator`, `Symfony\Component\Finder\Tests\Iterator\Iterator`, `Symfony\Component\Finder...or\MockFileListIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`, `TwigTestFoo`, `Twig\Util\TemplateDirIterator`, `Twig_Util_TemplateDirIterator`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
92		$iterator->next();
		0 ignored issues – show Bug introduced 2018-05-11 14:47 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `next()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `CoreTestIterator`, `DirectoryIterator`, `Doctrine\Common\Collections\AbstractLazyCollection`, `Doctrine\Common\Collections\ArrayCollection`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `Railt\Compiler\Iterator\Buffer`, `Railt\Compiler\Iterator\LookaheadIterator`, `Railt\Compiler\Iterator\PairBuffer`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `Symfony\Component\Finder...or\CustomFilterIterator`, `Symfony\Component\Finder...DateRangeFilterIterator`, `Symfony\Component\Finder...epthRangeFilterIterator`, `Symfony\Component\Finder...DirectoryFilterIterator`, `Symfony\Component\Finder...\FileTypeFilterIterator`, `Symfony\Component\Finder...lecontentFilterIterator`, `Symfony\Component\Finder...\FilenameFilterIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `Symfony\Component\Finder...ator\PathFilterIterator`, `Symfony\Component\Finder...ursiveDirectoryIterator`, `Symfony\Component\Finder...SizeRangeFilterIterator`, `Symfony\Component\Finder...rator\InnerNameIterator`, `Symfony\Component\Finder...rator\InnerSizeIterator`, `Symfony\Component\Finder...rator\InnerTypeIterator`, `Symfony\Component\Finder\Tests\Iterator\Iterator`, `Symfony\Component\Finder...or\MockFileListIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`, `TwigTestFoo`, `Twig\Util\TemplateDirIterator`, `Twig_Util_TemplateDirIterator`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
93
94		$body .= $this->collapse($iterator, TokenInterface::UNKNOWN_TOKEN);
95
96		return new Unknown($body, $offset);
97		}
98
99		/**
100		* @param \Traversable $iterator
101		* @return string
102		*/
103		private function collapse(\Traversable $iterator, string $token): string
104		{
105		$body = '';
106
107		while ($iterator->valid()) {
		0 ignored issues – show Bug introduced 2018-05-11 14:47 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `valid()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `CoreTestIterator`, `DirectoryIterator`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `Railt\Compiler\Iterator\Buffer`, `Railt\Compiler\Iterator\LookaheadIterator`, `Railt\Compiler\Iterator\PairBuffer`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `Symfony\Component\Finder...or\CustomFilterIterator`, `Symfony\Component\Finder...DateRangeFilterIterator`, `Symfony\Component\Finder...epthRangeFilterIterator`, `Symfony\Component\Finder...DirectoryFilterIterator`, `Symfony\Component\Finder...\FileTypeFilterIterator`, `Symfony\Component\Finder...lecontentFilterIterator`, `Symfony\Component\Finder...\FilenameFilterIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `Symfony\Component\Finder...ator\PathFilterIterator`, `Symfony\Component\Finder...ursiveDirectoryIterator`, `Symfony\Component\Finder...SizeRangeFilterIterator`, `Symfony\Component\Finder...rator\InnerNameIterator`, `Symfony\Component\Finder...rator\InnerSizeIterator`, `Symfony\Component\Finder...rator\InnerTypeIterator`, `Symfony\Component\Finder\Tests\Iterator\Iterator`, `Symfony\Component\Finder...or\MockFileListIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`, `TwigTestFoo`, `Twig\Util\TemplateDirIterator`, `Twig_Util_TemplateDirIterator`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
108		if ($iterator->key() !== $token) {
		0 ignored issues – show Bug introduced 2018-05-11 14:47 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `key()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `CoreTestIterator`, `DirectoryIterator`, `Doctrine\Common\Collections\AbstractLazyCollection`, `Doctrine\Common\Collections\ArrayCollection`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `Railt\Compiler\Iterator\Buffer`, `Railt\Compiler\Iterator\LookaheadIterator`, `Railt\Compiler\Iterator\PairBuffer`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `Symfony\Component\Finder...or\CustomFilterIterator`, `Symfony\Component\Finder...DateRangeFilterIterator`, `Symfony\Component\Finder...epthRangeFilterIterator`, `Symfony\Component\Finder...DirectoryFilterIterator`, `Symfony\Component\Finder...\FileTypeFilterIterator`, `Symfony\Component\Finder...lecontentFilterIterator`, `Symfony\Component\Finder...\FilenameFilterIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `Symfony\Component\Finder...ator\PathFilterIterator`, `Symfony\Component\Finder...ursiveDirectoryIterator`, `Symfony\Component\Finder...SizeRangeFilterIterator`, `Symfony\Component\Finder...rator\InnerNameIterator`, `Symfony\Component\Finder...rator\InnerSizeIterator`, `Symfony\Component\Finder...rator\InnerTypeIterator`, `Symfony\Component\Finder\Tests\Iterator\Iterator`, `Symfony\Component\Finder...or\MockFileListIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`, `TwigTestFoo`, `Twig\Util\TemplateDirIterator`, `Twig_Util_TemplateDirIterator`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
109		break;
110		}
111
112		$body .= $iterator->current()[0];
		0 ignored issues – show Bug introduced 2018-05-11 14:47 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `current()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `CoreTestIterator`, `DirectoryIterator`, `Doctrine\Common\Collections\AbstractLazyCollection`, `Doctrine\Common\Collections\ArrayCollection`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `Railt\Compiler\Iterator\Buffer`, `Railt\Compiler\Iterator\LookaheadIterator`, `Railt\Compiler\Iterator\PairBuffer`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `Symfony\Component\Finder...or\CustomFilterIterator`, `Symfony\Component\Finder...DateRangeFilterIterator`, `Symfony\Component\Finder...epthRangeFilterIterator`, `Symfony\Component\Finder...DirectoryFilterIterator`, `Symfony\Component\Finder...\FileTypeFilterIterator`, `Symfony\Component\Finder...lecontentFilterIterator`, `Symfony\Component\Finder...\FilenameFilterIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `Symfony\Component\Finder...ator\PathFilterIterator`, `Symfony\Component\Finder...ursiveDirectoryIterator`, `Symfony\Component\Finder...SizeRangeFilterIterator`, `Symfony\Component\Finder...rator\InnerNameIterator`, `Symfony\Component\Finder...rator\InnerSizeIterator`, `Symfony\Component\Finder...rator\InnerTypeIterator`, `Symfony\Component\Finder\Tests\Iterator\Iterator`, `Symfony\Component\Finder...or\MockFileListIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`, `TwigTestFoo`, `Twig\Util\TemplateDirIterator`, `Twig_Util_TemplateDirIterator`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
113
114		$iterator->next();
		0 ignored issues – show Bug introduced 2018-05-11 14:47 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `next()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `CoreTestIterator`, `DirectoryIterator`, `Doctrine\Common\Collections\AbstractLazyCollection`, `Doctrine\Common\Collections\ArrayCollection`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `Railt\Compiler\Iterator\Buffer`, `Railt\Compiler\Iterator\LookaheadIterator`, `Railt\Compiler\Iterator\PairBuffer`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `Symfony\Component\Finder...or\CustomFilterIterator`, `Symfony\Component\Finder...DateRangeFilterIterator`, `Symfony\Component\Finder...epthRangeFilterIterator`, `Symfony\Component\Finder...DirectoryFilterIterator`, `Symfony\Component\Finder...\FileTypeFilterIterator`, `Symfony\Component\Finder...lecontentFilterIterator`, `Symfony\Component\Finder...\FilenameFilterIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `Symfony\Component\Finder...ator\PathFilterIterator`, `Symfony\Component\Finder...ursiveDirectoryIterator`, `Symfony\Component\Finder...SizeRangeFilterIterator`, `Symfony\Component\Finder...rator\InnerNameIterator`, `Symfony\Component\Finder...rator\InnerSizeIterator`, `Symfony\Component\Finder...rator\InnerTypeIterator`, `Symfony\Component\Finder\Tests\Iterator\Iterator`, `Symfony\Component\Finder...or\MockFileListIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`, `TwigTestFoo`, `Twig\Util\TemplateDirIterator`, `Twig_Util_TemplateDirIterator`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
115		}
116
117		return $body;
118		}
119
120		/**
121		* @param \Traversable $iterator
122		* @param int $offset
123		* @return Token
124		*/
125	54	private function token(\Traversable $iterator, int $offset)
126		{
127	54	[$name, $context] = [$iterator->key(), $iterator->current()];
		0 ignored issues – show Bug introduced 2018-05-11 14:47 UTC by Report Bug Copy Issue Report The variable `$name` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2018-05-11 14:47 UTC by Report Bug Copy Issue Report The variable `$context` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2018-05-11 14:47 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `key()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `CoreTestIterator`, `DirectoryIterator`, `Doctrine\Common\Collections\AbstractLazyCollection`, `Doctrine\Common\Collections\ArrayCollection`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `Railt\Compiler\Iterator\Buffer`, `Railt\Compiler\Iterator\LookaheadIterator`, `Railt\Compiler\Iterator\PairBuffer`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `Symfony\Component\Finder...or\CustomFilterIterator`, `Symfony\Component\Finder...DateRangeFilterIterator`, `Symfony\Component\Finder...epthRangeFilterIterator`, `Symfony\Component\Finder...DirectoryFilterIterator`, `Symfony\Component\Finder...\FileTypeFilterIterator`, `Symfony\Component\Finder...lecontentFilterIterator`, `Symfony\Component\Finder...\FilenameFilterIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `Symfony\Component\Finder...ator\PathFilterIterator`, `Symfony\Component\Finder...ursiveDirectoryIterator`, `Symfony\Component\Finder...SizeRangeFilterIterator`, `Symfony\Component\Finder...rator\InnerNameIterator`, `Symfony\Component\Finder...rator\InnerSizeIterator`, `Symfony\Component\Finder...rator\InnerTypeIterator`, `Symfony\Component\Finder\Tests\Iterator\Iterator`, `Symfony\Component\Finder...or\MockFileListIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`, `TwigTestFoo`, `Twig\Util\TemplateDirIterator`, `Twig_Util_TemplateDirIterator`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string / public function getDisplayName(); } Loading history... Bug introduced 2018-05-11 14:47 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `current()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `CoreTestIterator`, `DirectoryIterator`, `Doctrine\Common\Collections\AbstractLazyCollection`, `Doctrine\Common\Collections\ArrayCollection`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `Railt\Compiler\Iterator\Buffer`, `Railt\Compiler\Iterator\LookaheadIterator`, `Railt\Compiler\Iterator\PairBuffer`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `Symfony\Component\Finder...or\CustomFilterIterator`, `Symfony\Component\Finder...DateRangeFilterIterator`, `Symfony\Component\Finder...epthRangeFilterIterator`, `Symfony\Component\Finder...DirectoryFilterIterator`, `Symfony\Component\Finder...\FileTypeFilterIterator`, `Symfony\Component\Finder...lecontentFilterIterator`, `Symfony\Component\Finder...\FilenameFilterIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `Symfony\Component\Finder...ator\PathFilterIterator`, `Symfony\Component\Finder...ursiveDirectoryIterator`, `Symfony\Component\Finder...SizeRangeFilterIterator`, `Symfony\Component\Finder...rator\InnerNameIterator`, `Symfony\Component\Finder...rator\InnerSizeIterator`, `Symfony\Component\Finder...rator\InnerTypeIterator`, `Symfony\Component\Finder\Tests\Iterator\Iterator`, `Symfony\Component\Finder...or\MockFileListIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`, `TwigTestFoo`, `Twig\Util\TemplateDirIterator`, `Twig_Util_TemplateDirIterator`. Let’s take a look at an example: interface User { /* @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
128
129	54	$iterator->next();
		0 ignored issues – show Bug introduced 2018-05-11 14:47 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Traversable` as the method `next()` does only exist in the following implementations of said interface: `APCUIterator`, `AppendIterator`, `ArrayIterator`, `CachingIterator`, `CallbackFilterIterator`, `CoreTestIterator`, `DirectoryIterator`, `Doctrine\Common\Collections\AbstractLazyCollection`, `Doctrine\Common\Collections\ArrayCollection`, `EmptyIterator`, `File_Iterator`, `FilesystemIterator`, `FilterIterator`, `Generator`, `GlobIterator`, `HttpMessage`, `HttpRequestPool`, `Imagick`, `ImagickPixelIterator`, `InfiniteIterator`, `Issue523`, `IteratorIterator`, `LimitIterator`, `MongoCommandCursor`, `MongoCursor`, `MongoGridFSCursor`, `MultipleIterator`, `NoRewindIterator`, `PHPUnit\Framework\TestSuiteIterator`, `PHPUnit\Runner\Filter\ExcludeGroupFilterIterator`, `PHPUnit\Runner\Filter\GroupFilterIterator`, `PHPUnit\Runner\Filter\IncludeGroupFilterIterator`, `PHPUnit\Runner\Filter\NameFilterIterator`, `PHP_Token_Stream`, `ParentIterator`, `Phar`, `PharData`, `PharIo\Manifest\AuthorCollectionIterator`, `PharIo\Manifest\AuthorElementCollection`, `PharIo\Manifest\BundledComponentCollectionIterator`, `PharIo\Manifest\ComponentElementCollection`, `PharIo\Manifest\ElementCollection`, `PharIo\Manifest\ExtElementCollection`, `PharIo\Manifest\RequirementCollectionIterator`, `Railt\Compiler\Iterator\Buffer`, `Railt\Compiler\Iterator\LookaheadIterator`, `Railt\Compiler\Iterator\PairBuffer`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `RecursiveCallbackFilterIterator`, `RecursiveDirectoryIterator`, `RecursiveFilterIterator`, `RecursiveIteratorIterator`, `RecursiveRegexIterator`, `RecursiveTreeIterator`, `RegexIterator`, `SQLiteResult`, `SebastianBergmann\CodeCoverage\Node\Iterator`, `SimpleXMLIterator`, `SplDoublyLinkedList`, `SplFileObject`, `SplFixedArray`, `SplHeap`, `SplMaxHeap`, `SplMinHeap`, `SplObjectStorage`, `SplPriorityQueue`, `SplQueue`, `SplStack`, `SplTempFileObject`, `Symfony\Component\Finder...or\CustomFilterIterator`, `Symfony\Component\Finder...DateRangeFilterIterator`, `Symfony\Component\Finder...epthRangeFilterIterator`, `Symfony\Component\Finder...DirectoryFilterIterator`, `Symfony\Component\Finder...\FileTypeFilterIterator`, `Symfony\Component\Finder...lecontentFilterIterator`, `Symfony\Component\Finder...\FilenameFilterIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `Symfony\Component\Finder...ator\PathFilterIterator`, `Symfony\Component\Finder...ursiveDirectoryIterator`, `Symfony\Component\Finder...SizeRangeFilterIterator`, `Symfony\Component\Finder...rator\InnerNameIterator`, `Symfony\Component\Finder...rator\InnerSizeIterator`, `Symfony\Component\Finder...rator\InnerTypeIterator`, `Symfony\Component\Finder\Tests\Iterator\Iterator`, `Symfony\Component\Finder...or\MockFileListIterator`, `Symfony\Component\Finder...tiplePcreFilterIterator`, `TestIterator`, `TestIterator2`, `TheSeer\Tokenizer\TokenCollection`, `TwigTestFoo`, `Twig\Util\TemplateDirIterator`, `Twig_Util_TemplateDirIterator`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
130
131	54	return new Token($name, $context, $offset);
132		}
133		}
134

railt / compiler

Push — master ( 85fc11...2d6c85 )

NativeStateful::token() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like