RulesBuilder::build() - Code Metrics - Inspection of "Add builders" - railt/compiler - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 88ff28...2dc58f )

by Kirill

created 2018-06-19 19:11 UTC

RulesBuilder::build() B

↳ Parent: RulesBuilder

Complexity

Conditions	4
Paths	4

Size

Total Lines	26
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	26
ccs	0
cts	18
cp	0
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	13
nc	4
nop	0
crap	20

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\Compiler\Reader\Resolver;

use Railt\Compiler\Iterator\SlicedIterator;
use Railt\Compiler\Lexer;
use Railt\Compiler\Reader\Resolver\Builder\Builder;
use Railt\Compiler\Reader\Resolver\Builder\ConcatenationBuilder;
use Railt\Compiler\Reader\Resolver\Builder\TokenBuilder;
use Railt\Io\Readable;
use Railt\Lexer\TokenInterface;

/**
 * Class RulesBuilder
 */
class RulesBuilder
{
    /**
     * @var array
     */
    private $rules;

    /**
     * @var RuleResolver
     */
    private $resolver;

    /**
     * @var array
     */
    private $parsed = [];

    /**
     * @var \SplStack
     */
    private $stack;

    /**
     * @var Readable|null
     */
    private $file;

    /**
     * @var array
     */
    private $mappings = [];

    /**
     * @var int
     */
    private $lastRuleId = 0;

    /**
     * @var string
     */
    private $text = '';

    /**
     * RulesBuilder constructor.
     * @param RuleResolver $resolver
     */
    public function __construct(RuleResolver $resolver)
    {
        $this->resolver = $resolver;
        $this->rules    = $resolver->getRules();
        $this->stack    = new \SplStack();
    }

    /**
     * @return array
     */
    public function build(): array
    {
        foreach ($this->rules as $rule => $tokens) {
            if ($this->isCompleted($rule)) {
                continue;
            }


            $this->file = $this->resolver->getFiles()[$rule];

            $iterator = new SlicedIterator($tokens);

            $this->stack->push($current = $this->root($rule));

            while ($iterator->valid()) {
                $this->text .= $iterator->current()->value() . ' ';

                $this->reduce($iterator->current(), $iterator);
                $iterator->next();
            }

            $this->complete();
        }

        return $this->parsed;
    }

    /**
     * @param string $rule
     * @return bool
     */
    private function isCompleted(string $rule): bool
    {
        return \array_key_exists($rule, $this->parsed);
    }

    /**
     * @param Builder $builder
     * @return RulesBuilder
     */
    private function add(Builder $builder): RulesBuilder
    {
        $this->current()->jump($builder->getId());
        $this->stack->push($builder);

        return $this;
    }

    /**
     * @param string $rule
     * @return ConcatenationBuilder
     */
    private function root(string $rule): ConcatenationBuilder
    {
        return new ConcatenationBuilder($this->getId($rule), $this->isKept($rule) ? $rule : null);
    }

    /**
     * @param string $rule
     * @return int
     */
    private function getId(string $rule = null): int
    {
        if ($rule === null) {
            return $this->lastRuleId++;
        }

        if (\array_key_exists($rule, $this->mappings)) {
            return $this->mappings[$rule];
        }

        return $this->mappings[$rule] = $this->lastRuleId++;
    }

    /**
     * @param string $rule
     * @return bool
     */
    private function isKept(string $rule): bool
    {
        return \in_array($rule, $this->resolver->getKeep(), true);
    }

    /**
     * @param TokenInterface $token
     * @param SlicedIterator $tokens
     * @return int
     */
    private function reduce(TokenInterface $token, SlicedIterator $tokens): int

    {
        switch ($token->name()) {
            case Lexer::T_KEPT:
                return $this->reduceToken($token, true);

            case Lexer::T_SKIPPED:
                return $this->reduceToken($token, false);

            //default:
            //    $error = \sprintf('Unexpected token %s', $token);

            //    throw (new GrammarException($error))->throwsIn($this->file, $token->offset());

        }

        return 0;
    }

    /**
     * @param TokenInterface $token
     * @param bool $keep
     * @return int
     */
    private function reduceToken(TokenInterface $token, bool $keep): int
    {
        $key = $token->value(1) . ':' . $token->name();

        $builder = new TokenBuilder($this->getId($key), $token->value(1), $keep);

        $this->add($builder)->complete();

        return $builder->getId();
    }

    private function reduceConcat(SlicedIterator $iterator)

    {
        dd($iterator);
    }

    /**
     * @return RulesBuilder
     */
    private function complete(): RulesBuilder
    {
        /** @var Builder $rule */
        $rule = $this->stack->pop();
        $instance = $rule->build();

        if ($rule->getName()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->parsed[$rule->getName()] = $instance;
        } else {
            $this->parsed[] = $instance;
        }

        $instance->{'--grammar--'} = $this->text;
        $this->text = '';

        return $this;
    }

    /**
     * @return Builder
     */
    private function current(): Builder
    {
        return $this->stack->top();
    }
}


1			<?php
2			/**
3			* This file is part of Railt package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Railt\Compiler\Reader\Resolver;
11
12			use Railt\Compiler\Iterator\SlicedIterator;
13			use Railt\Compiler\Lexer;
14			use Railt\Compiler\Reader\Resolver\Builder\Builder;
15			use Railt\Compiler\Reader\Resolver\Builder\ConcatenationBuilder;
16			use Railt\Compiler\Reader\Resolver\Builder\TokenBuilder;
17			use Railt\Io\Readable;
18			use Railt\Lexer\TokenInterface;
19
20			/**
21			* Class RulesBuilder
22			*/
23			class RulesBuilder
24			{
25			/**
26			* @var array
27			*/
28			private $rules;
29
30			/**
31			* @var RuleResolver
32			*/
33			private $resolver;
34
35			/**
36			* @var array
37			*/
38			private $parsed = [];
39
40			/**
41			* @var \SplStack
42			*/
43			private $stack;
44
45			/**
46			* @var Readable\|null
47			*/
48			private $file;
49
50			/**
51			* @var array
52			*/
53			private $mappings = [];
54
55			/**
56			* @var int
57			*/
58			private $lastRuleId = 0;
59
60			/**
61			* @var string
62			*/
63			private $text = '';
64
65			/**
66			* RulesBuilder constructor.
67			* @param RuleResolver $resolver
68			*/
69			public function __construct(RuleResolver $resolver)
70			{
71			$this->resolver = $resolver;
72			$this->rules = $resolver->getRules();
73			$this->stack = new \SplStack();
74			}
75
76			/**
77			* @return array
78			*/
79			public function build(): array
80			{
81			foreach ($this->rules as $rule => $tokens) {
82			if ($this->isCompleted($rule)) {
83			continue;
84			}
85
86
87			$this->file = $this->resolver->getFiles()[$rule];
88
89			$iterator = new SlicedIterator($tokens);
90
91			$this->stack->push($current = $this->root($rule));
92
93			while ($iterator->valid()) {
94			$this->text .= $iterator->current()->value() . ' ';
95
96			$this->reduce($iterator->current(), $iterator);
97			$iterator->next();
98			}
99
100			$this->complete();
101			}
102
103			return $this->parsed;
104			}
105
106			/**
107			* @param string $rule
108			* @return bool
109			*/
110			private function isCompleted(string $rule): bool
111			{
112			return \array_key_exists($rule, $this->parsed);
113			}
114
115			/**
116			* @param Builder $builder
117			* @return RulesBuilder
118			*/
119			private function add(Builder $builder): RulesBuilder
120			{
121			$this->current()->jump($builder->getId());
122			$this->stack->push($builder);
123
124			return $this;
125			}
126
127			/**
128			* @param string $rule
129			* @return ConcatenationBuilder
130			*/
131			private function root(string $rule): ConcatenationBuilder
132			{
133			return new ConcatenationBuilder($this->getId($rule), $this->isKept($rule) ? $rule : null);
134			}
135
136			/**
137			* @param string $rule
138			* @return int
139			*/
140			private function getId(string $rule = null): int
141			{
142			if ($rule === null) {
143			return $this->lastRuleId++;
144			}
145
146			if (\array_key_exists($rule, $this->mappings)) {
147			return $this->mappings[$rule];
148			}
149
150			return $this->mappings[$rule] = $this->lastRuleId++;
151			}
152
153			/**
154			* @param string $rule
155			* @return bool
156			*/
157			private function isKept(string $rule): bool
158			{
159			return \in_array($rule, $this->resolver->getKeep(), true);
160			}
161
162			/**
163			* @param TokenInterface $token
164			* @param SlicedIterator $tokens
165			* @return int
166			*/
167			private function reduce(TokenInterface $token, SlicedIterator $tokens): int
			0 ignored issues – show Unused Code introduced 2018-06-19 19:17 UTC by Report Bug Copy Issue Report The parameter `$tokens` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
168			{
169			switch ($token->name()) {
170			case Lexer::T_KEPT:
171			return $this->reduceToken($token, true);
172
173			case Lexer::T_SKIPPED:
174			return $this->reduceToken($token, false);
175
176			//default:
177			// $error = \sprintf('Unexpected token %s', $token);
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-06-19 19:17 UTC by Report Bug Copy Issue Report `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
178			// throw (new GrammarException($error))->throwsIn($this->file, $token->offset());
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-06-19 19:17 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
179			}
180
181			return 0;
182			}
183
184			/**
185			* @param TokenInterface $token
186			* @param bool $keep
187			* @return int
188			*/
189			private function reduceToken(TokenInterface $token, bool $keep): int
190			{
191			$key = $token->value(1) . ':' . $token->name();
192
193			$builder = new TokenBuilder($this->getId($key), $token->value(1), $keep);
194
195			$this->add($builder)->complete();
196
197			return $builder->getId();
198			}
199
200			private function reduceConcat(SlicedIterator $iterator)
			0 ignored issues – show Unused Code introduced 2018-06-19 19:17 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
201			{
202			dd($iterator);
203			}
204
205			/**
206			* @return RulesBuilder
207			*/
208			private function complete(): RulesBuilder
209			{
210			/** @var Builder $rule */
211			$rule = $this->stack->pop();
212			$instance = $rule->build();
213
214			if ($rule->getName()) {
			0 ignored issues – show Bug Best Practice introduced 2018-06-19 19:17 UTC by Report Bug Copy Issue Report The expression `$rule->getName()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
215			$this->parsed[$rule->getName()] = $instance;
216			} else {
217			$this->parsed[] = $instance;
218			}
219
220			$instance->{'--grammar--'} = $this->text;
221			$this->text = '';
222
223			return $this;
224			}
225
226			/**
227			* @return Builder
228			*/
229			private function current(): Builder
230			{
231			return $this->stack->top();
232			}
233			}
234

railt / compiler

Push — master ( 88ff28...2dc58f )

RulesBuilder::build() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like