CarbonController - Code Metrics - railt/carbon-extension - Measure and Improve Code Quality continuously with Scrutinizer

CarbonController A
last analyzed 2018-06-04 17:57 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	10
lcom	0
cbo	3
dl	0
loc	50
ccs	0
cts	29
cp	0
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	getValue()	0	20	7
A	getDateTime()	0	14	3

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\CarbonExtension;

use Carbon\Carbon;
use Railt\CarbonExtension\Exception\InvalidDateTimeFormat;
use Railt\CarbonExtension\In\CarbonFormat;
use Railt\Http\InputInterface;

/**
 * Class CarbonController
 */
class CarbonController
{
    /**
     * @param InputInterface $input
     * @return Carbon|null
     * @throws InvalidDateTimeFormat
     * @throws \InvalidArgumentException
     */
    private function getValue(InputInterface $input): ?Carbon
    {
        $value = $input->getParentResponse()[$input->getFieldName()] ?? null;

        switch (true) {
            case $value === null:
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                return null;
            case $value instanceof Carbon:
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                return $value;
            case $value instanceof \DateTimeInterface:
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                return Carbon::instance($value);
            case \is_string($value):
                return Carbon::parse($value);
            case \is_int($value) || \is_float($value):
                return Carbon::createFromTimestamp((int)$value);
        }

        $error = 'Response type of field %f should be a DateTime, string or int, but %s given';
        throw new InvalidDateTimeFormat(\sprintf($error, $input->getFieldDefinition(), \gettype($value)));
    }

    /**
     * @param InputInterface $input
     * @param string $format
     * @return string|null
     * @throws \InvalidArgumentException
     */
    public function getDateTime(InputInterface $input, string $format): ?string
    {
        $value = $this->getValue($input);

        if ($value === null) {
            return null;
        }

        if ($format === CarbonFormat::HUMAN_READABLE) {
            return $value->diffForHumans();
        }

        return $value->format($format);
    }
}


1			<?php
2			/**
3			* This file is part of Railt package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Railt\CarbonExtension;
11
12			use Carbon\Carbon;
13			use Railt\CarbonExtension\Exception\InvalidDateTimeFormat;
14			use Railt\CarbonExtension\In\CarbonFormat;
15			use Railt\Http\InputInterface;
16
17			/**
18			* Class CarbonController
19			*/
20			class CarbonController
21			{
22			/**
23			* @param InputInterface $input
24			* @return Carbon\|null
25			* @throws InvalidDateTimeFormat
26			* @throws \InvalidArgumentException
27			*/
28			private function getValue(InputInterface $input): ?Carbon
29			{
30			$value = $input->getParentResponse()[$input->getFieldName()] ?? null;
31
32			switch (true) {
33			case $value === null:
			0 ignored issues – show Coding Style introduced 2018-04-29 18:36 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
34			return null;
35			case $value instanceof Carbon:
			0 ignored issues – show Coding Style introduced 2018-04-29 18:36 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
36			return $value;
37			case $value instanceof \DateTimeInterface:
			0 ignored issues – show Coding Style introduced 2018-04-29 18:36 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
38			return Carbon::instance($value);
39			case \is_string($value):
40			return Carbon::parse($value);
41			case \is_int($value) \|\| \is_float($value):
42			return Carbon::createFromTimestamp((int)$value);
43			}
44
45			$error = 'Response type of field %f should be a DateTime, string or int, but %s given';
46			throw new InvalidDateTimeFormat(\sprintf($error, $input->getFieldDefinition(), \gettype($value)));
47			}
48
49			/**
50			* @param InputInterface $input
51			* @param string $format
52			* @return string\|null
53			* @throws \InvalidArgumentException
54			*/
55			public function getDateTime(InputInterface $input, string $format): ?string
56			{
57			$value = $this->getValue($input);
58
59			if ($value === null) {
60			return null;
61			}
62
63			if ($format === CarbonFormat::HUMAN_READABLE) {
64			return $value->diffForHumans();
65			}
66
67			return $value->format($format);
68			}
69			}
70

railt / carbon-extension

CarbonController A last analyzed 2018-06-04 17:57 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

CarbonController A
last analyzed 2018-06-04 17:57 UTC