Executor::makeBody() - Code Metrics - Inspection of "tests update" - raidros/storer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a2d810...65f8da )

by Juliano

created 2016-08-16 17:50 UTC

Executor::makeBody() A

↳ Parent: Executor

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
c	3
b	1
f	0
dl	0
loc	14
ccs	8
cts	8
cp	1
rs	9.4285
cc	2
eloc	9
nc	2
nop	2
crap	2

<?php

namespace Raidros\Storer;

use GuzzleHttp\Client;

class Executor
{
    protected $api;
    protected $endpoint;

    /**
     * Setup a api endpoint execution.
     *
     * @param Raidros\Storer\Api $api
     */
    public function __construct(Api $api)
    {
        $this->api = $api;
    }

    /**
     * call a api endpoint.
     *
     * @param string $pointName
     * @param array  $data
     * @param array  $headers
     *
     * @return Raidros\Storer\Response
     */
    public function run($pointName, array $data = [], array $headers = [])
    {
        $this->endpoint = $this->api->getEndpoints()->findOrFail($pointName);

        $client = new Client($this->api->getHandler());
        $response = $client->request($this->endpoint->getMethod(), $this->endpoint->getUri(), $this->makeBody($headers, $data));

        return new Response($response, $this->endpoint->getTransformer());

    }

    /**
     * make the request body.
     *
     * @param array $pointHeaders
     * @param array $data
     *
     * @return array
     */
    protected function makeBody($pointHeaders, $data)
    {
        $apiHeaders = array_map(function ($value) {
            return $value->get();
        }, $this->api->getHeaders()->get());

        $dataChain = $this->endpoint->getMethod() == 'GET' ? 'query' : 'json';
        $body = array_merge($apiHeaders, $pointHeaders);
        $body[$dataChain] = $data;

        $request = new Request($body, $this->endpoint->getTransformer('request'), $dataChain);


        return $request->getBody($dataChain);
    }
}


1		<?php
2
3		namespace Raidros\Storer;
4
5		use GuzzleHttp\Client;
6
7		class Executor
8		{
9		protected $api;
10		protected $endpoint;
11
12		/**
13		* Setup a api endpoint execution.
14		*
15		* @param Raidros\Storer\Api $api
16		*/
17	12	public function __construct(Api $api)
18		{
19	12	$this->api = $api;
20	12	}
21
22		/**
23		* call a api endpoint.
24		*
25		* @param string $pointName
26		* @param array $data
27		* @param array $headers
28		*
29		* @return Raidros\Storer\Response
30		*/
31	12	public function run($pointName, array $data = [], array $headers = [])
32		{
33	12	$this->endpoint = $this->api->getEndpoints()->findOrFail($pointName);
34
35	12	$client = new Client($this->api->getHandler());
36	12	$response = $client->request($this->endpoint->getMethod(), $this->endpoint->getUri(), $this->makeBody($headers, $data));
37
38	12	return new Response($response, $this->endpoint->getTransformer());
		0 ignored issues – show Compatibility introduced 2016-08-16 12:54 UTC by Report Bug Copy Issue Report `$response` of type `object<Psr\Http\Message\ResponseInterface>` is not a sub-type of `object<GuzzleHttp\Psr7\Response>`. It seems like you assume a concrete implementation of the interface `Psr\Http\Message\ResponseInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
39		}
40
41		/**
42		* make the request body.
43		*
44		* @param array $pointHeaders
45		* @param array $data
46		*
47		* @return array
48		*/
49		protected function makeBody($pointHeaders, $data)
50		{
51	12	$apiHeaders = array_map(function ($value) {
52	12	return $value->get();
53	12	}, $this->api->getHeaders()->get());
54
55	12	$dataChain = $this->endpoint->getMethod() == 'GET' ? 'query' : 'json';
56	12	$body = array_merge($apiHeaders, $pointHeaders);
57	12	$body[$dataChain] = $data;
58
59	12	$request = new Request($body, $this->endpoint->getTransformer('request'), $dataChain);
		0 ignored issues – show Unused Code introduced 2016-08-16 12:54 UTC by Report Bug Copy Issue Report The call to `Request::__construct()` has too many arguments starting with `$dataChain`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
60
61	12	return $request->getBody($dataChain);
62		}
63		}
64

raidros / storer

Push — master ( a2d810...65f8da )

Executor::makeBody() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like