Raidros\Storer\Executor

Complexity

Total Complexity

4

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes	9
Bugs	5	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	run()	0	12	1
A	makeBody()	0	15	2

<?php

namespace Raidros\Storer;

use GuzzleHttp\Client;

class Executor
{
    protected $api;
    protected $endpoint;

    /**
     * Setup a api endpoint execution.
     *
     * @param Raidros\Storer\Api $api
     */
    public function __construct(Api $api)
    {
        $this->api = $api;
    }

    /**
     * call a api endpoint.
     *
     * @param string $pointName
     * @param array  $data
     * @param array  $headers
     *
     * @return Raidros\Storer\Response
     */
    public function run($pointName, array $data = [], array $headers = [])
    {
        $this->endpoint = $this->api->getEndpoints()->findOrFail($pointName);

        $client = new Client($this->api->getHandler());
        $method = $this->endpoint->getMethod();
        $uri = $this->endpoint->getUri($data);
        $body = $this->makeBody($headers, $data);
        $response = $client->request($method, $uri, $body);

        return new Response($response, $this->endpoint->getTransformer());

$response of type object<Psr\Http\Message\ResponseInterface> is not a sub-type of object<GuzzleHttp\Psr7\Response>. It seems like you assume a concrete implementation of the interface Psr\Http\Message\ResponseInterface to be always present.

    }

    /**
     * make the request body.
     *
     * @param array $pointHeaders
     * @param array $data
     *
     * @return array
     */
    protected function makeBody($pointHeaders, $data)
    {
        unset($data['uriData']);
        $apiHeaders = array_map(function ($value) {
            return $value->get();
        }, $this->api->getHeaders()->get());

        $dataChain = $this->endpoint->getMethod() == 'GET' ? 'query' : 'json';
        $body = array_merge($apiHeaders, $pointHeaders);
        $body[$dataChain] = $data;

        $request = new Request($body, $this->endpoint->getTransformer('request'), $dataChain);

The call to Request::__construct() has too many arguments starting with $dataChain.

        return $request->getBody($dataChain);
    }
}