rafflesargentina / l5-resource-controller

tests/BaseTest.php

<?php

namespace RafflesArgentina\ResourceController;

trait BaseTest
{
    /**
     * Setup the test environment.
     */
    public function setUp()
    {
        parent::setUp();

        gc_disable();

        $this->loadMigrationsFrom(__DIR__.'/database/migrations');

It seems like loadMigrationsFrom() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->withFactories(__DIR__.'/factories');

It seems like withFactories() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        \Route::group(
            [
            'middleware' => [],
            'namespace'  => 'RafflesArgentina\ResourceController',
            ], function ($router) {
                $router->resource('test', 'TestController');
                $router->resource('test2', 'TestUseSoftDeletesController');
                $router->resource('test3', 'ApiTestController');
                $router->resource('test4', 'ApiTestUseSoftDeletesController');
            }
        );

        \View::addLocation(__DIR__.'/Resources/Views');
    }

    /**
     * Define environment setup.
     *
     * @param  \Illuminate\Foundation\Application $app
     * @return void
     */
    protected function getEnvironmentSetUp($app)
    {
        // Setup default database to use sqlite :memory:
        $app['config']->set('database.default', 'testbench');
        $app['config']->set(
            'database.connections.testbench', [
            'driver'   => 'sqlite',
            'database' => ':memory:',
            'prefix'   => '',
            ]
        );
    }

    /**
     * Get package providers.  At a minimum this is the package being tested, but also
     * would include packages upon which our package depends, e.g. Cartalyst/Sentry
     * In a normal app environment these would be added to the 'providers' array in
     * the config/app.php file.
     *
     * @param \Illuminate\Foundation\Application $app
     *
     * @return array
     */
    protected function getPackageProviders($app)

The parameter $app is not used and could be removed.

    {
        return [
            // your package service provider,
            \Orchestra\Database\ConsoleServiceProvider::class,
        ];
    }

    /**
     * Get package aliases.  In a normal app environment these would be added to
     * the 'aliases' array in the config/app.php file.  If your package exposes an
     * aliased facade, you should add the alias here, along with aliases for
     * facades upon which your package depends, e.g. Cartalyst/Sentry.
     *
     * @param \Illuminate\Foundation\Application $app
     *
     * @return array
     */
    protected function getPackageAliases($app)

The parameter $app is not used and could be removed.

    {
        return [
            //
        ];
    }
}