FieldTest - Code Metrics - Inspection of "Field value type tests made less lame" - radowoj/yaah - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (804000)

by Radosław

created 2017-03-03 20:11 UTC

FieldTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	113
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	8
lcom	1
cbo	2
dl	0
loc	113
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Size	Complexity
A	testNonIntegerFid()	4	1
B	testReturnedArray()	27	1
A	valueTypesProvider()	9	1
A	testValueTypes()	7	1
A	testDatetimeValue()	8	1
A	testExceptionOnInvalidValue()	4	1
A	testExceptionOnInvalidForcedValue()	4	1
A	testFid()	5	1

<?php

use PHPUnit\Framework\TestCase;
use Radowoj\Yaah\Field;

class FieldTest extends TestCase
namespace YourVendor;

class YourClass { }
{
    /**
     * @expectedException Radowoj\Yaah\Exception
     * @expectedExceptionMessage fid must be an integer
     */
    public function testNonIntegerFid()
    {
        new Field('some string');
    }


    /**
     * Tests that output of Field->toArray() has the exact keys expected by WebAPI
     * @return void
     */
    public function testReturnedArray()
    {
        $field = new Field(1, 'some string');

        $this->assertEquals([
            'fid' => 1,
            'fvalueString' => 'some string',
            'fvalueInt' => 0,
            'fvalueFloat' => 0,
            'fvalueImage' => '',
            'fvalueDatetime' => 0,
            'fvalueDate' => '',
            'fvalueRangeInt' => [
                'fvalueRangeIntMin' => 0,
                'fvalueRangeIntMax' => 0,
            ],
            'fvalueRangeFloat' => [
                'fvalueRangeFloatMin' => 0,
                'fvalueRangeFloatMax' => 0,
            ],
            'fvalueRangeDate' => [
                'fvalueRangeDateMin' => '',
                'fvalueRangeDateMax' => '',
            ],

        ], $field->toArray());
    }


    public function valueTypesProvider()
    {
        return [
            'string' => ['some string', 'fvalueString'],
            'integer' => [42, 'fvalueInt'],
            'float' => [13.5, 'fvalueFloat'],
            'date' => ['01-03-2017', 'fvalueDate'],
        ];
    }


    /**
     * Test if various value types are properly handled
     * @dataProvider valueTypesProvider
     */
    public function testValueTypes($testValue, $arrayKey)
    {
        $field = new Field(1, $testValue);
        $this->assertArrayHasKey($arrayKey, $field->toArray());
        $this->assertSame($field->toArray()[$arrayKey], $testValue);
        $this->assertSame($field->getValue(), $testValue);
    }


    /**
     * Test forced value type - datetime
     * @return void
     */
    public function testDatetimeValue()
    {
        $datetime = time();
        $field = new Field(1, $datetime, 'fvalueDatetime');
        $this->assertArrayHasKey('fvalueDatetime', $field->toArray());
        $this->assertSame($field->toArray()['fvalueDatetime'], $datetime);
        $this->assertSame($field->getValue(), $datetime);
    }

    /**
     * @expectedException Radowoj\Yaah\Exception
     * @expectedExceptionMessage Not supported value type: object; fid=1
     */
    public function testExceptionOnInvalidValue()
    {
        $field = new Field(1, (object)['foo' => 'bar']);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }


    /**
     * @expectedException Radowoj\Yaah\Exception
     * @expectedExceptionMessage Class Radowoj\Yaah\Field does not have property: fvalueUnicorn
     */
    public function testExceptionOnInvalidForcedValue()
    {
        $field = new Field(1, 'something', 'fvalueUnicorn');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }


    /**
     * Test fid value
     * @return void
     */
    public function testFid()
    {
        $field = new Field(42, 'don\'t panic!');
        $this->assertSame($field->getFid(), 42);
    }

}


1			<?php
2
3			use PHPUnit\Framework\TestCase;
4			use Radowoj\Yaah\Field;
5
6			class FieldTest extends TestCase
			0 ignored issues – show Coding Style Compatibility introduced 2017-02-28 20:53 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8			/**
9			* @expectedException Radowoj\Yaah\Exception
10			* @expectedExceptionMessage fid must be an integer
11			*/
12			public function testNonIntegerFid()
13			{
14			new Field('some string');
15			}
16
17
18			/**
19			* Tests that output of Field->toArray() has the exact keys expected by WebAPI
20			* @return void
21			*/
22			public function testReturnedArray()
23			{
24			$field = new Field(1, 'some string');
25
26			$this->assertEquals([
27			'fid' => 1,
28			'fvalueString' => 'some string',
29			'fvalueInt' => 0,
30			'fvalueFloat' => 0,
31			'fvalueImage' => '',
32			'fvalueDatetime' => 0,
33			'fvalueDate' => '',
34			'fvalueRangeInt' => [
35			'fvalueRangeIntMin' => 0,
36			'fvalueRangeIntMax' => 0,
37			],
38			'fvalueRangeFloat' => [
39			'fvalueRangeFloatMin' => 0,
40			'fvalueRangeFloatMax' => 0,
41			],
42			'fvalueRangeDate' => [
43			'fvalueRangeDateMin' => '',
44			'fvalueRangeDateMax' => '',
45			],
46
47			], $field->toArray());
48			}
49
50
51			public function valueTypesProvider()
52			{
53			return [
54			'string' => ['some string', 'fvalueString'],
55			'integer' => [42, 'fvalueInt'],
56			'float' => [13.5, 'fvalueFloat'],
57			'date' => ['01-03-2017', 'fvalueDate'],
58			];
59			}
60
61
62			/**
63			* Test if various value types are properly handled
64			* @dataProvider valueTypesProvider
65			*/
66			public function testValueTypes($testValue, $arrayKey)
67			{
68			$field = new Field(1, $testValue);
69			$this->assertArrayHasKey($arrayKey, $field->toArray());
70			$this->assertSame($field->toArray()[$arrayKey], $testValue);
71			$this->assertSame($field->getValue(), $testValue);
72			}
73
74
75			/**
76			* Test forced value type - datetime
77			* @return void
78			*/
79			public function testDatetimeValue()
80			{
81			$datetime = time();
82			$field = new Field(1, $datetime, 'fvalueDatetime');
83			$this->assertArrayHasKey('fvalueDatetime', $field->toArray());
84			$this->assertSame($field->toArray()['fvalueDatetime'], $datetime);
85			$this->assertSame($field->getValue(), $datetime);
86			}
87
88			/**
89			* @expectedException Radowoj\Yaah\Exception
90			* @expectedExceptionMessage Not supported value type: object; fid=1
91			*/
92			public function testExceptionOnInvalidValue()
93			{
94			$field = new Field(1, (object)['foo' => 'bar']);
			0 ignored issues – show Unused Code introduced 2017-03-02 19:47 UTC by Report Bug Copy Issue Report `$field` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
95			}
96
97
98			/**
99			* @expectedException Radowoj\Yaah\Exception
100			* @expectedExceptionMessage Class Radowoj\Yaah\Field does not have property: fvalueUnicorn
101			*/
102			public function testExceptionOnInvalidForcedValue()
103			{
104			$field = new Field(1, 'something', 'fvalueUnicorn');
			0 ignored issues – show Unused Code introduced 2017-03-02 19:47 UTC by Report Bug Copy Issue Report `$field` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
105			}
106
107
108			/**
109			* Test fid value
110			* @return void
111			*/
112			public function testFid()
113			{
114			$field = new Field(42, 'don\'t panic!');
115			$this->assertSame($field->getFid(), 42);
116			}
117
118			}
119

radowoj / yaah

Branch — master (804000)

FieldTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Duplication Side-by-Side

Filter issues like