Auction::addPhotoFields() - Code Metrics - Inspection of "Some more unit tests" - radowoj/yaah - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a5c74c...eed2cc )

by Radosław

created 2017-03-02 19:45 UTC

Auction::addPhotoFields() A

↳ Parent: Auction

Complexity

Conditions	4
Paths	4

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	0
cts	12
cp	0
rs	9.2
c	0
b	0
f	0
cc	4
eloc	10
nc	4
nop	1
crap	20

<?php

namespace Radowoj\Yaah;

use Radowoj\Yaah\Constants\AuctionFids;

class Auction
{
    const MAX_PHOTOS = 8;

    protected $fields = [];

    protected $photos = [];

    public function __construct(array $fields = [])
    {
        $this->fields = $fields;
    }


    public function setPhotos(array $photos)
    {
        $photosCount = count($photos);

        if ($photosCount > self::MAX_PHOTOS) {
            throw new Exception("Photo files limit exceeded, " . self::MAX_PHOTOS . " allowed, " . $photosCount . " given");
        }

        $this->photos = $photos;
    }


    public function toApiRepresentation()
    {
        $fields = [];

        foreach($this->fields as $fid => $value) {
            $fields[] = (new Field($fid, $value))->toArray();
        }

        $this->addPhotoFields($fields);

        return [
            'fields' => $fields,
        ];
    }


    public function fromApiRepresentation(array $fields)
    {
        $this->fields = [];
        $this->photos = [];

        foreach($fields as $apiField) {
            $field = new Field(0, '');
            $field->fromArray((array)$apiField);
            $this->fields[$field->getFid()] = $field->getValue();
        }
    }


    protected function addPhotoFields(array& $fields)
    {
        $count = count($this->photos);
        if (!$count) {
            return;
        }

        $index = 0;
        foreach ($this->photos as $photo) {
            if (!is_readable($photo)) {
                throw new Exception("Photo file {$photo} is not readable");
            }

            $fields[] = (new Field(AuctionFids::FID_PHOTO + $index, file_get_contents($photo), Field::VALUE_IMAGE))->toArray();
            $index++;
        }
    }

}


1			<?php
2
3			namespace Radowoj\Yaah;
4
5			use Radowoj\Yaah\Constants\AuctionFids;
6
7			class Auction
8			{
9			const MAX_PHOTOS = 8;
10
11			protected $fields = [];
12
13			protected $photos = [];
14
15			public function __construct(array $fields = [])
16			{
17			$this->fields = $fields;
18			}
19
20
21			public function setPhotos(array $photos)
22			{
23			$photosCount = count($photos);
24
25			if ($photosCount > self::MAX_PHOTOS) {
26			throw new Exception("Photo files limit exceeded, " . self::MAX_PHOTOS . " allowed, " . $photosCount . " given");
27			}
28
29			$this->photos = $photos;
30			}
31
32
33			public function toApiRepresentation()
34			{
35			$fields = [];
36
37			foreach($this->fields as $fid => $value) {
38			$fields[] = (new Field($fid, $value))->toArray();
39			}
40
41			$this->addPhotoFields($fields);
42
43			return [
44			'fields' => $fields,
45			];
46			}
47
48
49			public function fromApiRepresentation(array $fields)
50			{
51			$this->fields = [];
52			$this->photos = [];
53
54			foreach($fields as $apiField) {
55			$field = new Field(0, '');
56			$field->fromArray((array)$apiField);
57			$this->fields[$field->getFid()] = $field->getValue();
58			}
59			}
60
61
62			protected function addPhotoFields(array& $fields)
63			{
64			$count = count($this->photos);
65			if (!$count) {
66			return;
67			}
68
69			$index = 0;
70			foreach ($this->photos as $photo) {
71			if (!is_readable($photo)) {
72			throw new Exception("Photo file {$photo} is not readable");
73			}
74
75			$fields[] = (new Field(AuctionFids::FID_PHOTO + $index, file_get_contents($photo), Field::VALUE_IMAGE))->toArray();
76			$index++;
77			}
78			}
79
80			}
81

radowoj / yaah

Push — master ( a5c74c...eed2cc )

Auction::addPhotoFields() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like