Link::__construct() - Code Metrics - Inspection of "Refactoring + some unit tests" - radowoj/crawla - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#3)

by Radosław

created 2018-11-15 14:38 UTC

Link::__construct() A

↳ Parent: Link

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	3
nop	2
dl	0
loc	11
ccs	7
cts	7
cp	1
crap	3
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Radowoj\Crawla\Link;

use Radowoj\Crawla\Exception\InvalidUrlException;

class Link
{
    /**
     * @var string
     */
    private $url;

    /**
     * @var int
     */
    private $depth;

    /**
     * Link constructor.
     *
     * @param string $url
     * @param int    $depth
     */
    public function __construct(string $url, int $depth = 0)
    {
        if (!filter_var($url, FILTER_VALIDATE_URL)) {
            throw new InvalidUrlException("Provided URL is invalid: {$url}");
        }

        if ($depth < 0) {
            throw new \InvalidArgumentException('Provided depth must be non negative');
        }
        $this->url = $url;
        $this->depth = $depth;
    }

    /**
     * @return string
     */
    public function getUrl(): string
    {
        return $this->url;
    }

    /**
     * @return int
     */
    public function getDepth(): int
    {
        return $this->depth;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Radowoj\Crawla\Link;
6
7		use Radowoj\Crawla\Exception\InvalidUrlException;
8
9		class Link
10		{
11		/**
12		* @var string
13		*/
14		private $url;
15
16		/**
17		* @var int
18		*/
19		private $depth;
20
21		/**
22		* Link constructor.
23		*
24		* @param string $url
25		* @param int $depth
26		*/
27	9	public function __construct(string $url, int $depth = 0)
28		{
29	9	if (!filter_var($url, FILTER_VALIDATE_URL)) {
30	1	throw new InvalidUrlException("Provided URL is invalid: {$url}");
31		}
32
33	8	if ($depth < 0) {
34	1	throw new \InvalidArgumentException('Provided depth must be non negative');
35		}
36	7	$this->url = $url;
37	7	$this->depth = $depth;
38	7	}
39
40		/**
41		* @return string
42		*/
43	7	public function getUrl(): string
44		{
45	7	return $this->url;
46		}
47
48		/**
49		* @return int
50		*/
51	7	public function getDepth(): int
52		{
53	7	return $this->depth;
54		}
55		}
56

radowoj / crawla

Pull Request — master (#3)

Link::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like