Passed
Push — master ( 243c10...a54c21 )
by Quim González
02:51
created
app/Http/Requests/DestroyUser.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,9 @@
 block discarded – undo
15 15
      */
16 16
     public function authorize()
17 17
     {
18
-        if ($this->hasPermissionTo('destroy-users')) return true;
18
+        if ($this->hasPermissionTo('destroy-users')) {
19
+            return true;
20
+        }
19 21
         return false;
20 22
     }
21 23
 
Please login to merge, or discard this patch.
app/Http/Requests/ShowUser.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,9 @@
 block discarded – undo
15 15
      */
16 16
     public function authorize()
17 17
     {
18
-        if ($this->hasPermissionTo('show-users')) return true;
18
+        if ($this->hasPermissionTo('show-users')) {
19
+            return true;
20
+        }
19 21
         return false;
20 22
     }
21 23
 
Please login to merge, or discard this patch.
app/Http/Requests/StoreUser.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,9 @@
 block discarded – undo
15 15
      */
16 16
     public function authorize()
17 17
     {
18
-        if ($this->hasPermissionTo('store-users')) return true;
18
+        if ($this->hasPermissionTo('store-users')) {
19
+            return true;
20
+        }
19 21
         return false;
20 22
     }
21 23
 
Please login to merge, or discard this patch.
app/helpers.php 2 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -49,11 +49,11 @@
 block discarded – undo
49 49
 
50 50
         $role = Role::firstOrCreate(['name' => 'users-manager']);
51 51
 
52
-       assignPermission($role,'list-users');
53
-       assignPermission($role,'show-users');
54
-       assignPermission($role,'store-users');
55
-       assignPermission($role,'update-users');
56
-       assignPermission($role,'destroy-users');
52
+        assignPermission($role,'list-users');
53
+        assignPermission($role,'show-users');
54
+        assignPermission($role,'store-users');
55
+        assignPermission($role,'update-users');
56
+        assignPermission($role,'destroy-users');
57 57
 
58 58
     }
59 59
 }
Please login to merge, or discard this patch.
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -8,21 +8,21 @@  discard block
 block discarded – undo
8 8
 //funció creada per veure si el rol ja te assignat un permís, si el te no fem res, sino li assignem.
9 9
 // si no es fa així provoca error:
10 10
 //Illuminate\Database\QueryException with message 'SQLSTATE[23000]: Integrity constraint violation: 19 UNIQUE constraint failed: role_has_permissions.permission_id, role_has_permissions.role_id (SQL: insert into "role_has_permissions" ("permission_id", "role_id") values (1, 1))'
11
-if(!function_exists('assignPermission')){
11
+if ( ! function_exists('assignPermission')) {
12 12
 
13 13
     /**
14 14
      * @param $role
15 15
      * @param $permission
16 16
      */
17
-    function assignPermission($role, $permission){
17
+    function assignPermission($role, $permission) {
18 18
 
19
-        if(! $role->hasPermissionTo($permission)){
19
+        if ( ! $role->hasPermissionTo($permission)) {
20 20
             $role->givePermissionTo($permission);
21 21
         }
22 22
     }
23 23
 }
24 24
 
25
-if (!function_exists('initialize_task_permissions')) {
25
+if ( ! function_exists('initialize_task_permissions')) {
26 26
     function initialize_task_permissions()
27 27
     {
28 28
 
@@ -35,11 +35,11 @@  discard block
 block discarded – undo
35 35
 
36 36
         $role = Role::firstOrCreate(['name'=>'task-manager']);
37 37
 
38
-        assignPermission($role,'list-tasks');
39
-        assignPermission($role,'show-tasks');
40
-        assignPermission($role,'store-tasks');
41
-        assignPermission($role,'update-tasks');
42
-        assignPermission($role,'destroy-tasks');
38
+        assignPermission($role, 'list-tasks');
39
+        assignPermission($role, 'show-tasks');
40
+        assignPermission($role, 'store-tasks');
41
+        assignPermission($role, 'update-tasks');
42
+        assignPermission($role, 'destroy-tasks');
43 43
 
44 44
         Permission::firstOrCreate(['name' => 'list-users']);
45 45
         Permission::firstOrCreate(['name' => 'show-users']);
@@ -49,17 +49,17 @@  discard block
 block discarded – undo
49 49
 
50 50
         $role = Role::firstOrCreate(['name' => 'users-manager']);
51 51
 
52
-       assignPermission($role,'list-users');
53
-       assignPermission($role,'show-users');
54
-       assignPermission($role,'store-users');
55
-       assignPermission($role,'update-users');
56
-       assignPermission($role,'destroy-users');
52
+       assignPermission($role, 'list-users');
53
+       assignPermission($role, 'show-users');
54
+       assignPermission($role, 'store-users');
55
+       assignPermission($role, 'update-users');
56
+       assignPermission($role, 'destroy-users');
57 57
 
58 58
     }
59 59
 }
60 60
 
61 61
 
62
-if (!function_exists('create_user')) {
62
+if ( ! function_exists('create_user')) {
63 63
     function create_user()
64 64
     {
65 65
         factory(User::class)->create([
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
     }
71 71
 }
72 72
 
73
-if (!function_exists('first_user_as_task_manager')) {
73
+if ( ! function_exists('first_user_as_task_manager')) {
74 74
     function first_user_as_task_manager()
75 75
     {
76 76
         User::all()->first()->assignRole('task-manager');
Please login to merge, or discard this patch.
app/Http/Requests/Traits/ChecksPermissions.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,7 +19,9 @@  discard block
 block discarded – undo
19 19
      */
20 20
     protected function hasPermissionTo($permission)
21 21
     {
22
-        if (Auth::user()->hasPermissionTo($permission)) return true;
22
+        if (Auth::user()->hasPermissionTo($permission)) {
23
+            return true;
24
+        }
23 25
         return false;
24 26
     }
25 27
 
@@ -35,7 +37,9 @@  discard block
 block discarded – undo
35 37
     {
36 38
         //todo
37 39
 
38
-        if (Auth::user()->id == $this->$model->$field) return true;
40
+        if (Auth::user()->id == $this->$model->$field) {
41
+            return true;
42
+        }
39 43
         return false;
40 44
     }
41 45
 }
42 46
\ No newline at end of file
Please login to merge, or discard this patch.