App\Http\Controllers\ApiUserController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	update()	0	10	1
A	show()	0	3	1
A	store()	0	17	1
A	index()	0	3	1
A	destroy()	0	7	1

<?php

namespace App\Http\Controllers;

use App\Http\Requests\DestroyUser;
use App\Http\Requests\ListUser;
use App\Http\Requests\ShowUser;
use App\Http\Requests\StoreUser;
use App\Http\Requests\UpdateUser;
use App\User;
use Illuminate\Http\Request;

class ApiUserController extends Controller
{
    public function index(ListUser $request)

The parameter $request is not used and could be removed.

    {
        return User::all();
    }

    public function show(ShowUser $user)
    {
        return $user;
    }

    //La funció del request s'anomena injeccio de dependències.
    public function store(StoreUser $request)
    {
        $request->validate([

The call to Illuminate\Foundation\Http\FormRequest::validate() has too many arguments starting with array('name' => 'required|max:255', 'username' => 'sometimes|required|max:255|unique:users', 'email' => 'required|email|max:255|unique:users', 'password' => 'required|min:6').

           'name'     => 'required|max:255',
           'username' => 'sometimes|required|max:255|unique:users',
           'email'    => 'required|email|max:255|unique:users',
           'password' => 'required|min:6',
        ]);

        $user = User::create([
               'name'     => $request->name,
               'username' => $request->username,
               'email'    => $request->email,
               'password' => bcrypt($request->password),
            ]);

        return $user;
    }

    public function destroy(DestroyUser $user)
    {
        //el User $user és equivalent a $user = User::findOrFail($id)

        $user->delete();

The method delete() does not exist on App\Http\Requests\DestroyUser. Since you implemented __call, consider adding a @method annotation.

        return $user;
    }

    public function update(UpdateUser $request, User $user)
    {
        $request->validate([

The call to Illuminate\Foundation\Http\FormRequest::validate() has too many arguments starting with array('name' => 'required').

            'name' => 'required',
        ]);

        $user->name = $request->name;

The property name does not exist on App\User. Since you implemented __set, consider adding a @property annotation.

        $user->save();

        return $user;
    }
}