AcosTable::node() - Code Metrics - Inspection of "clear permissions cache after save" - quickapps/cms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0 ( b904ee...24f948 )

by Christopher

created 2016-02-29 22:42 UTC

AcosTable::node() C

↳ Parent: AcosTable

Complexity

Conditions	10
Paths	15

Size

Total Lines	73
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	73
rs	5.8564
cc	10
eloc	50
nc	15
nop	1

How to fix Long Method Complexity

<?php
/**
 * Licensed under The GPL-3.0 License
 * For full copyright and license information, please see the LICENSE.txt
 * Redistributions of files must retain the above copyright notice.
 *
 * @since    2.0.0
 * @author   Christopher Castro <[email protected]>
 * @link     http://www.quickappscms.org
 * @license  http://opensource.org/licenses/gpl-3.0.html GPL-3.0 License
 */
namespace User\Model\Table;

use Cake\Cache\Cache;
use Cake\Event\Event;
use Cake\ORM\Table;
use User\Model\Entity\Aco;

/**
 * Represents "acos" database table.
 *
 */
class AcosTable extends Table
{

    /**
     * Initialize a table instance. Called after the constructor.
     *
     * @param array $config Configuration options passed to the constructor
     * @return void
     */
    public function initialize(array $config)
    {
        $this->addBehavior('Tree');
        $this->belongsToMany('Roles', [
            'className' => 'User.Roles',
            'joinTable' => 'permissions',
            'propertyName' => 'roles',
        ]);

        // removes all permissions when a content is removed from the tree
        $this->hasMany('Permissions', [
            'className' => 'User.Permissions',
            'propertyName' => 'permissions',
            'dependent' => true,
        ]);
    }

    /**
     * We create a hash of "alias" property so we can perform
     * case sensitive SQL comparisons.
     *
     * @param \Cake\Event\Event $event The event that was triggered
     * @param \User\Model\Entity\Aco $aco ACO entity being saved
     * @return void
     */
    public function beforeSave(Event $event, Aco $aco)
    {
        if ($aco->isNew()) {
            $aco->set('alias_hash', md5($aco->alias));
        }
    }

    /**
     * Clear permissions cache after ACO save so new changes are applied.
     *
     * @param \Cake\Event\Event $event The event that was triggered
     * @param \User\Model\Entity\Aco $aco ACO entity that was saved
     * @return void
     */
    public function afterSave(Event $event, Aco $aco)
    {
        Cache::clear(false, 'permissions');
    }

    /**
     * Retrieves the ACO contents for the given ACO path.
     *
     * ### ACO path format:
     *
     * As a string describing a path:
     *
     *     PluginName/ControllerName/actionName
     *
     * Or an associative array which values describes a path, for instance:
     *
     * ```php
     * [
     *     'plugin' => YourPlugin,
     *     'prefix' => Admin,
     *     'controller' => Users,
     *     'action' => index,
     * ]
     * ```
     *
     * The above array is equivalent to: `PluginName/Admin/Users/index`
     *
     * @param string|array $ref ACO path as described above
     * @return \Cake\ORM\Query|bool False if not found or query result if found
     */
    public function node($ref)
    {
        $type = $this->alias();
        $table = $this->table();
        $path = [];

        if (is_array($ref)) {
            $path = implode('/', array_values(array_filter($ref)));
            $path = explode('/', $path);
        } elseif (is_string($ref)) {
            $path = explode('/', $ref);
        }

        if (empty($path)) {
            return false;
        }

        $start = $path[0];
        unset($path[0]);

        $queryData = [
            'conditions' => [
                "{$type}.lft" . ' <= ' . "{$type}0.lft",
                "{$type}.rght" . ' >= ' . "{$type}0.rght",
            ],
            'fields' => ['id', 'parent_id', 'alias'],
            'join' => [[
                    'table' => $table,
                    'alias' => "{$type}0",
                    'type' => 'INNER',
                    'conditions' => [
                        "{$type}0.alias_hash" => md5($start),
                        "{$type}0.plugin = {$type}.plugin",
                    ]
            ]],
            'order' => "{$type}.lft" . ' DESC'
        ];

        foreach ($path as $i => $alias) {
            $j = $i - 1;

            $queryData['join'][] = [
                'table' => $table,
                'alias' => "{$type}{$i}",
                'type' => 'INNER',
                'conditions' => [
                    "{$type}{$i}.lft" . ' > ' . "{$type}{$j}.lft",
                    "{$type}{$i}.rght" . ' < ' . "{$type}{$j}.rght",
                    "{$type}{$i}.alias_hash" => md5($alias),
                    "{$type}{$i}.plugin = {$type}{$i}.plugin",
                    "{$type}{$j}.id" . ' = ' . "{$type}{$i}.parent_id"
                ]
            ];

            $queryData['conditions'] = [
                'OR' => [
                    "{$type}.lft" . ' <= ' . "{$type}0.lft" . ' AND ' . "{$type}.rght" . ' >= ' . "{$type}0.rght",
                    "{$type}.lft" . ' <= ' . "{$type}{$i}.lft" . ' AND ' . "{$type}.rght" . ' >= ' . "{$type}{$i}.rght"
                ]
            ];
        }
        $query = $this->find('all', $queryData);
        $result = $query->toArray();
        $path = array_values($path);
        if (!isset($result[0]) ||
            (!empty($path) && $result[0]->alias !== $path[count($path) - 1]) ||
            (empty($path) && $result[0]->alias !== $start)
        ) {
            return false;
        }

        return $query;
    }
}


1			<?php
2			/**
3			* Licensed under The GPL-3.0 License
4			* For full copyright and license information, please see the LICENSE.txt
5			* Redistributions of files must retain the above copyright notice.
6			*
7			* @since 2.0.0
8			* @author Christopher Castro <[email protected]>
9			* @link http://www.quickappscms.org
10			* @license http://opensource.org/licenses/gpl-3.0.html GPL-3.0 License
11			*/
12			namespace User\Model\Table;
13
14			use Cake\Cache\Cache;
15			use Cake\Event\Event;
16			use Cake\ORM\Table;
17			use User\Model\Entity\Aco;
18
19			/**
20			* Represents "acos" database table.
21			*
22			*/
23			class AcosTable extends Table
24			{
25
26			/**
27			* Initialize a table instance. Called after the constructor.
28			*
29			* @param array $config Configuration options passed to the constructor
30			* @return void
31			*/
32			public function initialize(array $config)
33			{
34			$this->addBehavior('Tree');
35			$this->belongsToMany('Roles', [
36			'className' => 'User.Roles',
37			'joinTable' => 'permissions',
38			'propertyName' => 'roles',
39			]);
40
41			// removes all permissions when a content is removed from the tree
42			$this->hasMany('Permissions', [
43			'className' => 'User.Permissions',
44			'propertyName' => 'permissions',
45			'dependent' => true,
46			]);
47			}
48
49			/**
50			* We create a hash of "alias" property so we can perform
51			* case sensitive SQL comparisons.
52			*
53			* @param \Cake\Event\Event $event The event that was triggered
54			* @param \User\Model\Entity\Aco $aco ACO entity being saved
55			* @return void
56			*/
57			public function beforeSave(Event $event, Aco $aco)
58			{
59			if ($aco->isNew()) {
60			$aco->set('alias_hash', md5($aco->alias));
61			}
62			}
63
64			/**
65			* Clear permissions cache after ACO save so new changes are applied.
66			*
67			* @param \Cake\Event\Event $event The event that was triggered
68			* @param \User\Model\Entity\Aco $aco ACO entity that was saved
69			* @return void
70			*/
71			public function afterSave(Event $event, Aco $aco)
72			{
73			Cache::clear(false, 'permissions');
74			}
75
76			/**
77			* Retrieves the ACO contents for the given ACO path.
78			*
79			* ### ACO path format:
80			*
81			* As a string describing a path:
82			*
83			* PluginName/ControllerName/actionName
84			*
85			* Or an associative array which values describes a path, for instance:
86			*
87			* ```php
88			* [
89			* 'plugin' => YourPlugin,
90			* 'prefix' => Admin,
91			* 'controller' => Users,
92			* 'action' => index,
93			* ]
94			* ```
95			*
96			* The above array is equivalent to: `PluginName/Admin/Users/index`
97			*
98			* @param string\|array $ref ACO path as described above
99			* @return \Cake\ORM\Query\|bool False if not found or query result if found
100			*/
101			public function node($ref)
102			{
103			$type = $this->alias();
104			$table = $this->table();
105			$path = [];
106
107			if (is_array($ref)) {
108			$path = implode('/', array_values(array_filter($ref)));
109			$path = explode('/', $path);
110			} elseif (is_string($ref)) {
111			$path = explode('/', $ref);
112			}
113
114			if (empty($path)) {
115			return false;
116			}
117
118			$start = $path[0];
119			unset($path[0]);
120
121			$queryData = [
122			'conditions' => [
123			"{$type}.lft" . ' <= ' . "{$type}0.lft",
124			"{$type}.rght" . ' >= ' . "{$type}0.rght",
125			],
126			'fields' => ['id', 'parent_id', 'alias'],
127			'join' => [[
128			'table' => $table,
129			'alias' => "{$type}0",
130			'type' => 'INNER',
131			'conditions' => [
132			"{$type}0.alias_hash" => md5($start),
133			"{$type}0.plugin = {$type}.plugin",
134			]
135			]],
136			'order' => "{$type}.lft" . ' DESC'
137			];
138
139			foreach ($path as $i => $alias) {
140			$j = $i - 1;
141
142			$queryData['join'][] = [
143			'table' => $table,
144			'alias' => "{$type}{$i}",
145			'type' => 'INNER',
146			'conditions' => [
147			"{$type}{$i}.lft" . ' > ' . "{$type}{$j}.lft",
148			"{$type}{$i}.rght" . ' < ' . "{$type}{$j}.rght",
149			"{$type}{$i}.alias_hash" => md5($alias),
150			"{$type}{$i}.plugin = {$type}{$i}.plugin",
151			"{$type}{$j}.id" . ' = ' . "{$type}{$i}.parent_id"
152			]
153			];
154
155			$queryData['conditions'] = [
156			'OR' => [
157			"{$type}.lft" . ' <= ' . "{$type}0.lft" . ' AND ' . "{$type}.rght" . ' >= ' . "{$type}0.rght",
158			"{$type}.lft" . ' <= ' . "{$type}{$i}.lft" . ' AND ' . "{$type}.rght" . ' >= ' . "{$type}{$i}.rght"
159			]
160			];
161			}
162			$query = $this->find('all', $queryData);
163			$result = $query->toArray();
164			$path = array_values($path);
165			if (!isset($result[0]) \|\|
166			(!empty($path) && $result[0]->alias !== $path[count($path) - 1]) \|\|
167			(empty($path) && $result[0]->alias !== $start)
168			) {
169			return false;
170			}
171
172			return $query;
173			}
174			}
175

quickapps / cms

Push — 2.0 ( b904ee...24f948 )

AcosTable::node() C

Complexity

Size

Duplication

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like