CanBeFollowed::isFollowedBy() - Code Metrics - questocat/laravel-rally - Measure and Improve Code Quality continuously with Scrutinizer

CanBeFollowed::isFollowedBy() A
last analyzed 2018-05-26 15:23 UTC

↳ Parent: CanBeFollowed

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php

/*
 * This file is part of questocat/laravel-rally package.
 *
 * (c) questocat <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Questocat\Rally\Traits;

trait CanBeFollowed
{
    /**
     * Check if entity is followed by given entity.
     *
     * @param int|\Illuminate\Database\Eloquent\Model $follower
     *
     * @return bool
     */
    public function isFollowedBy($follower)
    {
        return $this->followers->contains($follower);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Returns the entity that followed this entity.
     *
     * @return \Illuminate\Database\Eloquent\Relations\MorphToMany
     */
    public function followers()
    {
        return $this->morphToMany(config('rally.follower_model'), config('rally.followable_prefix'), config('rally.followers_table'), config('rally.followable_prefix').'_id', config('rally.follower_prefix').'_id');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		/*
4		* This file is part of questocat/laravel-rally package.
5		*
6		* (c) questocat <[email protected]>
7		*
8		* This source file is subject to the MIT license that is bundled
9		* with this source code in the file LICENSE.
10		*/
11
12		namespace Questocat\Rally\Traits;
13
14		trait CanBeFollowed
15		{
16		/**
17		* Check if entity is followed by given entity.
18		*
19		* @param int\|\Illuminate\Database\Eloquent\Model $follower
20		*
21		* @return bool
22		*/
23		public function isFollowedBy($follower)
24		{
25		return $this->followers->contains($follower);
		0 ignored issues – show Bug introduced 2017-10-12 03:18 UTC by Report Bug Copy Issue Report The property `followers` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26		}
27
28		/**
29		* Returns the entity that followed this entity.
30		*
31		* @return \Illuminate\Database\Eloquent\Relations\MorphToMany
32		*/
33	1	public function followers()
34		{
35	1	return $this->morphToMany(config('rally.follower_model'), config('rally.followable_prefix'), config('rally.followers_table'), config('rally.followable_prefix').'_id', config('rally.follower_prefix').'_id');
		0 ignored issues – show Bug introduced 2017-10-12 03:18 UTC by Report Bug Copy Issue Report It seems like `morphToMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36		}
37		}
38

questocat / laravel-rally

CanBeFollowed::isFollowedBy() A last analyzed 2018-05-26 15:23 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

CanBeFollowed::isFollowedBy() A
last analyzed 2018-05-26 15:23 UTC