FieldTextarea::fill() - Code Metrics - qua-bla/form - Measure and Improve Code Quality continuously with Scrutinizer

FieldTextarea::fill() A
last analyzed 2016-10-13 09:50 UTC

↳ Parent: FieldTextarea

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	0

<?php

namespace hemio\form;

use hemio\html;

class FieldTextarea extends Abstract_\FormFieldDefault {

    public function __construct($name, $title) {
        $this->init($name, $title, new html\Textarea());
    }

    /**
     *
     * @return \hemio\form\Abstract_\TemplateFormField
     */
    public function fill() {
        $template = $this->getFieldTemplateClone('TEXTAREA');

        $this['_TEMPLATE'] = $template;
        $template->init($this, $this->control);
        $this->control->addChild(new html\Str($this->getValueToUse()));
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $this->filled = true;

        return $template;
    }

    public function describe() {
        return 'INPUT(TEXTAREA)';
    }

    /**
     *
     * @param boolean $required
     */
    public function setRequired($required = true) {
        $this->addValidityCheck(new CheckMinLength(1));
        $this->required = $required;
        $this->control->setAttribute('required', (boolean) $required);
    }

}


1			<?php
2
3			namespace hemio\form;
4
5			use hemio\html;
6
7			class FieldTextarea extends Abstract_\FormFieldDefault {
8
9			public function __construct($name, $title) {
10			$this->init($name, $title, new html\Textarea());
11			}
12
13			/**
14			*
15			* @return \hemio\form\Abstract_\TemplateFormField
16			*/
17			public function fill() {
18			$template = $this->getFieldTemplateClone('TEXTAREA');
19
20			$this['_TEMPLATE'] = $template;
21			$template->init($this, $this->control);
22			$this->control->addChild(new html\Str($this->getValueToUse()));
			0 ignored issues – show Bug introduced 2016-10-12 14:54 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `hemio\html\Interface_\Submittable` as the method `addChild()` does only exist in the following implementations of said interface: `hemio\html\Button`, `hemio\html\Keygen`, `hemio\html\Object`, `hemio\html\Select`, `hemio\html\Textarea`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
23
24			$this->filled = true;
25
26			return $template;
27			}
28
29			public function describe() {
30			return 'INPUT(TEXTAREA)';
31			}
32
33			/**
34			*
35			* @param boolean $required
36			*/
37			public function setRequired($required = true) {
38			$this->addValidityCheck(new CheckMinLength(1));
39			$this->required = $required;
40			$this->control->setAttribute('required', (boolean) $required);
41			}
42
43			}
44

qua-bla / form

FieldTextarea::fill() A last analyzed 2016-10-13 09:50 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

FieldTextarea::fill() A
last analyzed 2016-10-13 09:50 UTC