Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | View Code Duplication | class FieldPassword extends Abstract_\FormFieldInput { |
|
|
|||
6 | |||
7 | public function getInputType() { |
||
10 | |||
11 | // force the value atribute to null to prevent resending the password to clients |
||
12 | public function getValueStored() { |
||
15 | |||
16 | public function getValueToUse() { |
||
19 | |||
20 | /** |
||
21 | * |
||
22 | * @param boolean $required |
||
23 | */ |
||
24 | public function setRequired($required = true) { |
||
29 | |||
30 | } |
||
31 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.