Qrz_OneDayAdmin_Model_System_Config_Source_OneDayAdminRoles

Complexity

Total Complexity

5

Size/Duplication

Total Lines	52
Duplicated Lines	55.77 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	toOptionArray()	15	15	2
A	toArray()	14	14	2
A	getAdminRolesCollection()	0	4	1

<?php

class Qrz_OneDayAdmin_Model_System_Config_Source_OneDayAdminRoles

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * @return array
     * @author Cristian Quiroz <cris@qrz.io>
     */
    public function toOptionArray()

This method seems to be duplicated in your project.

    {
        $rolesCollection = $this->getAdminRolesCollection();
        $rolesArray = array();

        foreach ($rolesCollection as $role) {
            /** @var Mage_Admin_Model_Role $role */
            $rolesArray[] = array(
                'value' => $role->getRoleName(),
                'label' => $role->getRoleName(),
            );
        }

        return $rolesArray;
    }

    /**
     * Get options in "key => value" format
     * @return array
     * @author Cristian Quiroz <cris@qrz.io>
     */
    public function toArray()

This method seems to be duplicated in your project.

    {
        $rolesCollection = $this->getAdminRolesCollection();
        $rolesArray = array();

        foreach ($rolesCollection as $role) {
            /** @var Mage_Admin_Model_Role $role */
            $rolesArray[] = array(
                $role->getRoleName() => $role->getRoleName(),
            );
        }

        return $rolesArray;
    }

    /**
     * @return Mage_Admin_Model_Resource_Roles_Collection
     * @author Cristian Quiroz <cris@qrz.io>
     */
    protected function getAdminRolesCollection()
    {
        return Mage::getModel('admin/roles')->getCollection();
    }
}